run_tests: add summary to powerpc and s390

Looking at the last line was not enough as these architectures have
information about the exit on the last two lines. See the last 3 lines.

Signed-off-by

run_tests: add summary to powerpc and s390

Looking at the last line was not enough as these architectures have
information about the exit on the last two lines. See the last 3 lines.

Signed-off-by: Radim KrÄmář <rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

arch/run: simplify copy-paste of the command line

The major annoyance coming from errata was "-initrd `mktemp`" that had
to be removed before running the copy-pasted command line.
Move "-initrd ..."

arch/run: simplify copy-paste of the command line

The major annoyance coming from errata was "-initrd `mktemp`" that had
to be removed before running the copy-pasted command line.
Move "-initrd ..." part at the end of the line and hide it behind "#" if
the initird file is a temporary one.

This patch also brings s390 to use the same code as other architectures
and eliminates code duplication.

Signed-off-by: Radim KrÄmář <rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

mkstandalone: provide errata to tests

Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

arch-run: generate errata when no environ is provided

Provide a table mapping errata to minimum kernel versions and
a function that will use the host's kernel version to determine
the values for eac

arch-run: generate errata when no environ is provided

Provide a table mapping errata to minimum kernel versions and
a function that will use the host's kernel version to determine
the values for each errata variable. These errata variables, with
values based on the host kernel, are now provided to all unit
tests by default, if no environ is provided. Errata variables
passed from the run script environment still take precedence.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

arch-run: provide errata from run env

Allow the run script environment to provide ERRATA_* variables
to the unit tests. These variables will augment/override variables
in any provided unit test envi

arch-run: provide errata from run env

Allow the run script environment to provide ERRATA_* variables
to the unit tests. These variables will augment/override variables
in any provided unit test environ (the file specified with $ENV)
or trigger the creation of a temporary environ file, which contains
them.

Now something like

ERRATA_abcd01234567=y ./run_tests.sh

may be run in order to inform all unit tests that they may execute
all subtests guarded by ERRATA_abcd01234567.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

arch-run: introduce initrd_create

Encapsulate the preparation of the optional initrd command line
option.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redha

arch-run: introduce initrd_create

Encapsulate the preparation of the optional initrd command line
option.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

Makefiles: fix up the arm build dirs and include/link paths

We still need to tell the compiler the correct search path for finding
headers and the like. This is slightly complicated by the "dynamic"

Makefiles: fix up the arm build dirs and include/link paths

We still need to tell the compiler the correct search path for finding
headers and the like. This is slightly complicated by the "dynamic"
asm search path which is in our build tree but (may be) symlinked to
the right architectures headers.

Also we explicitly include SRCDIR for the linking scripts as VPATH
doesn't seem to find them well enough.

Also we set OBJDIRS for the lib/arm, lib/arm64 and generated
asm-offset files.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

arch-run: more qemu binary search cleanup

We use tabs in scripts/arch-run.bash, which the import of the
function forgot to convert to. Also, while touching all lines
to add the tabs, apply some mor

arch-run: more qemu binary search cleanup

We use tabs in scripts/arch-run.bash, which the import of the
function forgot to convert to. Also, while touching all lines
to add the tabs, apply some more cleanups and simplifications.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Message-Id: <20170424092618.21950-1-drjones@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

Use /bin/env in shebang to make scripts more portable

Some operating systems installs bash executable file to other directory
than /bin. So it is better to use env utility to find bash.

Signed-off-

Use /bin/env in shebang to make scripts more portable

Some operating systems installs bash executable file to other directory
than /bin. So it is better to use env utility to find bash.

Signed-off-by: Sergey Bronnikov <sergeyb@bronevichok.ru>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

scripts/arch-run: function to search qemu binary

Add a shell function to search qemu binary, similar to what x86/run does,
so that it can be reused for all arches.

Signed-off-by: Balamuruhan S <bal

scripts/arch-run: function to search qemu binary

Add a shell function to search qemu binary, similar to what x86/run does,
so that it can be reused for all arches.

Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
Message-Id: <1492629251-23267-1-git-send-email-bala24@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

Add the possibility to do simple migration tests

To be able to do simple migration tests with kvm-unit-tests, too,
add a helper script that does all the necessary work: Start two
instances of QEMU (

Add the possibility to do simple migration tests

To be able to do simple migration tests with kvm-unit-tests, too,
add a helper script that does all the necessary work: Start two
instances of QEMU (source and destination) with QMP sockets for
sending commands to them, then trigger the migration from one
instance to the other and finally signal the end of the migration
to the guest by injecting an NMI.
This helper script is now used automatically for powerpc tests
if the test is put into the "migration" group in the unittests.cfg
file.

Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>

show more ...

run_tests: add run all tests parameter

Tests can be flagged as 'nodefault' in unittests.cfg files. Allow
running all tests, including all nodefault tests by just calling
run_tests.sh with a new -a p

run_tests: add run all tests parameter

Tests can be flagged as 'nodefault' in unittests.cfg files. Allow
running all tests, including all nodefault tests by just calling
run_tests.sh with a new -a parameter. (Also cleanup the help text.)

Suggested-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

run_tests: put logs into per-test file

We were using test.log before to keep all the test logs. This patch
creates one log file per test case under logs/ directory with name
"TESTNAME.log". Meanwhil

run_tests: put logs into per-test file

We were using test.log before to keep all the test logs. This patch
creates one log file per test case under logs/ directory with name
"TESTNAME.log". Meanwhile, we will keep the last time log into
logs.old/.

Renaming scripts/functions.bash into scripts/common.bash to store some
more global variables.

Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

Add git-diff orderFile

It's helpful to have a common order of file types in patches.
Applying git-diff's orderFile feature allows us to do that. Just
do 'git config diff.orderFile scripts/git.diffor

Add git-diff orderFile

It's helpful to have a common order of file types in patches.
Applying git-diff's orderFile feature allows us to do that. Just
do 'git config diff.orderFile scripts/git.difforder' to enable it.

Acked-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

arch-run: fix terminal issues without stty

This patch reverts the stty parts of 8727c886 "runtime: better
handling of QEMU aborts", as we can more robustly fix the same
issue by simply redirecting /

arch-run: fix terminal issues without stty

This patch reverts the stty parts of 8727c886 "runtime: better
handling of QEMU aborts", as we can more robustly fix the same
issue by simply redirecting /dev/null into qemu's stdin. The
obvious side effect of this is that serial input will no longer
be wired up to the tty (or any other input file descriptor), but
unit tests do not, and should not, be reading from the serial port
anyway.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

report: move blank line to better side of SUMMARY

Currently test.log gets output of the form

test1-command-line
test1-output

SUMMARY:
test2-command-line
test2-output

SUMMARY:
test3-command

report: move blank line to better side of SUMMARY

Currently test.log gets output of the form

test1-command-line
test1-output

SUMMARY:
test2-command-line
test2-output

SUMMARY:
test3-command-line
...

Having a blank line before SUMMARY, and not after, it makes it
tough to group lines by eye. Change it to

test1-command-line
test1-output
SUMMARY:

test2-command-line
test2-output
SUMMARY:

test3-command-line
...

The empty line is moved from report_summary to runtime in order
to remove it altogether when running tests individually or as a
standalone.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

runtime: better handling of QEMU aborts

Add two changes to run_qemu. The first saves/restores terminal settings.
This solves an annoying loss of terminal echo when QEMU aborts during
a test run. The

runtime: better handling of QEMU aborts

Add two changes to run_qemu. The first saves/restores terminal settings.
This solves an annoying loss of terminal echo when QEMU aborts during
a test run. The second ensures we see a message about the abort, because
the "Aborted (core dumped)" message we should see gets eaten. We also
add a message to run()'s failure cases in its exit code processing to
handle signals in general.

Note, the first change is necessary because QEMU modifies the terminal
settings when using '-serial stdio', but calling abort() invokes exit
without first calling qemu_chr_free(serial_hds[0]) to restore them.

(Additionally we fixup the premature failure check to only capture the
last line, like it says it's doing.)

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andrew Jones <drjones@redhat.com>
[Redirected the abort message to stderr and moved it below `stty`.]
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

scripts/arch-run: print stderr immediately

Not doing so hid stderr output when the test was stuck and subsequently
killed with ^C.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

scripts/runtime: Add ability to mark test as don't run by default

Invoking run_tests.sh without the -g parameter will by default run all of
the tests for a given architecture. This patch series will

scripts/runtime: Add ability to mark test as don't run by default

Invoking run_tests.sh without the -g parameter will by default run all of
the tests for a given architecture. This patch series will add a test which
has the ability to bring down the host and thus it might be nice if we
double check that the user actually wants to run that test instead of
them unknowingly bringing down a machine they might not want to.

In order to do this add the option for a tests' group parameter in
unittests.cfg to include "nodefault" on order to indicate that it shouldn't
be run be default.

When tests are invoked via run_tests.sh those with the nodefault group
parameter will be skipped unless explicitly specified by the "-g" command
line option. When tests with the nodefault group parameter are built and
run standalone the user will be prompted on invocation to confirm that
they actually want to run the test.

This allows a developer to mark a test as having potentially adverse
effects and thus requires an extra level of confirmation from the user
before they are invoked. Existing functionality will be preserved and new
tests can choose any group other than "nodefault" if they want to be run
by default.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

show more ...

scripts/runtime: Adjust the premature_failure check

The premature_failure check fails on qemu-system-ppc64 as it uses
different message. This patch modifies the condition so it works
(hopefully) for

scripts/runtime: Adjust the premature_failure check

The premature_failure check fails on qemu-system-ppc64 as it uses
different message. This patch modifies the condition so it works
(hopefully) for all archs. (tested on x86_64, ppc64, aarch64)

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

scripts/arch-run: change QEMU failure detection

We FAIL the test whenever there is an output on stderr. QEMU or its
libraries can warn and the test could still work, so ignore any line
that has a w

scripts/arch-run: change QEMU failure detection

We FAIL the test whenever there is an output on stderr. QEMU or its
libraries can warn and the test could still work, so ignore any line
that has a warning keyword.

Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Message-Id: <1462984243-5783-3-git-send-email-rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

scripts/runtime: skip tests that cannot run

A case where QEMU won't run the kernel should be considered as skipped.
Hyper-V tests used to FAIL on old QEMUs. The infamous QEMU=/dev/null
FAIL streak

scripts/runtime: skip tests that cannot run

A case where QEMU won't run the kernel should be considered as skipped.
Hyper-V tests used to FAIL on old QEMUs. The infamous QEMU=/dev/null
FAIL streak is covered too. Some error messages in arch/run were
reworded, because they are now visible in summary.

Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Message-Id: <1462984243-5783-2-git-send-email-rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

run_tests: log stderr

Summary should provide all important information.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Message-Id: <1462984243-5783-1-git-send-email-rkrcmar@redhat.com>
Signed-off

run_tests: log stderr

Summary should provide all important information.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Message-Id: <1462984243-5783-1-git-send-email-rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

run_tests: print SUMMARY line in summary

SUMMARY line is present if the test uses lib/report. Summary contains
some interesting information, so duplicating the output isn't that big
of a cost. Our

run_tests: print SUMMARY line in summary

SUMMARY line is present if the test uses lib/report. Summary contains
some interesting information, so duplicating the output isn't that big
of a cost. Our log redirection got more complicated, though.

Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Message-Id: <1462983171-4208-10-git-send-email-rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...

scripts/runtime: consolidate summary tags

Turn skip into yellow SKIP and add reusable definitions of all tags.

Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@re

scripts/runtime: consolidate summary tags

Turn skip into yellow SKIP and add reusable definitions of all tags.

Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Message-Id: <1462983171-4208-9-git-send-email-rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

show more ...