1 // SPDX-License-Identifier: GPL-2.0-only
2 //
3 // HDA audio driver for Cirrus Logic CS35L56 smart amp
4 //
5 // Copyright (C) 2023 Cirrus Logic, Inc. and
6 // Cirrus Logic International Semiconductor Ltd.
7 //
8
9 #include <linux/acpi.h>
10 #include <linux/debugfs.h>
11 #include <linux/gpio/consumer.h>
12 #include <linux/module.h>
13 #include <linux/pm_runtime.h>
14 #include <linux/regmap.h>
15 #include <linux/slab.h>
16 #include <sound/core.h>
17 #include <sound/cs-amp-lib.h>
18 #include <sound/hda_codec.h>
19 #include <sound/tlv.h>
20 #include "cirrus_scodec.h"
21 #include "cs35l56_hda.h"
22 #include "hda_component.h"
23 #include "hda_cs_dsp_ctl.h"
24 #include "hda_generic.h"
25
26 /*
27 * The cs35l56_hda_dai_config[] reg sequence configures the device as
28 * ASP1_BCLK_FREQ = 3.072 MHz
29 * ASP1_RX_WIDTH = 32 cycles per slot, ASP1_TX_WIDTH = 32 cycles per slot, ASP1_FMT = I2S
30 * ASP1_DOUT_HIZ_CONTROL = Hi-Z during unused timeslots
31 * ASP1_RX_WL = 24 bits per sample
32 * ASP1_TX_WL = 24 bits per sample
33 * ASP1_RXn_EN 1..3 and ASP1_TXn_EN 1..4 disabled
34 *
35 * Override any Windows-specific mixer settings applied by the firmware.
36 */
37 static const struct reg_sequence cs35l56_hda_dai_config[] = {
38 { CS35L56_ASP1_CONTROL1, 0x00000021 },
39 { CS35L56_ASP1_CONTROL2, 0x20200200 },
40 { CS35L56_ASP1_CONTROL3, 0x00000003 },
41 { CS35L56_ASP1_FRAME_CONTROL1, 0x03020100 },
42 { CS35L56_ASP1_FRAME_CONTROL5, 0x00020100 },
43 { CS35L56_ASP1_DATA_CONTROL5, 0x00000018 },
44 { CS35L56_ASP1_DATA_CONTROL1, 0x00000018 },
45 { CS35L56_ASP1_ENABLES1, 0x00000000 },
46 { CS35L56_ASP1TX1_INPUT, 0x00000018 },
47 { CS35L56_ASP1TX2_INPUT, 0x00000019 },
48 { CS35L56_ASP1TX3_INPUT, 0x00000020 },
49 { CS35L56_ASP1TX4_INPUT, 0x00000028 },
50
51 };
52
cs35l56_hda_wait_dsp_ready(struct cs35l56_hda * cs35l56)53 static void cs35l56_hda_wait_dsp_ready(struct cs35l56_hda *cs35l56)
54 {
55 /* Wait for patching to complete */
56 flush_work(&cs35l56->dsp_work);
57 }
58
cs35l56_hda_play(struct cs35l56_hda * cs35l56)59 static void cs35l56_hda_play(struct cs35l56_hda *cs35l56)
60 {
61 unsigned int val;
62 int ret;
63
64 cs35l56_hda_wait_dsp_ready(cs35l56);
65
66 pm_runtime_get_sync(cs35l56->base.dev);
67 ret = cs35l56_mbox_send(&cs35l56->base, CS35L56_MBOX_CMD_AUDIO_PLAY);
68 if (ret == 0) {
69 /* Wait for firmware to enter PS0 power state */
70 ret = regmap_read_poll_timeout(cs35l56->base.regmap,
71 CS35L56_TRANSDUCER_ACTUAL_PS,
72 val, (val == CS35L56_PS0),
73 CS35L56_PS0_POLL_US,
74 CS35L56_PS0_TIMEOUT_US);
75 if (ret)
76 dev_warn(cs35l56->base.dev, "PS0 wait failed: %d\n", ret);
77 }
78 regmap_set_bits(cs35l56->base.regmap, CS35L56_ASP1_ENABLES1,
79 BIT(CS35L56_ASP_RX1_EN_SHIFT) | BIT(CS35L56_ASP_RX2_EN_SHIFT) |
80 cs35l56->asp_tx_mask);
81 cs35l56->playing = true;
82 }
83
cs35l56_hda_pause(struct cs35l56_hda * cs35l56)84 static void cs35l56_hda_pause(struct cs35l56_hda *cs35l56)
85 {
86 cs35l56->playing = false;
87 cs35l56_mbox_send(&cs35l56->base, CS35L56_MBOX_CMD_AUDIO_PAUSE);
88 regmap_clear_bits(cs35l56->base.regmap, CS35L56_ASP1_ENABLES1,
89 BIT(CS35L56_ASP_RX1_EN_SHIFT) | BIT(CS35L56_ASP_RX2_EN_SHIFT) |
90 BIT(CS35L56_ASP_TX1_EN_SHIFT) | BIT(CS35L56_ASP_TX2_EN_SHIFT) |
91 BIT(CS35L56_ASP_TX3_EN_SHIFT) | BIT(CS35L56_ASP_TX4_EN_SHIFT));
92
93 pm_runtime_mark_last_busy(cs35l56->base.dev);
94 pm_runtime_put_autosuspend(cs35l56->base.dev);
95 }
96
cs35l56_hda_playback_hook(struct device * dev,int action)97 static void cs35l56_hda_playback_hook(struct device *dev, int action)
98 {
99 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
100
101 dev_dbg(cs35l56->base.dev, "%s()%d: action: %d\n", __func__, __LINE__, action);
102
103 switch (action) {
104 case HDA_GEN_PCM_ACT_PREPARE:
105 if (cs35l56->playing)
106 break;
107
108 /* If we're suspended: flag that resume should start playback */
109 if (cs35l56->suspended) {
110 cs35l56->playing = true;
111 break;
112 }
113
114 cs35l56_hda_play(cs35l56);
115 break;
116 case HDA_GEN_PCM_ACT_CLEANUP:
117 if (!cs35l56->playing)
118 break;
119
120 cs35l56_hda_pause(cs35l56);
121 break;
122 default:
123 break;
124 }
125 }
126
cs35l56_hda_runtime_suspend(struct device * dev)127 static int cs35l56_hda_runtime_suspend(struct device *dev)
128 {
129 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
130
131 if (cs35l56->cs_dsp.booted)
132 cs_dsp_stop(&cs35l56->cs_dsp);
133
134 return cs35l56_runtime_suspend_common(&cs35l56->base);
135 }
136
cs35l56_hda_runtime_resume(struct device * dev)137 static int cs35l56_hda_runtime_resume(struct device *dev)
138 {
139 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
140 int ret;
141
142 ret = cs35l56_runtime_resume_common(&cs35l56->base, false);
143 if (ret < 0)
144 return ret;
145
146 if (cs35l56->cs_dsp.booted) {
147 ret = cs_dsp_run(&cs35l56->cs_dsp);
148 if (ret) {
149 dev_dbg(cs35l56->base.dev, "%s: cs_dsp_run ret %d\n", __func__, ret);
150 goto err;
151 }
152 }
153
154 return 0;
155
156 err:
157 cs35l56_mbox_send(&cs35l56->base, CS35L56_MBOX_CMD_ALLOW_AUTO_HIBERNATE);
158 regmap_write(cs35l56->base.regmap, CS35L56_DSP_VIRTUAL1_MBOX_1,
159 CS35L56_MBOX_CMD_HIBERNATE_NOW);
160
161 regcache_cache_only(cs35l56->base.regmap, true);
162
163 return ret;
164 }
165
cs35l56_hda_mixer_info(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_info * uinfo)166 static int cs35l56_hda_mixer_info(struct snd_kcontrol *kcontrol,
167 struct snd_ctl_elem_info *uinfo)
168 {
169 uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
170 uinfo->count = 1;
171 uinfo->value.enumerated.items = CS35L56_NUM_INPUT_SRC;
172 if (uinfo->value.enumerated.item >= CS35L56_NUM_INPUT_SRC)
173 uinfo->value.enumerated.item = CS35L56_NUM_INPUT_SRC - 1;
174 strscpy(uinfo->value.enumerated.name, cs35l56_tx_input_texts[uinfo->value.enumerated.item],
175 sizeof(uinfo->value.enumerated.name));
176
177 return 0;
178 }
179
cs35l56_hda_mixer_get(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_value * ucontrol)180 static int cs35l56_hda_mixer_get(struct snd_kcontrol *kcontrol,
181 struct snd_ctl_elem_value *ucontrol)
182 {
183 struct cs35l56_hda *cs35l56 = (struct cs35l56_hda *)kcontrol->private_data;
184 unsigned int reg_val;
185 int i;
186
187 cs35l56_hda_wait_dsp_ready(cs35l56);
188
189 regmap_read(cs35l56->base.regmap, kcontrol->private_value, ®_val);
190 reg_val &= CS35L56_ASP_TXn_SRC_MASK;
191
192 for (i = 0; i < CS35L56_NUM_INPUT_SRC; ++i) {
193 if (cs35l56_tx_input_values[i] == reg_val) {
194 ucontrol->value.enumerated.item[0] = i;
195 break;
196 }
197 }
198
199 return 0;
200 }
201
cs35l56_hda_mixer_put(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_value * ucontrol)202 static int cs35l56_hda_mixer_put(struct snd_kcontrol *kcontrol,
203 struct snd_ctl_elem_value *ucontrol)
204 {
205 struct cs35l56_hda *cs35l56 = (struct cs35l56_hda *)kcontrol->private_data;
206 unsigned int item = ucontrol->value.enumerated.item[0];
207 bool changed;
208
209 if (item >= CS35L56_NUM_INPUT_SRC)
210 return -EINVAL;
211
212 cs35l56_hda_wait_dsp_ready(cs35l56);
213
214 regmap_update_bits_check(cs35l56->base.regmap, kcontrol->private_value,
215 CS35L56_INPUT_MASK, cs35l56_tx_input_values[item],
216 &changed);
217
218 return changed;
219 }
220
cs35l56_hda_posture_info(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_info * uinfo)221 static int cs35l56_hda_posture_info(struct snd_kcontrol *kcontrol,
222 struct snd_ctl_elem_info *uinfo)
223 {
224 uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
225 uinfo->count = 1;
226 uinfo->value.integer.min = CS35L56_MAIN_POSTURE_MIN;
227 uinfo->value.integer.max = CS35L56_MAIN_POSTURE_MAX;
228 return 0;
229 }
230
cs35l56_hda_posture_get(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_value * ucontrol)231 static int cs35l56_hda_posture_get(struct snd_kcontrol *kcontrol,
232 struct snd_ctl_elem_value *ucontrol)
233 {
234 struct cs35l56_hda *cs35l56 = (struct cs35l56_hda *)kcontrol->private_data;
235 unsigned int pos;
236 int ret;
237
238 cs35l56_hda_wait_dsp_ready(cs35l56);
239
240 ret = regmap_read(cs35l56->base.regmap, CS35L56_MAIN_POSTURE_NUMBER, &pos);
241 if (ret)
242 return ret;
243
244 ucontrol->value.integer.value[0] = pos;
245
246 return 0;
247 }
248
cs35l56_hda_posture_put(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_value * ucontrol)249 static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol,
250 struct snd_ctl_elem_value *ucontrol)
251 {
252 struct cs35l56_hda *cs35l56 = (struct cs35l56_hda *)kcontrol->private_data;
253 unsigned long pos = ucontrol->value.integer.value[0];
254 bool changed;
255 int ret;
256
257 if ((pos < CS35L56_MAIN_POSTURE_MIN) ||
258 (pos > CS35L56_MAIN_POSTURE_MAX))
259 return -EINVAL;
260
261 cs35l56_hda_wait_dsp_ready(cs35l56);
262
263 ret = regmap_update_bits_check(cs35l56->base.regmap,
264 CS35L56_MAIN_POSTURE_NUMBER,
265 CS35L56_MAIN_POSTURE_MASK,
266 pos, &changed);
267 if (ret)
268 return ret;
269
270 return changed;
271 }
272
273 static const struct {
274 const char *name;
275 unsigned int reg;
276 } cs35l56_hda_mixer_controls[] = {
277 { "ASP1 TX1 Source", CS35L56_ASP1TX1_INPUT },
278 { "ASP1 TX2 Source", CS35L56_ASP1TX2_INPUT },
279 { "ASP1 TX3 Source", CS35L56_ASP1TX3_INPUT },
280 { "ASP1 TX4 Source", CS35L56_ASP1TX4_INPUT },
281 };
282
283 static const DECLARE_TLV_DB_SCALE(cs35l56_hda_vol_tlv, -10000, 25, 0);
284
cs35l56_hda_vol_info(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_info * uinfo)285 static int cs35l56_hda_vol_info(struct snd_kcontrol *kcontrol,
286 struct snd_ctl_elem_info *uinfo)
287 {
288 uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
289 uinfo->count = 1;
290 uinfo->value.integer.step = 1;
291 uinfo->value.integer.min = 0;
292 uinfo->value.integer.max = CS35L56_MAIN_RENDER_USER_VOLUME_MAX -
293 CS35L56_MAIN_RENDER_USER_VOLUME_MIN;
294
295 return 0;
296 }
297
cs35l56_hda_vol_get(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_value * ucontrol)298 static int cs35l56_hda_vol_get(struct snd_kcontrol *kcontrol,
299 struct snd_ctl_elem_value *ucontrol)
300 {
301 struct cs35l56_hda *cs35l56 = (struct cs35l56_hda *)kcontrol->private_data;
302 unsigned int raw_vol;
303 int vol;
304 int ret;
305
306 cs35l56_hda_wait_dsp_ready(cs35l56);
307
308 ret = regmap_read(cs35l56->base.regmap, CS35L56_MAIN_RENDER_USER_VOLUME, &raw_vol);
309
310 if (ret)
311 return ret;
312
313 vol = (s16)(raw_vol & 0xFFFF);
314 vol >>= CS35L56_MAIN_RENDER_USER_VOLUME_SHIFT;
315
316 if (vol & BIT(CS35L56_MAIN_RENDER_USER_VOLUME_SIGNBIT))
317 vol |= ~((int)(BIT(CS35L56_MAIN_RENDER_USER_VOLUME_SIGNBIT) - 1));
318
319 ucontrol->value.integer.value[0] = vol - CS35L56_MAIN_RENDER_USER_VOLUME_MIN;
320
321 return 0;
322 }
323
cs35l56_hda_vol_put(struct snd_kcontrol * kcontrol,struct snd_ctl_elem_value * ucontrol)324 static int cs35l56_hda_vol_put(struct snd_kcontrol *kcontrol,
325 struct snd_ctl_elem_value *ucontrol)
326 {
327 struct cs35l56_hda *cs35l56 = (struct cs35l56_hda *)kcontrol->private_data;
328 long vol = ucontrol->value.integer.value[0];
329 unsigned int raw_vol;
330 bool changed;
331 int ret;
332
333 if ((vol < 0) || (vol > (CS35L56_MAIN_RENDER_USER_VOLUME_MAX -
334 CS35L56_MAIN_RENDER_USER_VOLUME_MIN)))
335 return -EINVAL;
336
337 raw_vol = (vol + CS35L56_MAIN_RENDER_USER_VOLUME_MIN) <<
338 CS35L56_MAIN_RENDER_USER_VOLUME_SHIFT;
339
340 cs35l56_hda_wait_dsp_ready(cs35l56);
341
342 ret = regmap_update_bits_check(cs35l56->base.regmap,
343 CS35L56_MAIN_RENDER_USER_VOLUME,
344 CS35L56_MAIN_RENDER_USER_VOLUME_MASK,
345 raw_vol, &changed);
346 if (ret)
347 return ret;
348
349 return changed;
350 }
351
cs35l56_hda_create_controls(struct cs35l56_hda * cs35l56)352 static void cs35l56_hda_create_controls(struct cs35l56_hda *cs35l56)
353 {
354 struct snd_kcontrol_new ctl_template = {
355 .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
356 .access = SNDRV_CTL_ELEM_ACCESS_READWRITE,
357 .info = cs35l56_hda_posture_info,
358 .get = cs35l56_hda_posture_get,
359 .put = cs35l56_hda_posture_put,
360 };
361 char name[64];
362 int i;
363
364 snprintf(name, sizeof(name), "%s Posture Number", cs35l56->amp_name);
365 ctl_template.name = name;
366 cs35l56->posture_ctl = snd_ctl_new1(&ctl_template, cs35l56);
367 if (snd_ctl_add(cs35l56->codec->card, cs35l56->posture_ctl))
368 dev_err(cs35l56->base.dev, "Failed to add KControl: %s\n", ctl_template.name);
369
370 /* Mixer controls */
371 ctl_template.info = cs35l56_hda_mixer_info;
372 ctl_template.get = cs35l56_hda_mixer_get;
373 ctl_template.put = cs35l56_hda_mixer_put;
374
375 BUILD_BUG_ON(ARRAY_SIZE(cs35l56->mixer_ctl) != ARRAY_SIZE(cs35l56_hda_mixer_controls));
376
377 for (i = 0; i < ARRAY_SIZE(cs35l56_hda_mixer_controls); ++i) {
378 snprintf(name, sizeof(name), "%s %s", cs35l56->amp_name,
379 cs35l56_hda_mixer_controls[i].name);
380 ctl_template.private_value = cs35l56_hda_mixer_controls[i].reg;
381 cs35l56->mixer_ctl[i] = snd_ctl_new1(&ctl_template, cs35l56);
382 if (snd_ctl_add(cs35l56->codec->card, cs35l56->mixer_ctl[i])) {
383 dev_err(cs35l56->base.dev, "Failed to add KControl: %s\n",
384 ctl_template.name);
385 }
386 }
387
388 ctl_template.info = cs35l56_hda_vol_info;
389 ctl_template.get = cs35l56_hda_vol_get;
390 ctl_template.put = cs35l56_hda_vol_put;
391 ctl_template.access = (SNDRV_CTL_ELEM_ACCESS_READWRITE | SNDRV_CTL_ELEM_ACCESS_TLV_READ);
392 ctl_template.tlv.p = cs35l56_hda_vol_tlv;
393 snprintf(name, sizeof(name), "%s Speaker Playback Volume", cs35l56->amp_name);
394 ctl_template.name = name;
395 cs35l56->volume_ctl = snd_ctl_new1(&ctl_template, cs35l56);
396 if (snd_ctl_add(cs35l56->codec->card, cs35l56->volume_ctl))
397 dev_err(cs35l56->base.dev, "Failed to add KControl: %s\n", ctl_template.name);
398 }
399
cs35l56_hda_remove_controls(struct cs35l56_hda * cs35l56)400 static void cs35l56_hda_remove_controls(struct cs35l56_hda *cs35l56)
401 {
402 int i;
403
404 for (i = ARRAY_SIZE(cs35l56->mixer_ctl) - 1; i >= 0; i--)
405 snd_ctl_remove(cs35l56->codec->card, cs35l56->mixer_ctl[i]);
406
407 snd_ctl_remove(cs35l56->codec->card, cs35l56->posture_ctl);
408 snd_ctl_remove(cs35l56->codec->card, cs35l56->volume_ctl);
409 }
410
411 static const struct cs_dsp_client_ops cs35l56_hda_client_ops = {
412 /* cs_dsp requires the client to provide this even if it is empty */
413 };
414
cs35l56_hda_request_firmware_file(struct cs35l56_hda * cs35l56,const struct firmware ** firmware,char ** filename,const char * base_name,const char * system_name,const char * amp_name,const char * filetype)415 static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56,
416 const struct firmware **firmware, char **filename,
417 const char *base_name, const char *system_name,
418 const char *amp_name,
419 const char *filetype)
420 {
421 char *s, c;
422 int ret = 0;
423
424 if (system_name && amp_name)
425 *filename = kasprintf(GFP_KERNEL, "%s-%s-%s.%s", base_name,
426 system_name, amp_name, filetype);
427 else if (system_name)
428 *filename = kasprintf(GFP_KERNEL, "%s-%s.%s", base_name,
429 system_name, filetype);
430 else
431 *filename = kasprintf(GFP_KERNEL, "%s.%s", base_name, filetype);
432
433 if (!*filename)
434 return -ENOMEM;
435
436 /*
437 * Make sure that filename is lower-case and any non alpha-numeric
438 * characters except full stop and forward slash are replaced with
439 * hyphens.
440 */
441 s = *filename;
442 while (*s) {
443 c = *s;
444 if (isalnum(c))
445 *s = tolower(c);
446 else if (c != '.' && c != '/')
447 *s = '-';
448 s++;
449 }
450
451 ret = firmware_request_nowarn(firmware, *filename, cs35l56->base.dev);
452 if (ret) {
453 dev_dbg(cs35l56->base.dev, "Failed to request '%s'\n", *filename);
454 kfree(*filename);
455 *filename = NULL;
456 return ret;
457 }
458
459 dev_dbg(cs35l56->base.dev, "Found '%s'\n", *filename);
460
461 return 0;
462 }
463
cs35l56_hda_request_firmware_files(struct cs35l56_hda * cs35l56,unsigned int preloaded_fw_ver,const struct firmware ** wmfw_firmware,char ** wmfw_filename,const struct firmware ** coeff_firmware,char ** coeff_filename)464 static void cs35l56_hda_request_firmware_files(struct cs35l56_hda *cs35l56,
465 unsigned int preloaded_fw_ver,
466 const struct firmware **wmfw_firmware,
467 char **wmfw_filename,
468 const struct firmware **coeff_firmware,
469 char **coeff_filename)
470 {
471 const char *system_name = cs35l56->system_name;
472 const char *amp_name = cs35l56->amp_name;
473 char base_name[37];
474 int ret;
475
476 if (preloaded_fw_ver) {
477 snprintf(base_name, sizeof(base_name),
478 "cirrus/cs35l%02x-%02x%s-%06x-dsp1-misc",
479 cs35l56->base.type,
480 cs35l56->base.rev,
481 cs35l56->base.secured ? "-s" : "",
482 preloaded_fw_ver & 0xffffff);
483 } else {
484 snprintf(base_name, sizeof(base_name),
485 "cirrus/cs35l%02x-%02x%s-dsp1-misc",
486 cs35l56->base.type,
487 cs35l56->base.rev,
488 cs35l56->base.secured ? "-s" : "");
489 }
490
491 if (system_name && amp_name) {
492 if (!cs35l56_hda_request_firmware_file(cs35l56, wmfw_firmware, wmfw_filename,
493 base_name, system_name, amp_name, "wmfw")) {
494 cs35l56_hda_request_firmware_file(cs35l56, coeff_firmware, coeff_filename,
495 base_name, system_name, amp_name, "bin");
496 return;
497 }
498 }
499
500 if (system_name) {
501 if (!cs35l56_hda_request_firmware_file(cs35l56, wmfw_firmware, wmfw_filename,
502 base_name, system_name, NULL, "wmfw")) {
503 if (amp_name)
504 cs35l56_hda_request_firmware_file(cs35l56,
505 coeff_firmware, coeff_filename,
506 base_name, system_name,
507 amp_name, "bin");
508 if (!*coeff_firmware)
509 cs35l56_hda_request_firmware_file(cs35l56,
510 coeff_firmware, coeff_filename,
511 base_name, system_name,
512 NULL, "bin");
513 return;
514 }
515
516 /*
517 * Check for system-specific bin files without wmfw before
518 * falling back to generic firmware
519 */
520 if (amp_name)
521 cs35l56_hda_request_firmware_file(cs35l56, coeff_firmware, coeff_filename,
522 base_name, system_name, amp_name, "bin");
523 if (!*coeff_firmware)
524 cs35l56_hda_request_firmware_file(cs35l56, coeff_firmware, coeff_filename,
525 base_name, system_name, NULL, "bin");
526
527 if (*coeff_firmware)
528 return;
529 }
530
531 ret = cs35l56_hda_request_firmware_file(cs35l56, wmfw_firmware, wmfw_filename,
532 base_name, NULL, NULL, "wmfw");
533 if (!ret) {
534 cs35l56_hda_request_firmware_file(cs35l56, coeff_firmware, coeff_filename,
535 base_name, NULL, NULL, "bin");
536 return;
537 }
538
539 if (!*coeff_firmware)
540 cs35l56_hda_request_firmware_file(cs35l56, coeff_firmware, coeff_filename,
541 base_name, NULL, NULL, "bin");
542 }
543
cs35l56_hda_release_firmware_files(const struct firmware * wmfw_firmware,char * wmfw_filename,const struct firmware * coeff_firmware,char * coeff_filename)544 static void cs35l56_hda_release_firmware_files(const struct firmware *wmfw_firmware,
545 char *wmfw_filename,
546 const struct firmware *coeff_firmware,
547 char *coeff_filename)
548 {
549 release_firmware(wmfw_firmware);
550 kfree(wmfw_filename);
551
552 release_firmware(coeff_firmware);
553 kfree(coeff_filename);
554 }
555
cs35l56_hda_apply_calibration(struct cs35l56_hda * cs35l56)556 static void cs35l56_hda_apply_calibration(struct cs35l56_hda *cs35l56)
557 {
558 int ret;
559
560 if (!cs35l56->base.cal_data_valid || cs35l56->base.secured)
561 return;
562
563 ret = cs_amp_write_cal_coeffs(&cs35l56->cs_dsp,
564 &cs35l56_calibration_controls,
565 &cs35l56->base.cal_data);
566 if (ret < 0)
567 dev_warn(cs35l56->base.dev, "Failed to write calibration: %d\n", ret);
568 else
569 dev_info(cs35l56->base.dev, "Calibration applied\n");
570 }
571
cs35l56_hda_fw_load(struct cs35l56_hda * cs35l56)572 static void cs35l56_hda_fw_load(struct cs35l56_hda *cs35l56)
573 {
574 const struct firmware *coeff_firmware = NULL;
575 const struct firmware *wmfw_firmware = NULL;
576 char *coeff_filename = NULL;
577 char *wmfw_filename = NULL;
578 unsigned int preloaded_fw_ver;
579 bool firmware_missing;
580 int ret;
581
582 /*
583 * Prepare for a new DSP power-up. If the DSP has had firmware
584 * downloaded previously then it needs to be powered down so that it
585 * can be updated.
586 */
587 if (cs35l56->base.fw_patched)
588 cs_dsp_power_down(&cs35l56->cs_dsp);
589
590 cs35l56->base.fw_patched = false;
591
592 ret = pm_runtime_resume_and_get(cs35l56->base.dev);
593 if (ret < 0) {
594 dev_err(cs35l56->base.dev, "Failed to resume and get %d\n", ret);
595 return;
596 }
597
598 /*
599 * The firmware can only be upgraded if it is currently running
600 * from the built-in ROM. If not, the wmfw/bin must be for the
601 * version of firmware that is running on the chip.
602 */
603 ret = cs35l56_read_prot_status(&cs35l56->base, &firmware_missing, &preloaded_fw_ver);
604 if (ret)
605 goto err_pm_put;
606
607 if (firmware_missing)
608 preloaded_fw_ver = 0;
609
610 cs35l56_hda_request_firmware_files(cs35l56, preloaded_fw_ver,
611 &wmfw_firmware, &wmfw_filename,
612 &coeff_firmware, &coeff_filename);
613
614 /*
615 * If the BIOS didn't patch the firmware a bin file is mandatory to
616 * enable the ASP·
617 */
618 if (!coeff_firmware && firmware_missing) {
619 dev_err(cs35l56->base.dev, ".bin file required but not found\n");
620 goto err_fw_release;
621 }
622
623 mutex_lock(&cs35l56->base.irq_lock);
624
625 /*
626 * If the firmware hasn't been patched it must be shutdown before
627 * doing a full patch and reset afterwards. If it is already
628 * running a patched version the firmware files only contain
629 * tunings and we can use the lower cost reinit sequence instead.
630 */
631 if (firmware_missing && (wmfw_firmware || coeff_firmware)) {
632 ret = cs35l56_firmware_shutdown(&cs35l56->base);
633 if (ret)
634 goto err;
635 }
636
637 ret = cs_dsp_power_up(&cs35l56->cs_dsp, wmfw_firmware, wmfw_filename,
638 coeff_firmware, coeff_filename, "misc");
639 if (ret) {
640 dev_dbg(cs35l56->base.dev, "%s: cs_dsp_power_up ret %d\n", __func__, ret);
641 goto err;
642 }
643
644 if (wmfw_filename)
645 dev_dbg(cs35l56->base.dev, "Loaded WMFW Firmware: %s\n", wmfw_filename);
646
647 if (coeff_filename)
648 dev_dbg(cs35l56->base.dev, "Loaded Coefficients: %s\n", coeff_filename);
649
650 /* If we downloaded firmware, reset the device and wait for it to boot */
651 if (firmware_missing && (wmfw_firmware || coeff_firmware)) {
652 cs35l56_system_reset(&cs35l56->base, false);
653 regcache_mark_dirty(cs35l56->base.regmap);
654 ret = cs35l56_wait_for_firmware_boot(&cs35l56->base);
655 if (ret)
656 goto err_powered_up;
657
658 regcache_cache_only(cs35l56->base.regmap, false);
659 }
660
661 /* Disable auto-hibernate so that runtime_pm has control */
662 ret = cs35l56_mbox_send(&cs35l56->base, CS35L56_MBOX_CMD_PREVENT_AUTO_HIBERNATE);
663 if (ret)
664 goto err_powered_up;
665
666 regcache_sync(cs35l56->base.regmap);
667
668 regmap_clear_bits(cs35l56->base.regmap, CS35L56_PROTECTION_STATUS,
669 CS35L56_FIRMWARE_MISSING);
670 cs35l56->base.fw_patched = true;
671
672 ret = cs_dsp_run(&cs35l56->cs_dsp);
673 if (ret)
674 dev_dbg(cs35l56->base.dev, "%s: cs_dsp_run ret %d\n", __func__, ret);
675
676 cs35l56_hda_apply_calibration(cs35l56);
677 ret = cs35l56_mbox_send(&cs35l56->base, CS35L56_MBOX_CMD_AUDIO_REINIT);
678 if (ret)
679 cs_dsp_stop(&cs35l56->cs_dsp);
680
681 err_powered_up:
682 if (!cs35l56->base.fw_patched)
683 cs_dsp_power_down(&cs35l56->cs_dsp);
684 err:
685 mutex_unlock(&cs35l56->base.irq_lock);
686 err_fw_release:
687 cs35l56_hda_release_firmware_files(wmfw_firmware, wmfw_filename,
688 coeff_firmware, coeff_filename);
689 err_pm_put:
690 pm_runtime_put(cs35l56->base.dev);
691 }
692
cs35l56_hda_dsp_work(struct work_struct * work)693 static void cs35l56_hda_dsp_work(struct work_struct *work)
694 {
695 struct cs35l56_hda *cs35l56 = container_of(work, struct cs35l56_hda, dsp_work);
696
697 cs35l56_hda_fw_load(cs35l56);
698 }
699
cs35l56_hda_bind(struct device * dev,struct device * master,void * master_data)700 static int cs35l56_hda_bind(struct device *dev, struct device *master, void *master_data)
701 {
702 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
703 struct hda_component_parent *parent = master_data;
704 struct hda_component *comp;
705
706 comp = hda_component_from_index(parent, cs35l56->index);
707 if (!comp)
708 return -EINVAL;
709
710 if (comp->dev)
711 return -EBUSY;
712
713 comp->dev = dev;
714 cs35l56->codec = parent->codec;
715 strscpy(comp->name, dev_name(dev), sizeof(comp->name));
716 comp->playback_hook = cs35l56_hda_playback_hook;
717
718 queue_work(system_long_wq, &cs35l56->dsp_work);
719
720 cs35l56_hda_create_controls(cs35l56);
721
722 #if IS_ENABLED(CONFIG_SND_DEBUG)
723 cs35l56->debugfs_root = debugfs_create_dir(dev_name(cs35l56->base.dev), sound_debugfs_root);
724 cs_dsp_init_debugfs(&cs35l56->cs_dsp, cs35l56->debugfs_root);
725 #endif
726
727 dev_dbg(cs35l56->base.dev, "Bound\n");
728
729 return 0;
730 }
731
cs35l56_hda_unbind(struct device * dev,struct device * master,void * master_data)732 static void cs35l56_hda_unbind(struct device *dev, struct device *master, void *master_data)
733 {
734 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
735 struct hda_component_parent *parent = master_data;
736 struct hda_component *comp;
737
738 cancel_work_sync(&cs35l56->dsp_work);
739
740 cs35l56_hda_remove_controls(cs35l56);
741
742 #if IS_ENABLED(CONFIG_SND_DEBUG)
743 cs_dsp_cleanup_debugfs(&cs35l56->cs_dsp);
744 debugfs_remove_recursive(cs35l56->debugfs_root);
745 #endif
746
747 if (cs35l56->base.fw_patched)
748 cs_dsp_power_down(&cs35l56->cs_dsp);
749
750 comp = hda_component_from_index(parent, cs35l56->index);
751 if (comp && (comp->dev == dev))
752 memset(comp, 0, sizeof(*comp));
753
754 cs35l56->codec = NULL;
755
756 dev_dbg(cs35l56->base.dev, "Unbound\n");
757 }
758
759 static const struct component_ops cs35l56_hda_comp_ops = {
760 .bind = cs35l56_hda_bind,
761 .unbind = cs35l56_hda_unbind,
762 };
763
cs35l56_hda_system_suspend(struct device * dev)764 static int cs35l56_hda_system_suspend(struct device *dev)
765 {
766 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
767
768 cs35l56_hda_wait_dsp_ready(cs35l56);
769
770 if (cs35l56->playing)
771 cs35l56_hda_pause(cs35l56);
772
773 cs35l56->suspended = true;
774
775 /*
776 * The interrupt line is normally shared, but after we start suspending
777 * we can't check if our device is the source of an interrupt, and can't
778 * clear it. Prevent this race by temporarily disabling the parent irq
779 * until we reach _no_irq.
780 */
781 if (cs35l56->base.irq)
782 disable_irq(cs35l56->base.irq);
783
784 return pm_runtime_force_suspend(dev);
785 }
786
cs35l56_hda_system_suspend_late(struct device * dev)787 static int cs35l56_hda_system_suspend_late(struct device *dev)
788 {
789 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
790
791 /*
792 * RESET is usually shared by all amps so it must not be asserted until
793 * all driver instances have done their suspend() stage.
794 */
795 if (cs35l56->base.reset_gpio) {
796 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);
797 cs35l56_wait_min_reset_pulse();
798 }
799
800 return 0;
801 }
802
cs35l56_hda_system_suspend_no_irq(struct device * dev)803 static int cs35l56_hda_system_suspend_no_irq(struct device *dev)
804 {
805 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
806
807 /* Handlers are now disabled so the parent IRQ can safely be re-enabled. */
808 if (cs35l56->base.irq)
809 enable_irq(cs35l56->base.irq);
810
811 return 0;
812 }
813
cs35l56_hda_system_resume_no_irq(struct device * dev)814 static int cs35l56_hda_system_resume_no_irq(struct device *dev)
815 {
816 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
817
818 /*
819 * WAKE interrupts unmask if the CS35L56 hibernates, which can cause
820 * spurious interrupts, and the interrupt line is normally shared.
821 * We can't check if our device is the source of an interrupt, and can't
822 * clear it, until it has fully resumed. Prevent this race by temporarily
823 * disabling the parent irq until we complete resume().
824 */
825 if (cs35l56->base.irq)
826 disable_irq(cs35l56->base.irq);
827
828 return 0;
829 }
830
cs35l56_hda_system_resume_early(struct device * dev)831 static int cs35l56_hda_system_resume_early(struct device *dev)
832 {
833 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
834
835 /* Ensure a spec-compliant RESET pulse. */
836 if (cs35l56->base.reset_gpio) {
837 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);
838 cs35l56_wait_min_reset_pulse();
839
840 /* Release shared RESET before drivers start resume(). */
841 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 1);
842 cs35l56_wait_control_port_ready();
843 }
844
845 return 0;
846 }
847
cs35l56_hda_system_resume(struct device * dev)848 static int cs35l56_hda_system_resume(struct device *dev)
849 {
850 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
851 int ret;
852
853 /* Undo pm_runtime_force_suspend() before re-enabling the irq */
854 ret = pm_runtime_force_resume(dev);
855 if (cs35l56->base.irq)
856 enable_irq(cs35l56->base.irq);
857
858 if (ret)
859 return ret;
860
861 cs35l56->suspended = false;
862
863 if (!cs35l56->codec)
864 return 0;
865
866 ret = cs35l56_is_fw_reload_needed(&cs35l56->base);
867 dev_dbg(cs35l56->base.dev, "fw_reload_needed: %d\n", ret);
868 if (ret > 0)
869 queue_work(system_long_wq, &cs35l56->dsp_work);
870
871 if (cs35l56->playing)
872 cs35l56_hda_play(cs35l56);
873
874 return 0;
875 }
876
cs35l56_hda_read_acpi(struct cs35l56_hda * cs35l56,int hid,int id)877 static int cs35l56_hda_read_acpi(struct cs35l56_hda *cs35l56, int hid, int id)
878 {
879 u32 values[HDA_MAX_COMPONENTS];
880 char hid_string[8];
881 struct acpi_device *adev;
882 const char *property, *sub;
883 size_t nval;
884 int i, ret;
885
886 /*
887 * ACPI_COMPANION isn't available when this driver was instantiated by
888 * the serial-multi-instantiate driver, so lookup the node by HID
889 */
890 if (!ACPI_COMPANION(cs35l56->base.dev)) {
891 snprintf(hid_string, sizeof(hid_string), "CSC%04X", hid);
892 adev = acpi_dev_get_first_match_dev(hid_string, NULL, -1);
893 if (!adev) {
894 dev_err(cs35l56->base.dev, "Failed to find an ACPI device for %s\n",
895 dev_name(cs35l56->base.dev));
896 return -ENODEV;
897 }
898 ACPI_COMPANION_SET(cs35l56->base.dev, adev);
899 }
900
901 property = "cirrus,dev-index";
902 ret = device_property_count_u32(cs35l56->base.dev, property);
903 if (ret <= 0)
904 goto err;
905
906 if (ret > ARRAY_SIZE(values)) {
907 ret = -EINVAL;
908 goto err;
909 }
910 nval = ret;
911
912 ret = device_property_read_u32_array(cs35l56->base.dev, property, values, nval);
913 if (ret)
914 goto err;
915
916 cs35l56->index = -1;
917 for (i = 0; i < nval; i++) {
918 if (values[i] == id) {
919 cs35l56->index = i;
920 break;
921 }
922 }
923 /*
924 * It's not an error for the ID to be missing: for I2C there can be
925 * an alias address that is not a real device. So reject silently.
926 */
927 if (cs35l56->index == -1) {
928 dev_dbg(cs35l56->base.dev, "No index found in %s\n", property);
929 ret = -ENODEV;
930 goto err;
931 }
932
933 sub = acpi_get_subsystem_id(ACPI_HANDLE(cs35l56->base.dev));
934
935 if (IS_ERR(sub)) {
936 dev_info(cs35l56->base.dev,
937 "Read ACPI _SUB failed(%ld): fallback to generic firmware\n",
938 PTR_ERR(sub));
939 } else {
940 ret = cirrus_scodec_get_speaker_id(cs35l56->base.dev, cs35l56->index, nval, -1);
941 if (ret == -ENOENT) {
942 cs35l56->system_name = sub;
943 } else if (ret >= 0) {
944 cs35l56->system_name = kasprintf(GFP_KERNEL, "%s-spkid%d", sub, ret);
945 kfree(sub);
946 if (!cs35l56->system_name)
947 return -ENOMEM;
948 } else {
949 return ret;
950 }
951 }
952
953 cs35l56->base.reset_gpio = devm_gpiod_get_index_optional(cs35l56->base.dev,
954 "reset",
955 cs35l56->index,
956 GPIOD_OUT_LOW);
957 if (IS_ERR(cs35l56->base.reset_gpio)) {
958 ret = PTR_ERR(cs35l56->base.reset_gpio);
959
960 /*
961 * If RESET is shared the first amp to probe will grab the reset
962 * line and reset all the amps
963 */
964 if (ret != -EBUSY)
965 return dev_err_probe(cs35l56->base.dev, ret, "Failed to get reset GPIO\n");
966
967 dev_info(cs35l56->base.dev, "Reset GPIO busy, assume shared reset\n");
968 cs35l56->base.reset_gpio = NULL;
969 }
970
971 return 0;
972
973 err:
974 if (ret != -ENODEV)
975 dev_err(cs35l56->base.dev, "Failed property %s: %d\n", property, ret);
976
977 return ret;
978 }
979
cs35l56_hda_common_probe(struct cs35l56_hda * cs35l56,int hid,int id)980 int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
981 {
982 int ret;
983
984 mutex_init(&cs35l56->base.irq_lock);
985 dev_set_drvdata(cs35l56->base.dev, cs35l56);
986
987 INIT_WORK(&cs35l56->dsp_work, cs35l56_hda_dsp_work);
988
989 ret = cs35l56_hda_read_acpi(cs35l56, hid, id);
990 if (ret)
991 goto err;
992
993 cs35l56->amp_name = devm_kasprintf(cs35l56->base.dev, GFP_KERNEL, "AMP%d",
994 cs35l56->index + 1);
995 if (!cs35l56->amp_name) {
996 ret = -ENOMEM;
997 goto err;
998 }
999
1000 cs35l56->base.cal_index = -1;
1001
1002 cs35l56_init_cs_dsp(&cs35l56->base, &cs35l56->cs_dsp);
1003 cs35l56->cs_dsp.client_ops = &cs35l56_hda_client_ops;
1004
1005 if (cs35l56->base.reset_gpio) {
1006 dev_dbg(cs35l56->base.dev, "Hard reset\n");
1007
1008 /*
1009 * The GPIOD_OUT_LOW to *_gpiod_get_*() will be ignored if the
1010 * ACPI defines a different default state. So explicitly set low.
1011 */
1012 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);
1013 cs35l56_wait_min_reset_pulse();
1014 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 1);
1015 }
1016
1017 ret = cs35l56_hw_init(&cs35l56->base);
1018 if (ret < 0)
1019 goto err;
1020
1021 /* Reset the device and wait for it to boot */
1022 cs35l56_system_reset(&cs35l56->base, false);
1023 ret = cs35l56_wait_for_firmware_boot(&cs35l56->base);
1024 if (ret)
1025 goto err;
1026
1027 regcache_cache_only(cs35l56->base.regmap, false);
1028
1029 ret = cs35l56_set_patch(&cs35l56->base);
1030 if (ret)
1031 goto err;
1032
1033 regcache_mark_dirty(cs35l56->base.regmap);
1034 regcache_sync(cs35l56->base.regmap);
1035
1036 /* Disable auto-hibernate so that runtime_pm has control */
1037 ret = cs35l56_mbox_send(&cs35l56->base, CS35L56_MBOX_CMD_PREVENT_AUTO_HIBERNATE);
1038 if (ret)
1039 goto err;
1040
1041 ret = cs35l56_get_calibration(&cs35l56->base);
1042 if (ret)
1043 goto err;
1044
1045 ret = cs_dsp_halo_init(&cs35l56->cs_dsp);
1046 if (ret) {
1047 dev_err_probe(cs35l56->base.dev, ret, "cs_dsp_halo_init failed\n");
1048 goto err;
1049 }
1050
1051 dev_info(cs35l56->base.dev, "DSP system name: '%s', amp name: '%s'\n",
1052 cs35l56->system_name, cs35l56->amp_name);
1053
1054 regmap_multi_reg_write(cs35l56->base.regmap, cs35l56_hda_dai_config,
1055 ARRAY_SIZE(cs35l56_hda_dai_config));
1056
1057 /*
1058 * By default only enable one ASP1TXn, where n=amplifier index,
1059 * This prevents multiple amps trying to drive the same slot.
1060 */
1061 cs35l56->asp_tx_mask = BIT(cs35l56->index);
1062
1063 pm_runtime_set_autosuspend_delay(cs35l56->base.dev, 3000);
1064 pm_runtime_use_autosuspend(cs35l56->base.dev);
1065 pm_runtime_set_active(cs35l56->base.dev);
1066 pm_runtime_mark_last_busy(cs35l56->base.dev);
1067 pm_runtime_enable(cs35l56->base.dev);
1068
1069 cs35l56->base.init_done = true;
1070
1071 ret = component_add(cs35l56->base.dev, &cs35l56_hda_comp_ops);
1072 if (ret) {
1073 dev_err(cs35l56->base.dev, "Register component failed: %d\n", ret);
1074 goto pm_err;
1075 }
1076
1077 return 0;
1078
1079 pm_err:
1080 pm_runtime_disable(cs35l56->base.dev);
1081 cs_dsp_remove(&cs35l56->cs_dsp);
1082 err:
1083 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);
1084
1085 return ret;
1086 }
1087 EXPORT_SYMBOL_NS_GPL(cs35l56_hda_common_probe, "SND_HDA_SCODEC_CS35L56");
1088
cs35l56_hda_remove(struct device * dev)1089 void cs35l56_hda_remove(struct device *dev)
1090 {
1091 struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
1092
1093 component_del(cs35l56->base.dev, &cs35l56_hda_comp_ops);
1094
1095 pm_runtime_dont_use_autosuspend(cs35l56->base.dev);
1096 pm_runtime_get_sync(cs35l56->base.dev);
1097 pm_runtime_disable(cs35l56->base.dev);
1098
1099 cs_dsp_remove(&cs35l56->cs_dsp);
1100
1101 kfree(cs35l56->system_name);
1102 pm_runtime_put_noidle(cs35l56->base.dev);
1103
1104 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);
1105 }
1106 EXPORT_SYMBOL_NS_GPL(cs35l56_hda_remove, "SND_HDA_SCODEC_CS35L56");
1107
1108 const struct dev_pm_ops cs35l56_hda_pm_ops = {
1109 RUNTIME_PM_OPS(cs35l56_hda_runtime_suspend, cs35l56_hda_runtime_resume, NULL)
1110 SYSTEM_SLEEP_PM_OPS(cs35l56_hda_system_suspend, cs35l56_hda_system_resume)
1111 LATE_SYSTEM_SLEEP_PM_OPS(cs35l56_hda_system_suspend_late,
1112 cs35l56_hda_system_resume_early)
1113 NOIRQ_SYSTEM_SLEEP_PM_OPS(cs35l56_hda_system_suspend_no_irq,
1114 cs35l56_hda_system_resume_no_irq)
1115 };
1116 EXPORT_SYMBOL_NS_GPL(cs35l56_hda_pm_ops, "SND_HDA_SCODEC_CS35L56");
1117
1118 MODULE_DESCRIPTION("CS35L56 HDA Driver");
1119 MODULE_IMPORT_NS("FW_CS_DSP");
1120 MODULE_IMPORT_NS("SND_HDA_CIRRUS_SCODEC");
1121 MODULE_IMPORT_NS("SND_HDA_CS_DSP_CONTROLS");
1122 MODULE_IMPORT_NS("SND_SOC_CS35L56_SHARED");
1123 MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
1124 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
1125 MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
1126 MODULE_LICENSE("GPL");
1127