Home
last modified time | relevance | path

Searched hist:d0ef10c9a42ee2008a5106d04ed34a53b9c6e6c6 (Results 1 – 1 of 1) sorted by relevance

/linux/drivers/scsi/hisi_sas/ !
H A Dhisi_sas.hd0ef10c9a42ee2008a5106d04ed34a53b9c6e6c6 Mon Jun 26 10:27:28 UTC 2017 John Garry <john.garry@huawei.com> scsi: hisi_sas: redefine hisi_sas_phy.phy_type as u32

Element phy_type is a bitmask and it only ever has 2 bits possibly set,
and it is overkill to define as a u64, so redefine as a u32.

This change resolves static code check complaint that "phy->phy_type &=
~PORT_TYPE_SAS;" would unintentionally clear the high 32 bits as well.

Structure hisi_sas_phy is also reordered to ensure packing efficiency.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>