rpcbind: Code cleanup

Fix a number of style issues and attempt to reduce the diff to NetBSD.

Reviewed by: glebius, kib
Differential Revision: https://reviews.freebsd.org/D51773

rpcbind: do not exit abruptly if krpc.ko is not available

Reviewed by: glebius, rmacklem
Sponsored by: The FreeBSD Foundation

nfsd, rpcbind: add -P option to support pidfile path

The -P option, when specified opens a pidfile to a given path.
Both daemons also install a default pid file to the corresponding
locations, that

nfsd, rpcbind: add -P option to support pidfile path

The -P option, when specified opens a pidfile to a given path.
Both daemons also install a default pid file to the corresponding
locations, that is, /var/run/nfsd.pid and /var/run/rpcbind.pid.

Sponsored by: Juniper Networks, Inc.
MFC after: 7 days
Reviewed by: rmacklem
Differential Revision: https://reviews.freebsd.org/D50624

show more ...

rpcbind: Ensure krpc is present.

MFC after: 1 week
Reviewed by: rmacklem, glebius
Differential Revision: https://reviews.freebsd.org/D50627

rpcbind: run netlink(4) service

To register RPC bindings coming from the kernel. At the moment, we expect
such bindings only from the kernel NLM service.

Reviewed by: rmacklem
Differential Revisi

rpcbind: run netlink(4) service

To register RPC bindings coming from the kernel. At the moment, we expect
such bindings only from the kernel NLM service.

Reviewed by: rmacklem
Differential Revision: https://reviews.freebsd.org/D48556

show more ...

rpcbind: remove extraneous check for nconf not being unix(4)

We are already inside an if block with exactly same predicate.

rpcbind: Add option to disable local host binding

In our products, we need those options to support our features.

Add daemon mode option for mountd, nfsd.
Add skip local host binding option for rpc

rpcbind: Add option to disable local host binding

In our products, we need those options to support our features.

Add daemon mode option for mountd, nfsd.
Add skip local host binding option for rpcd.
Add skip local host binding option for mountd.

Reviewed by: rmacklem
Differential Revision: https://reviews.freebsd.org/D45118

show more ...

usr.sbin: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

usr.sbin: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by: Netflix

show more ...

usr.sbin: Remove ancient SCCS tags.

Remove ancient SCCS tags from the tree, automated scripting, with two
minor fixup to keep things compiling. All the common forms in the tree
were removed with a p

usr.sbin: Remove ancient SCCS tags.

Remove ancient SCCS tags from the tree, automated scripting, with two
minor fixup to keep things compiling. All the common forms in the tree
were removed with a perl script.

Sponsored by: Netflix

show more ...

rpcbind: Add flag for foreground mode

Added the -N flag to enable foreground mode.

It is useful to be able to run rpcbind in foreground mode when
starting from launcher applications. The existing d

rpcbind: Add flag for foreground mode

Added the -N flag to enable foreground mode.

It is useful to be able to run rpcbind in foreground mode when
starting from launcher applications. The existing debug flag
is not sufficient as it enables additional debug messages.

Update man page to document the added flag.

Reviewed by: imp
Obtained from: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D41674

show more ...

Remove $FreeBSD$: one-line .c comment pattern

Remove /^/[*/]\s*\$FreeBSD\$.*\n/

rpcbind: Code cleanup

Fix a number of style issues and attempt to reduce the diff to NetBSD.

Reviewed by: glebius, kib
Differential Revision: https://reviews.freebsd.org/D51773

rpcbind: do not exit abruptly if krpc.ko is not available

Reviewed by: glebius, rmacklem
Sponsored by: The FreeBSD Foundation

nfsd, rpcbind: add -P option to support pidfile path

The -P option, when specified opens a pidfile to a given path.
Both daemons also install a default pid file to the corresponding
locations, that

nfsd, rpcbind: add -P option to support pidfile path

The -P option, when specified opens a pidfile to a given path.
Both daemons also install a default pid file to the corresponding
locations, that is, /var/run/nfsd.pid and /var/run/rpcbind.pid.

Sponsored by: Juniper Networks, Inc.
MFC after: 7 days
Reviewed by: rmacklem
Differential Revision: https://reviews.freebsd.org/D50624

show more ...

rpcbind: Ensure krpc is present.

MFC after: 1 week
Reviewed by: rmacklem, glebius
Differential Revision: https://reviews.freebsd.org/D50627

rpcbind: run netlink(4) service

To register RPC bindings coming from the kernel. At the moment, we expect
such bindings only from the kernel NLM service.

Reviewed by: rmacklem
Differential Revisi

rpcbind: run netlink(4) service

To register RPC bindings coming from the kernel. At the moment, we expect
such bindings only from the kernel NLM service.

Reviewed by: rmacklem
Differential Revision: https://reviews.freebsd.org/D48556

show more ...

rpcbind: remove extraneous check for nconf not being unix(4)

We are already inside an if block with exactly same predicate.

rpcbind: Add option to disable local host binding

In our products, we need those options to support our features.

Add daemon mode option for mountd, nfsd.
Add skip local host binding option for rpc

rpcbind: Add option to disable local host binding

In our products, we need those options to support our features.

Add daemon mode option for mountd, nfsd.
Add skip local host binding option for rpcd.
Add skip local host binding option for mountd.

Reviewed by: rmacklem
Differential Revision: https://reviews.freebsd.org/D45118

show more ...

usr.sbin: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

usr.sbin: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by: Netflix

show more ...

usr.sbin: Remove ancient SCCS tags.

Remove ancient SCCS tags from the tree, automated scripting, with two
minor fixup to keep things compiling. All the common forms in the tree
were removed with a p

usr.sbin: Remove ancient SCCS tags.

Remove ancient SCCS tags from the tree, automated scripting, with two
minor fixup to keep things compiling. All the common forms in the tree
were removed with a perl script.

Sponsored by: Netflix

show more ...

rpcbind: Add flag for foreground mode

Added the -N flag to enable foreground mode.

It is useful to be able to run rpcbind in foreground mode when
starting from launcher applications. The existing d

rpcbind: Add flag for foreground mode

Added the -N flag to enable foreground mode.

It is useful to be able to run rpcbind in foreground mode when
starting from launcher applications. The existing debug flag
is not sufficient as it enables additional debug messages.

Update man page to document the added flag.

Reviewed by: imp
Obtained from: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D41674

show more ...

Remove $FreeBSD$: one-line .c comment pattern

Remove /^/[*/]\s*\$FreeBSD\$.*\n/

Plug a possible memory leak.

MFC after: 2 weeks

Merge ^/head r327341 through r327623.

rpcbind: Fix race in signal termination

If a signal was delivered while the main thread was not in poll(2) and after
check was performed, we could reenter poll and never detect termination. Fix
this

rpcbind: Fix race in signal termination

If a signal was delivered while the main thread was not in poll(2) and after
check was performed, we could reenter poll and never detect termination. Fix
this with the pipefd trick. (This race was introduced very recently, in
r327482.)

PR: 224503
Reported by: kib
Reviewed by: kib, markj
Sponsored by: Dell EMC Isilon

show more ...