makefs: tests: Fix timestamp-related tests

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword or passing an
unimplemented "nlin

makefs: tests: Fix timestamp-related tests

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword or passing an
unimplemented "nlink" keyword.

Unskip the "failing" tests, and comment out the specific failing checks,
these will be addressed (or at least discussed) in a different revision.

For MS-DOS tests, use an even value timestamp, as precision is 2s.

For ZFS tests, use import_image instead of mount_image consistently.

Reviewed by: bnovkov, markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54429

show more ...

makefs: tests: Fix -D flag test

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specif

makefs: tests: Fix -D flag test

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specify it as the last argument on the command line, not as the
argument to -F.

This change does exactly that. Also bug #192839 has already been fixed.

Reviewed by: ngie
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54428

show more ...

makefs: tests: Cleanup and remove default flags

Cleanup and remove default atf_check flags for clarity. The following
two lines are equivalent:

atf_check $cmd
atf_check -s exit:0 -e empty

makefs: tests: Cleanup and remove default flags

Cleanup and remove default atf_check flags for clarity. The following
two lines are equivalent:

atf_check $cmd
atf_check -s exit:0 -e empty -o empty $cmd

Update the links to the reference documents.

Remove the D_flag_cleanup function, as common_cleanup() for these
particular set of tests does two things:

1. Unmount the md(4) device.
2. Destroy the md(4) device.

Essentially, one should only call common_cleanup() if the test body
invokes mount_image(). This is not the case for D_flag_body().

No functional changes intended.

Reviewed by: ngie
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54427

show more ...

makefs: Add tests for the -T flag

Add tests for the -T flag to each makefs backend. This includes tests
for both mtree and directory scan options.

PR: 285630
Sponsored by: Klara, Inc.

makefs: Add tests for the -T flag

Add tests for the -T flag to each makefs backend. This includes tests
for both mtree and directory scan options.

PR: 285630
Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation
Reviewed by: markj, emaste, kevans, jlduran
Differential Revision: https://reviews.freebsd.org/D49492

show more ...

makefs: Fix cd9660 duplicate directory names

Previously we could create cd9660 images with duplicate short (level 2)
names.

cd9660_level2_convert_filename used a 30-character limit (for files and
d

makefs: Fix cd9660 duplicate directory names

Previously we could create cd9660 images with duplicate short (level 2)
names.

cd9660_level2_convert_filename used a 30-character limit (for files and
directories), not including the '.' separator. cd9660_rename_filename
used a 31-character limit, including the '.'. Directory names 31
characters or longer (without '.') were shortened to 30 characters, and
if a collision occurred cd9660_rename_filename uniquified them starting
with the 31st character. Unfortunately the directory record's name_len
was already set, so the unique part of the name was stripped off.

Directories are up to 31 d-characters (i.e., A-Z 0-9 and _); there is no
provision for a '.' in a directory name. Increase the name length limit
to 31 for directories, and exclude '.'s.

This name mapping and deduplication code is still fragile and convoluted
and would beenfit from a more holistic effort.

PR: 283238, 283112
Reviewed by: imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D48251

show more ...

makefs: clean up some leftovers after $FreeBSD$ tag removal

Fixes: 2a63c3be1582

Remove $FreeBSD$: one-line sh pattern

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

makefs: Remove execute permission from in-tree test scripts

Let the build system set it as needed. No functional change intended.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

MFHead @345353

makefs: Fix "time" mtree attribute handling

When processing mtree(5) MANIFEST files, makefs(8) previously threw an
error if it encountered an entry whose "time" attribute contained a
non-zero subsec

makefs: Fix "time" mtree attribute handling

When processing mtree(5) MANIFEST files, makefs(8) previously threw an
error if it encountered an entry whose "time" attribute contained a
non-zero subsecond component (e.g. time=1551620152.987220000).

Update the handling logic to properly assign the subsecond component if
built with nanosecond support, or silently discard it otherwise.

Also, re-enable the time attribute for the kyua tests.

PR: 194703
Submitted by: Mitchell Horne <mhorne063@gmail.com>
Differential Revision: https://reviews.freebsd.org/D19627

show more ...

makefs: tests: Fix timestamp-related tests

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword or passing an
unimplemented "nlin

makefs: tests: Fix timestamp-related tests

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword or passing an
unimplemented "nlink" keyword.

Unskip the "failing" tests, and comment out the specific failing checks,
these will be addressed (or at least discussed) in a different revision.

For MS-DOS tests, use an even value timestamp, as precision is 2s.

For ZFS tests, use import_image instead of mount_image consistently.

Reviewed by: bnovkov, markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54429

show more ...

makefs: tests: Fix -D flag test

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specif

makefs: tests: Fix -D flag test

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specify it as the last argument on the command line, not as the
argument to -F.

This change does exactly that. Also bug #192839 has already been fixed.

Reviewed by: ngie
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54428

show more ...

makefs: tests: Cleanup and remove default flags

Cleanup and remove default atf_check flags for clarity. The following
two lines are equivalent:

atf_check $cmd
atf_check -s exit:0 -e empty

makefs: tests: Cleanup and remove default flags

Cleanup and remove default atf_check flags for clarity. The following
two lines are equivalent:

atf_check $cmd
atf_check -s exit:0 -e empty -o empty $cmd

Update the links to the reference documents.

Remove the D_flag_cleanup function, as common_cleanup() for these
particular set of tests does two things:

1. Unmount the md(4) device.
2. Destroy the md(4) device.

Essentially, one should only call common_cleanup() if the test body
invokes mount_image(). This is not the case for D_flag_body().

No functional changes intended.

Reviewed by: ngie
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54427

show more ...

makefs: Add tests for the -T flag

Add tests for the -T flag to each makefs backend. This includes tests
for both mtree and directory scan options.

PR: 285630
Sponsored by: Klara, Inc.

makefs: Add tests for the -T flag

Add tests for the -T flag to each makefs backend. This includes tests
for both mtree and directory scan options.

PR: 285630
Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation
Reviewed by: markj, emaste, kevans, jlduran
Differential Revision: https://reviews.freebsd.org/D49492

show more ...

makefs: Fix cd9660 duplicate directory names

Previously we could create cd9660 images with duplicate short (level 2)
names.

cd9660_level2_convert_filename used a 30-character limit (for files and
d

makefs: Fix cd9660 duplicate directory names

Previously we could create cd9660 images with duplicate short (level 2)
names.

cd9660_level2_convert_filename used a 30-character limit (for files and
directories), not including the '.' separator. cd9660_rename_filename
used a 31-character limit, including the '.'. Directory names 31
characters or longer (without '.') were shortened to 30 characters, and
if a collision occurred cd9660_rename_filename uniquified them starting
with the 31st character. Unfortunately the directory record's name_len
was already set, so the unique part of the name was stripped off.

Directories are up to 31 d-characters (i.e., A-Z 0-9 and _); there is no
provision for a '.' in a directory name. Increase the name length limit
to 31 for directories, and exclude '.'s.

This name mapping and deduplication code is still fragile and convoluted
and would beenfit from a more holistic effort.

PR: 283238, 283112
Reviewed by: imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D48251

show more ...

makefs: clean up some leftovers after $FreeBSD$ tag removal

Fixes: 2a63c3be1582

Remove $FreeBSD$: one-line sh pattern

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

makefs: Remove execute permission from in-tree test scripts

Let the build system set it as needed. No functional change intended.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

MFHead @345353

makefs: Fix "time" mtree attribute handling

When processing mtree(5) MANIFEST files, makefs(8) previously threw an
error if it encountered an entry whose "time" attribute contained a
non-zero subsec

makefs: Fix "time" mtree attribute handling

When processing mtree(5) MANIFEST files, makefs(8) previously threw an
error if it encountered an entry whose "time" attribute contained a
non-zero subsecond component (e.g. time=1551620152.987220000).

Update the handling logic to properly assign the subsecond component if
built with nanosecond support, or silently discard it otherwise.

Also, re-enable the time attribute for the kyua tests.

PR: 194703
Submitted by: Mitchell Horne <mhorne063@gmail.com>
Differential Revision: https://reviews.freebsd.org/D19627

show more ...

MFH r289384-r293170

Sponsored by: The FreeBSD Foundation

Catch up with head (r291075).

Merge from head r290483

Clean up mtree keyword support a slight bit and add a few more default keywords

- Parameterize the mtree keywords as $DEFAULT_MTREE_KEYWORDS
- Test with the extra mtree keywords, `mode,gid,uid`.
- A

Clean up mtree keyword support a slight bit and add a few more default keywords

- Parameterize the mtree keywords as $DEFAULT_MTREE_KEYWORDS
- Test with the extra mtree keywords, `mode,gid,uid`.
- Add a note about mtrees with time support not working with makefs right now

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

show more ...

Merge from head