| #
42ab9909
|
| 21-Feb-2026 |
David Bright <dab@FreeBSD.org> |
procstat: CID 1593951: Resource leak
Summary: A trivial resource leak fix; free the allocated memory before return.
Test Plan: Code inspection, run command.
I built a simple program that waits for
procstat: CID 1593951: Resource leak
Summary: A trivial resource leak fix; free the allocated memory before return.
Test Plan: Code inspection, run command.
I built a simple program that waits for a signal on a kqueue, then ran
that. The standard procstat displays:
```
fbsd-dev% Waiting for SIGTERM...
procstat -a kqueue
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
84352 3 SIGNAL 15 C - 0 0x0 -
```
The revised procstat displays:
```
fbsd-dev% sudo LD_LIBRARY_PATH=/usr/obj/usr/home/dab/git/freebsd/src/arm64.aarch64/lib/libutil /usr/obj/usr/home/dab/git/freebsd/src/arm64.aarch64/usr.bin/procstat/procstat -a kqueue
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
84352 3 SIGNAL 15 C - 0 0x0 -
fbsd-dev%
```
As expected, the two displays are identical. This doesn't prove that
the leak is gone, but it does prove that the revised command still
operates correctly. I think it can clearly be seen from inspection of
the change that the leak has been remedied.
Reviewed-bys: vangyzen
Differential Revision: https://reviews.freebsd.org/D55422
show more ...
|
| #
28f4cf92
|
| 26-Feb-2025 |
Konstantin Belousov <kib@FreeBSD.org> |
procstat(1): dump kqueues
Example output from the 'procstat -a kqueues':
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
2323 13 READ
procstat(1): dump kqueues
Example output from the 'procstat -a kqueues':
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
2323 13 READ 5 - - 0 0x19c290616000 -
2323 13 READ 8 - - 0 0x19c29064f070 -
2323 13 READ 10 - - 0 0x19c29064f0e0 -
2323 13 SIGNAL 1 C - 0 0x0 -
2323 13 SIGNAL 2 C - 0 0x0 -
2323 13 SIGNAL 3 C - 0 0x0 -
2323 13 SIGNAL 13 C - 0 0x0 -
2323 13 SIGNAL 14 C - 0 0x0 -
2323 13 SIGNAL 15 C - 0 0x0 -
2323 13 SIGNAL 20 C - 0 0x0 -
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D49163
show more ...
|
| #
28f4cf92
|
| 26-Feb-2025 |
Konstantin Belousov <kib@FreeBSD.org> |
procstat(1): dump kqueues
Example output from the 'procstat -a kqueues':
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
2323 13 READ
procstat(1): dump kqueues
Example output from the 'procstat -a kqueues':
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
2323 13 READ 5 - - 0 0x19c290616000 -
2323 13 READ 8 - - 0 0x19c29064f070 -
2323 13 READ 10 - - 0 0x19c29064f0e0 -
2323 13 SIGNAL 1 C - 0 0x0 -
2323 13 SIGNAL 2 C - 0 0x0 -
2323 13 SIGNAL 3 C - 0 0x0 -
2323 13 SIGNAL 13 C - 0 0x0 -
2323 13 SIGNAL 14 C - 0 0x0 -
2323 13 SIGNAL 15 C - 0 0x0 -
2323 13 SIGNAL 20 C - 0 0x0 -
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D49163
show more ...
|
| #
28f4cf92
|
| 26-Feb-2025 |
Konstantin Belousov <kib@FreeBSD.org> |
procstat(1): dump kqueues
Example output from the 'procstat -a kqueues':
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
2323 13 READ
procstat(1): dump kqueues
Example output from the 'procstat -a kqueues':
PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS
2323 13 READ 5 - - 0 0x19c290616000 -
2323 13 READ 8 - - 0 0x19c29064f070 -
2323 13 READ 10 - - 0 0x19c29064f0e0 -
2323 13 SIGNAL 1 C - 0 0x0 -
2323 13 SIGNAL 2 C - 0 0x0 -
2323 13 SIGNAL 3 C - 0 0x0 -
2323 13 SIGNAL 13 C - 0 0x0 -
2323 13 SIGNAL 14 C - 0 0x0 -
2323 13 SIGNAL 15 C - 0 0x0 -
2323 13 SIGNAL 20 C - 0 0x0 -
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D49163
show more ...
|