subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr

We can now support pmap_mapdev_attr on arm. Switch to use this to
implement pmap_mapdev to reduce duplicate code.

Reviewed by: mhorne, mmel

subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr

We can now support pmap_mapdev_attr on arm. Switch to use this to
implement pmap_mapdev to reduce duplicate code.

Reviewed by: mhorne, mmel
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50309

show more ...

subr_devmap: Add the function name to KASSERT

These messages are almost identical, other than one has " 2" appended.
Change this to include the function name at the start to make it more
obvious whi

subr_devmap: Add the function name to KASSERT

These messages are almost identical, other than one has " 2" appended.
Change this to include the function name at the start to make it more
obvious which function the KASSERT is from.

Reviewed by: mhorne, emaste
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50308

show more ...

subr_devmap: Reduce the use of the static devmap

We only create the static devmap on arm. Stop building this code on
other architectures.

Reviewed by: mhorne, imp
Sponsored by: Arm Ltd
Differential

subr_devmap: Reduce the use of the static devmap

We only create the static devmap on arm. Stop building this code on
other architectures.

Reviewed by: mhorne, imp
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50016

show more ...

subr_devmap: Make devmap_ptov static

The devmap_ptov and devmap_vtop functions are only used in this file.

Reviewed by: mhorne
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.o

subr_devmap: Make devmap_ptov static

The devmap_ptov and devmap_vtop functions are only used in this file.

Reviewed by: mhorne
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50015

show more ...

subr_devmap: Use the arm L1_S macro

These check if we can should use a superpage to create the static map.
As it is arm specific we can use an arm-specific macro here.

Reviewed by: mhorne
Sponsored

subr_devmap: Use the arm L1_S macro

These check if we can should use a superpage to create the static map.
As it is arm specific we can use an arm-specific macro here.

Reviewed by: mhorne
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50013

show more ...

devmap: eliminate unused arguments

The optional 'table' pointer is a legacy part of the interface, which
has been replaced by devmap_register_table()/devmap_add_entry(). The few
in-tree callers have

devmap: eliminate unused arguments

The optional 'table' pointer is a legacy part of the interface, which
has been replaced by devmap_register_table()/devmap_add_entry(). The few
in-tree callers have already adapted to this, so it can be removed.

The 'l1pt' argument is already entirely unused within the function.

Reviewed by: andrew, markj
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D45319

show more ...

arm64: enable superpage mappings by pmap_mapdev{,_attr}()

In order for pmap_kenter{,_device}() to create superpage mappings,
either 64 KB or 2 MB, pmap_mapdev{,_attr}() must request appropriately
al

arm64: enable superpage mappings by pmap_mapdev{,_attr}()

In order for pmap_kenter{,_device}() to create superpage mappings,
either 64 KB or 2 MB, pmap_mapdev{,_attr}() must request appropriately
aligned virtual addresses.

Reviewed by: markj
Tested by: gallatin
Differential Revision: https://reviews.freebsd.org/D42737

show more ...

sys: Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

Remove pre-armv6 support from devmap

Remove an old code path that was used used by Armv4/5 so is unused now.

Sponsored by: The FreeBSD Foundation

pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t.

This matches the return type of pmap_mapdev/bios.

Reviewed by: kib, markj
Sponsored by: DARPA
Differential Revision: https://reviews.f

pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t.

This matches the return type of pmap_mapdev/bios.

Reviewed by: kib, markj
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D36548

show more ...

Adjust function definition in subr_devmap.c to avoid clang 15 warning

With clang 15, the following -Werror warning is produced:

sys/kern/subr_devmap.c:87:19: error: a function declaration witho

Adjust function definition in subr_devmap.c to avoid clang 15 warning

With clang 15, the following -Werror warning is produced:

sys/kern/subr_devmap.c:87:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
devmap_print_table()
^
void

This is because devmap_print_table() and devmap_lastaddr() are declared
with a (void) argument list, but defined with an empty argument list.
Make the definition match the declaration.

Sponsored by: The FreeBSD Foundation

show more ...

pmap_mapdev: Consistently use vm_paddr_t for the first argument.

The devmap variants used vm_offset_t for some reason, and a few places
explicitly cast bus addresses to vm_offset_t. (Probably those

pmap_mapdev: Consistently use vm_paddr_t for the first argument.

The devmap variants used vm_offset_t for some reason, and a few places
explicitly cast bus addresses to vm_offset_t. (Probably those casts
along with similar casts for vm_size_t should just be removed and
instead permit the compiler to DTRT.)

Reviewed by: markj
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D35961

show more ...

ddb: annotate some commands with DB_CMD_MEMSAFE

This is not completely exhaustive, but covers a large majority of
commands in the tree.

Reviewed by: markj
Sponsored by: Juniper Networks, Inc.
Spons

ddb: annotate some commands with DB_CMD_MEMSAFE

This is not completely exhaustive, but covers a large majority of
commands in the tree.

Reviewed by: markj
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D35583

show more ...

riscv: Implement pmap_mapdev_attr

This is needed for LinuxKPI's _ioremap_attr. This reuses the generic
implementation introduced for aarch64, and itself requires implementing
pmap_kenter, which is t

riscv: Implement pmap_mapdev_attr

This is needed for LinuxKPI's _ioremap_attr. This reuses the generic
implementation introduced for aarch64, and itself requires implementing
pmap_kenter, which is trivial to do given riscv currently treats all
mapping attributes the same due to the Svpbmt extension not yet being
ratified and in hardware.

Reviewed by: markj, mhorne
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D32445

show more ...

ddb: fix show devmap output on 32-bit arm

The output has been broken since 1b6dd6d772ca. Casting to uintmax_t
before the call to printf is necessary to ensure that 32-bit addresses
are interpreted c

ddb: fix show devmap output on 32-bit arm

The output has been broken since 1b6dd6d772ca. Casting to uintmax_t
before the call to printf is necessary to ensure that 32-bit addresses
are interpreted correctly.

PR: 243236
MFC after: 3 days

show more ...

arm64: fix early devmap assertion

The purpose of this KASSERT is to ensure that we do not run out of space
in the early devmap. However, the devmap grew beyond its initial size of
2MB in r336519, an

arm64: fix early devmap assertion

The purpose of this KASSERT is to ensure that we do not run out of space
in the early devmap. However, the devmap grew beyond its initial size of
2MB in r336519, and this assertion did not grow with it.

A devmap mapping of a 1080p framebuffer requires 1920x1080 bytes, or
1.977 MB, so it is just barely able to fit without triggering the
assertion, provided no other devices are mapped before it. With the
addition of `options GDB` in GENERIC by bbfa199cbc16, the uart is now
mapped for the purposes of a debug port, before mapping the framebuffer.
The presence of both these conditions pushes the selected virtual
address just below the threshold, triggering the assertion.

To fix this, use the correct size of the devmap, defined by
PMAP_MAPDEV_EARLY_SIZE. Since this code is shared with RISC-V, define
it for that platform as well (although it is a different size).

PR: 25241
Reported by: gbe
MFC after: 3 days
Sponsored by: The FreeBSD Foundation

show more ...

kern: clean up empty lines in .c and .h files

Print upper 32 bits in devmap table entries

If the devmap entry uses the upper 32 bits they wouldn't be printed in
devmap_dump_table(). This fixes that.

Submitted by: Nicholas O'Brien <nickisobri

Print upper 32 bits in devmap table entries

If the devmap entry uses the upper 32 bits they wouldn't be printed in
devmap_dump_table(). This fixes that.

Submitted by: Nicholas O'Brien <nickisobrien_gmail.com>
Sponsored by: Axiado

show more ...

Generalize ARM specific comments in devmap

The comments in devmap are very ARM specific, this generalizes them for other
architectures.

Submitted by: Nicholas O'Brien <nickisobrien_gmail.com>
Revie

Generalize ARM specific comments in devmap

The comments in devmap are very ARM specific, this generalizes them for other
architectures.

Submitted by: Nicholas O'Brien <nickisobrien_gmail.com>
Reviewed by: manu, philip
Sponsored by: Axiado
Differential Revision: https://reviews.freebsd.org/D22035

show more ...

subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr

We can now support pmap_mapdev_attr on arm. Switch to use this to
implement pmap_mapdev to reduce duplicate code.

Reviewed by: mhorne, mmel

subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr

We can now support pmap_mapdev_attr on arm. Switch to use this to
implement pmap_mapdev to reduce duplicate code.

Reviewed by: mhorne, mmel
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50309

show more ...

subr_devmap: Add the function name to KASSERT

These messages are almost identical, other than one has " 2" appended.
Change this to include the function name at the start to make it more
obvious whi

subr_devmap: Add the function name to KASSERT

These messages are almost identical, other than one has " 2" appended.
Change this to include the function name at the start to make it more
obvious which function the KASSERT is from.

Reviewed by: mhorne, emaste
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50308

show more ...

subr_devmap: Reduce the use of the static devmap

We only create the static devmap on arm. Stop building this code on
other architectures.

Reviewed by: mhorne, imp
Sponsored by: Arm Ltd
Differential

subr_devmap: Reduce the use of the static devmap

We only create the static devmap on arm. Stop building this code on
other architectures.

Reviewed by: mhorne, imp
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50016

show more ...

subr_devmap: Make devmap_ptov static

The devmap_ptov and devmap_vtop functions are only used in this file.

Reviewed by: mhorne
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.o

subr_devmap: Make devmap_ptov static

The devmap_ptov and devmap_vtop functions are only used in this file.

Reviewed by: mhorne
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50015

show more ...

subr_devmap: Use the arm L1_S macro

These check if we can should use a superpage to create the static map.
As it is arm specific we can use an arm-specific macro here.

Reviewed by: mhorne
Sponsored

subr_devmap: Use the arm L1_S macro

These check if we can should use a superpage to create the static map.
As it is arm specific we can use an arm-specific macro here.

Reviewed by: mhorne
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50013

show more ...

devmap: eliminate unused arguments

The optional 'table' pointer is a legacy part of the interface, which
has been replaced by devmap_register_table()/devmap_add_entry(). The few
in-tree callers have

devmap: eliminate unused arguments

The optional 'table' pointer is a legacy part of the interface, which
has been replaced by devmap_register_table()/devmap_add_entry(). The few
in-tree callers have already adapted to this, so it can be removed.

The 'l1pt' argument is already entirely unused within the function.

Reviewed by: andrew, markj
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D45319

show more ...