wsp: Fix whitespaces

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

wsp: Rename max_finger_area sysctl to max_finger_diameter

The value of this sysctl is not an area, but a maximum diameter.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

wsp: Handle horizontal scrolling and create tunable for swipe/scroll.

Previously, a two-finger horizontal scroll would result in a forwards/backwards
keyboard event being performed. This patch chang

wsp: Handle horizontal scrolling and create tunable for swipe/scroll.

Previously, a two-finger horizontal scroll would result in a forwards/backwards
keyboard event being performed. This patch changes that functionality to be
specified via two new sysctls: horizontal_swipe_finger_count and
scroll_finger_count. The former specifies how many fingers are used to perform
the aforementioned forwards/backwards keyboard event, while the latter specifies
how many fingers are used to perform horizontal scrolling. 0 disables each of
them.

The threshold for scrolling has been coupled into a single tunable:
scr_threshold. This tunable is used for both scrolling and the horizontal swipe.

t_factor and t_invert tunables have been created in the same manner as their
z-axis counterparts.

Horizontal scrolling is disabled by default, as it requires the sysctl
hw.usb.wsp.t_factor to 3 (wsp mode). Horizontal swiping is enabled by default
with a three-finger tap.

Also rewrite much of, and improve, documentation.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

show more ...

wsp: Fix typo in function name.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

wsp: Add hw.usb.wsp.max_scroll_finger_distance for two-finger scrolling

The hw.usb.wsp.max_scroll_finger_distance sysctl may be used to specify
the maximum distance between two fingers which are reg

wsp: Add hw.usb.wsp.max_scroll_finger_distance for two-finger scrolling

The hw.usb.wsp.max_scroll_finger_distance sysctl may be used to specify
the maximum distance between two fingers which are registered as a z-axis
(vertical scroll with mousepad) movement.

Previously, this was shared with the tunable
hw.usb.wsp.max_double_tap_distance which is used to specify the maximum
distance between two fingers which register as a right-click.

This patch also cleans up and add new information to the manpage for
wsp(4).

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

show more ...

wsp: Raise the default scr_hor_threshold sysctl.

The previous value caused nearly every horizontal movement to be
classed as a left/right-keyboard button-click.

Signed-off-by: Joshua Rogers <Joshua

wsp: Raise the default scr_hor_threshold sysctl.

The previous value caused nearly every horizontal movement to be
classed as a left/right-keyboard button-click.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

show more ...

usb: Kill left-over cdefs.h includes

These includes were for __FBSD_RCSID() macro. They weren't formatted
like the rest of the tree so weren't trimmed automatically when that
script was run. Trim th

usb: Kill left-over cdefs.h includes

These includes were for __FBSD_RCSID() macro. They weren't formatted
like the rest of the tree so weren't trimmed automatically when that
script was run. Trim them now.

MFC After: 1 week
Sponsored by: Netflix

show more ...

wsp: Use already-calculated distance of fingers for comparison.

Also correctly use tun.max_double_tap_distance for maximum distance
of fingers for vertical scrolling.

Signed-off-by: Joshua Rogers <

wsp: Use already-calculated distance of fingers for comparison.

Also correctly use tun.max_double_tap_distance for maximum distance
of fingers for vertical scrolling.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>
Reviewed by: imp, wulf
Pull Request: https://github.com/freebsd/freebsd-src/pull/1365

show more ...

wsp: Improve multi-finger touchpad usage and allow more configurations

This patch allows scrolling with multiple fingers simultaneously, in
line with how wsp trackpads function on MacOS.

Two new tu

wsp: Improve multi-finger touchpad usage and allow more configurations

This patch allows scrolling with multiple fingers simultaneously, in
line with how wsp trackpads function on MacOS.

Two new tunables are added: hw.usb.wsp.max_finger_area and
hw.usb.wsp.max_double_tap_distance.

max_finger_area defines the maximum size which the driver registered an
object on trackpad as a finger.
Previously, this value was hardcoded as 1200, which was too low to
register thumb-clicks.

max_double_tap_distance defines the maximum distance between two
fingers which will register as a double-click.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>
Reviewed by: imp, wulf
Pull Request: https://github.com/freebsd/freebsd-src/pull/1365

show more ...

wsp: Allow the trackpad to be used after a partially unreleased click.

This provides functionality for a click which is partially unreleased
and then allows the user to continue moving the mousepad

wsp: Allow the trackpad to be used after a partially unreleased click.

This provides functionality for a click which is partially unreleased
and then allows the user to continue moving the mousepad as if were not
invoked as a full click

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>
Reviewed by: imp, wulf
Pull Request: https://github.com/freebsd/freebsd-src/pull/1365

show more ...

sys: Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.

Discussed with: pfg
MFC After: 3 days
Sponsored by: Netflix

show more ...

usb: Remove unused devclass arguments to DRIVER_MODULE.

wsp_intr_callback: eliminate write only variable h

Sponsored by: Netflix

wsp(4): Add evdev support.

Reviewed by: hselasky
Tested by: Greg V, Constantin Furst<constantin_AT_fuersten_DOT_info>
MFC after: 2 weeks
PR: 252236
Differential revision: https://reviews.freebsd.or

wsp(4): Add evdev support.

Reviewed by: hselasky
Tested by: Greg V, Constantin Furst<constantin_AT_fuersten_DOT_info>
MFC after: 2 weeks
PR: 252236
Differential revision: https://reviews.freebsd.org/D31653

show more ...

wsp(4): Compact parameter structure.

MFC after: 2 weeks

atp(4), wsp(4): Return correct priority from probe() method;

MFC after: 2 weeks

wsp: Add sysctl tunable for Z-Axis inversion

This adds a new sysctl to Wellspring Touchpad driver for controlling
Z-Axis (2-finger vertical scroll) direction "hw.usb.wsp.z_invert".

Submitted by: Ja

wsp: Add sysctl tunable for Z-Axis inversion

This adds a new sysctl to Wellspring Touchpad driver for controlling
Z-Axis (2-finger vertical scroll) direction "hw.usb.wsp.z_invert".

Submitted by: James Wright <james.wright_AT_digital-chaos_DOT_com>
Reviewed by: wulf
PR: 253321
Differential revision: https://reviews.freebsd.org/D28521

show more ...

hid: Chase for HID function name changes in existing USB HID drivers

Also hide shim code added in a previous commit under COMPAT_USBHID12.

Note: it is enough to add -DCOMPAT_USBHID12 to CFLAGS to c

hid: Chase for HID function name changes in existing USB HID drivers

Also hide shim code added in a previous commit under COMPAT_USBHID12.

Note: it is enough to add -DCOMPAT_USBHID12 to CFLAGS to compile old
code with new HID subsystem, but it is not enough to link it at runtime.
HID dependency has to be added explicitly with MODULE_DEPEND macro.

Reviewed by: manu, hselasky (as part of D27887)

show more ...

Factor-out hardware-independent part of USB HID support to new module

It will be used by the upcoming HID-over-i2C implementation. Should be
no-op, except hid.ko module dependency is to be added to

Factor-out hardware-independent part of USB HID support to new module

It will be used by the upcoming HID-over-i2C implementation. Should be
no-op, except hid.ko module dependency is to be added to affected drivers.

Reviewed by: hselasky, manu
Differential revision: https://reviews.freebsd.org/D27867

show more ...

usb: clean up empty lines in .c and .h files

Merge ^/head r357966 through r357999.

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many)

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are
still not MPSAFE (or already are but aren’t properly marke

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many)

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are
still not MPSAFE (or already are but aren’t properly marked). Use it in
preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and
SYSCTL_PROC nodes using one of the soon-to-be-required flags.

Reviewed by: hselasky, kib
Approved by: kib (mentor)
Differential Revision: https://reviews.freebsd.org/D23632

show more ...

wsp: Fix whitespaces

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>

wsp: Rename max_finger_area sysctl to max_finger_diameter

The value of this sysctl is not an area, but a maximum diameter.

Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>