usbhid(4): Implement USB_GET_DEVICEINFO ioctl

With factoring out of supporting code from ugen(4) driver.
The ioctl is used in FIDO/U2F security key drivers to get
USB product and manufacturer string

usbhid(4): Implement USB_GET_DEVICEINFO ioctl

With factoring out of supporting code from ugen(4) driver.
The ioctl is used in FIDO/U2F security key drivers to get
USB product and manufacturer strings.

PR: 264843
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D51609

show more ...

hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)

It disables interrupt emulation on poll-driven buses like USB and
forces aquiring of only one USB frame per read(2) operation.
This avoid

hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)

It disables interrupt emulation on poll-driven buses like USB and
forces aquiring of only one USB frame per read(2) operation.
This avoids an FIDO/U2F issue where IN endpoint data received from
the device right before the file handle is closed, gets lost.

PR: 263995
Reviewed by: aokblast
Differential revision: https://reviews.freebsd.org/D51605

show more ...

usbhid: Enable by default

Co-authored-by: Emmanuel Vadot <manu@FreeBSD.org>
Reviewed by: bapt, wulf
Relnotes: Yes
Sponsored by: Beckhoff Automation GmbH & Co. KG
Sponsored by: The FreeBSD Foundation

usbhid: Enable by default

Co-authored-by: Emmanuel Vadot <manu@FreeBSD.org>
Reviewed by: bapt, wulf
Relnotes: Yes
Sponsored by: Beckhoff Automation GmbH & Co. KG
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D45659

show more ...

usb: Kill left-over cdefs.h includes

These includes were for __FBSD_RCSID() macro. They weren't formatted
like the rest of the tree so weren't trimmed automatically when that
script was run. Trim th

usb: Kill left-over cdefs.h includes

These includes were for __FBSD_RCSID() macro. They weren't formatted
like the rest of the tree so weren't trimmed automatically when that
script was run. Trim them now.

MFC After: 1 week
Sponsored by: Netflix

show more ...

Use bus_generic_detach instead of device_delete_children in detach

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision: https

Use bus_generic_detach instead of device_delete_children in detach

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision: https://reviews.freebsd.org/D47969

show more ...

Replace calls to bus_generic_attach with bus_attach_children

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D47675

newbus: globally replace device_add_child(..., -1) with DEVICE_UNIT_ANY

Sponsored by: Netflix

sys: Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

hid: Add child device parameter to HID methods

Some devices like Apple HID-over-SPI may contain more than one report
descriptors necessitating creation of multiple hidbus children.
Add indentificato

hid: Add child device parameter to HID methods

Some devices like Apple HID-over-SPI may contain more than one report
descriptors necessitating creation of multiple hidbus children.
Add indentificator of child devices to distinct them.
No functional changes intended.

Differential Revision: https://reviews.freebsd.org/D41246

show more ...

spdx: The BSD-2-Clause-NetBSD identifier is obsolete, drop -NetBSD

The SPDX folks have obsoleted the BSD-2-Clause-NetBSD identifier. Catch
up to that fact and revert to their recommended match of BS

spdx: The BSD-2-Clause-NetBSD identifier is obsolete, drop -NetBSD

The SPDX folks have obsoleted the BSD-2-Clause-NetBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.

Discussed with: pfg
MFC After: 3 days
Sponsored by: Netflix

show more ...

usbhid(4): Increase probe priority to BUS_PROBE_DEFAULT + 1

usbhid(4) vs other USB HID drivers precedence is determined by
hw.usb.usbhid.enable loader tunable and HID quirk subsystem rather
than by

usbhid(4): Increase probe priority to BUS_PROBE_DEFAULT + 1

usbhid(4) vs other USB HID drivers precedence is determined by
hw.usb.usbhid.enable loader tunable and HID quirk subsystem rather
than by device_probe() return value. Raise priority high enough to
always give usbhid(4) a possible chance to attach.

Fixes usbhid(4) attachment on USB device hotplug.

Reported by: Ivan Quitschal <tezeka_AT_hotmail_DOT_com>
MFC after: 1 week

show more ...

usb: Remove unused devclass arguments to DRIVER_MODULE.

usbhid(4): Be more restrictive about what requests are allowed from user-space.

MFC after: 1 month
Sponsored by: NVIDIA Networking

usbhid(4): Implement USB_REQUEST command in hid_ioctl method

This command is intended to be compatible with USB_REQUEST ioctl.
It is required to perform arbitrary control endpoint requests by device

usbhid(4): Implement USB_REQUEST command in hid_ioctl method

This command is intended to be compatible with USB_REQUEST ioctl.
It is required to perform arbitrary control endpoint requests by device
drivers which can switch between HID and native non-HID modes.

MFC after: 2 month

show more ...

usbhid(4): Add second set of USB transfers to work in polled mode.

The second set of USB transfer is requested by hkbd(4) and
should improve HID keyboard handling in kdb and panic contexts.

MFC aft

usbhid(4): Add second set of USB transfers to work in polled mode.

The second set of USB transfer is requested by hkbd(4) and
should improve HID keyboard handling in kdb and panic contexts.

MFC after: 1 week
Reviewed by: hselasky
Differential revision: https://reviews.freebsd.org/D30486

show more ...

usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len()

Which happens when USB transfer setup is failed.

MFC after: 1 week
PR: 254974
Reviewed by: hselasky
Differential revision: https://re

usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len()

Which happens when USB transfer setup is failed.

MFC after: 1 week
PR: 254974
Reviewed by: hselasky
Differential revision: https://reviews.freebsd.org/D30485

show more ...

hid: Replace USBHID_ENABLED kernel config option with loader tunable

usbhid(4) is disabled by default to avoid conflicts with existing USB HID
drivers. To enable it place following lines to /boot/lo

hid: Replace USBHID_ENABLED kernel config option with loader tunable

usbhid(4) is disabled by default to avoid conflicts with existing USB HID
drivers. To enable it place following lines to /boot/loader.conf:

hw.usb.usbhid.enable=1
usbhid_load="YES"

Suggested by: jhb
Reviewed by: hselasky
Differential revision: https://reviews.freebsd.org/D28124

show more ...

hid: Import usbhid - USB transport backend for HID subsystem.

This change implements hid_if.m methods for HID-over-USB protocol [1].

Also, this change adds USBHID_ENABLED kernel option which change

hid: Import usbhid - USB transport backend for HID subsystem.

This change implements hid_if.m methods for HID-over-USB protocol [1].

Also, this change adds USBHID_ENABLED kernel option which changes
device_probe() priority and adds/removes PnP records to prefer usbhid
over ums, ukbd, wmt and other USB HID device drivers and vice-versa.

The module is based on uhid(4) driver. It is disabled by default for
now due to conflicts with existing USB HID drivers.

[1] https://www.usb.org/sites/default/files/hid1_11.pdf

Reviewed by: hselasky
Differential revision: https://reviews.freebsd.org/D27893

show more ...

usbhid(4): Implement USB_GET_DEVICEINFO ioctl

With factoring out of supporting code from ugen(4) driver.
The ioctl is used in FIDO/U2F security key drivers to get
USB product and manufacturer string

usbhid(4): Implement USB_GET_DEVICEINFO ioctl

With factoring out of supporting code from ugen(4) driver.
The ioctl is used in FIDO/U2F security key drivers to get
USB product and manufacturer strings.

PR: 264843
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D51609

show more ...

hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)

It disables interrupt emulation on poll-driven buses like USB and
forces aquiring of only one USB frame per read(2) operation.
This avoid

hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)

It disables interrupt emulation on poll-driven buses like USB and
forces aquiring of only one USB frame per read(2) operation.
This avoids an FIDO/U2F issue where IN endpoint data received from
the device right before the file handle is closed, gets lost.

PR: 263995
Reviewed by: aokblast
Differential revision: https://reviews.freebsd.org/D51605

show more ...

usbhid: Enable by default

Co-authored-by: Emmanuel Vadot <manu@FreeBSD.org>
Reviewed by: bapt, wulf
Relnotes: Yes
Sponsored by: Beckhoff Automation GmbH & Co. KG
Sponsored by: The FreeBSD Foundation

usbhid: Enable by default

Co-authored-by: Emmanuel Vadot <manu@FreeBSD.org>
Reviewed by: bapt, wulf
Relnotes: Yes
Sponsored by: Beckhoff Automation GmbH & Co. KG
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D45659

show more ...

usb: Kill left-over cdefs.h includes

These includes were for __FBSD_RCSID() macro. They weren't formatted
like the rest of the tree so weren't trimmed automatically when that
script was run. Trim th

usb: Kill left-over cdefs.h includes

These includes were for __FBSD_RCSID() macro. They weren't formatted
like the rest of the tree so weren't trimmed automatically when that
script was run. Trim them now.

MFC After: 1 week
Sponsored by: Netflix

show more ...

Use bus_generic_detach instead of device_delete_children in detach

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision: https

Use bus_generic_detach instead of device_delete_children in detach

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision: https://reviews.freebsd.org/D47969

show more ...

Replace calls to bus_generic_attach with bus_attach_children

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D47675

newbus: globally replace device_add_child(..., -1) with DEVICE_UNIT_ANY

Sponsored by: Netflix