| #
d41a2ba7
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
scmi: Avoid a use-after-free
Use LIST_FOREACH_SAFE to avoid a use-after-free in scmi_reqs_pool_free.
The next pointer will be invalid after the call to free meaning
LIST_FOREACH will dereference a f
scmi: Avoid a use-after-free
Use LIST_FOREACH_SAFE to avoid a use-after-free in scmi_reqs_pool_free.
The next pointer will be invalid after the call to free meaning
LIST_FOREACH will dereference a freed struct to move to the next item.
Reviewed by: emaste
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50753
show more ...
|
| #
5a54d768
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add sysctl transport properties
Expose as read-only the configured transport properties.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: htt
scmi: Add sysctl transport properties
Expose as read-only the configured transport properties.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47428
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
d5778530
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add SDT traces to the core stack
Add a few basic traces to track SCMI messages lifecycle.
Tested on: Arm Morello Board
Reviewed by: Andrew
Sponsored by: Arm Ltd
Differential Revision: ht
scmi: Add SDT traces to the core stack
Add a few basic traces to track SCMI messages lifecycle.
Tested on: Arm Morello Board
Reviewed by: Andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47427
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
e478b805
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add optional asynchronous handling of replies
Add the core logic to handle the replies to pending command in an
asynchronous manner.
Tested on: Arm Morello Board
Reviewed by: andrew
Spon
scmi: Add optional asynchronous handling of replies
Add the core logic to handle the replies to pending command in an
asynchronous manner.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47426
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
8f706629
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Refactor scmi_request internal logic
Split scmi_request internals into a TX and an RX phase, which will be
called, anyway, in sequence as before when a normal transmission is
requested.
No fu
scmi: Refactor scmi_request internal logic
Split scmi_request internals into a TX and an RX phase, which will be
called, anyway, in sequence as before when a normal transmission is
requested.
No functional change.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47425
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
35ec332f
|
| 09-Jun-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add scmi_token_reserve helper
During normal operation, the SCMI stack, upon each transmission attempt,
takes care to automatically pick an appropriate, monotonically increasing,
sequence numbe
scmi: Add scmi_token_reserve helper
During normal operation, the SCMI stack, upon each transmission attempt,
takes care to automatically pick an appropriate, monotonically increasing,
sequence number to fill-in the token field in the egressing message.
This does not cope well with the alternative scenario in which, instead,
a complete and fully formed message is provided upfront: in such a case the
SCMI stack will have to use the already provided sequence number, embedded
in the message, to track such transaction.
Add a method to attempt to reserve a specific sequence number to be used
when a fully firmed (raw) message is handled.
Tested on: Arm Morello Board
Reported by: andrew
Sponsored by: Arm ltd
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
f700da1c
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add helper to manipulate scmi_msg descriptors
Refactor allocation logic for scmi_req and introduce new helpers to be able
to obtain an scmi_msg reference to a freshly allocated request.
Teste
scmi: Add helper to manipulate scmi_msg descriptors
Refactor allocation logic for scmi_req and introduce new helpers to be able
to obtain an scmi_msg reference to a freshly allocated request.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47423
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
ba510513
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add devicetree transport properties
SCMI transport characteristics can be optionally described in the
devicetree to override the default build-time values.
Tested on: Arm Morello Board
R
scmi: Add devicetree transport properties
SCMI transport characteristics can be optionally described in the
devicetree to override the default build-time values.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47422
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
c7582083
|
| 09-Jun-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Make transports report the effective length of the received messages
Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the messa
scmi: Make transports report the effective length of the received messages
Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the message received.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
d49ed360
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Make transports report the effective length of the received messages"
Revert to reapply series as some patches were incorrect versions
This reverts commit 9342829d578e26f10a5cbc26e2b9
Revert "scmi: Make transports report the effective length of the received messages"
Revert to reapply series as some patches were incorrect versions
This reverts commit 9342829d578e26f10a5cbc26e2b9e66cfd9864c4.
show more ...
|
| #
04a83b8b
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Add devicetree transport properties"
Revert to reapply series as some patches were incorrect versions
This reverts commit 103ea03e6713a0f3bb874472fbd9fd81e2278805.
|
| #
ed57f6e6
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Add helper to manipulate scmi_msg descriptors"
Revert to reapply series as some patches were incorrect versions
This reverts commit e887179d4bc032e79d0334371d613c5841989a41.
|
| #
b0be4172
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Add scmi_token_reserve helper"
Revert to reapply series as some patches were incorrect versions
This reverts commit c508841dfc5923ef81ed8ea61da364fb20616bbf.
|
| #
b65172cb
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Refactor scmi_request internal logic"
Revert to reapply series as some patches were incorrect versions
This reverts commit 341d8fd90fa084d074059051478657cb45e53402.
|
| #
35fee38c
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Add optional asynchronous handling of replies"
Revert to reapply series as some patches were incorrect versions
This reverts commit b802926b7b145d7cfe2465ac4e19f062a9eb6e6d.
|
| #
c4629b0f
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Add SDT traces to the core stack"
Revert to reapply series as some patches were incorrect versions
This reverts commit 984f9fb81a9dfb9780c9bcc99607ad7cac3a72dd.
|
| #
ea334b97
|
| 09-Jun-2025 |
Andrew Turner <andrew@FreeBSD.org> |
Revert "scmi: Add sysctl transport properties"
Revert to reapply series as some patches were incorrect versions
This reverts commit e6d0edd2fe8c3c15faa7c9c66703efa007a5fbe1.
|
| #
e6d0edd2
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add sysctl transport properties
Expose as read-only the configured transport properties.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: htt
scmi: Add sysctl transport properties
Expose as read-only the configured transport properties.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47428
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
984f9fb8
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add SDT traces to the core stack
Add a few basic traces to track SCMI messages lifecycle.
Tested on: Arm Morello Board
Reviewed by: Andrew
Sponsored by: Arm Ltd
Differential Revision: ht
scmi: Add SDT traces to the core stack
Add a few basic traces to track SCMI messages lifecycle.
Tested on: Arm Morello Board
Reviewed by: Andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47427
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
b802926b
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add optional asynchronous handling of replies
Add the core logic to handle the replies to pending command in an
asynchronous manner.
Tested on: Arm Morello Board
Reviewed by: andrew
Spon
scmi: Add optional asynchronous handling of replies
Add the core logic to handle the replies to pending command in an
asynchronous manner.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47426
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
341d8fd9
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Refactor scmi_request internal logic
Split scmi_request internals into a TX and an RX phase, which will be
called, anyway, in sequence as before when a normal transmission is
requested.
No fu
scmi: Refactor scmi_request internal logic
Split scmi_request internals into a TX and an RX phase, which will be
called, anyway, in sequence as before when a normal transmission is
requested.
No functional change.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47425
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
c508841d
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add scmi_token_reserve helper
During normal operation, the SCMI stack, upon each transmission attempt,
takes care to automatically pick an appropriate, monotonically increasing,
sequence numbe
scmi: Add scmi_token_reserve helper
During normal operation, the SCMI stack, upon each transmission attempt,
takes care to automatically pick an appropriate, monotonically increasing,
sequence number to fill-in the token field in the egressing message.
This does not cope well with the alternative scenario in which, instead,
a complete and fully formed message is provided upfront: in such a case the
SCMI stack will have to use the already provided sequence number, embedded
in the message, to track such transaction.
Add a method to attempt to reserve a specific sequence number to be used
when a fully firmed (raw) message is handled.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Pull Request: https://reviews.freebsd.org/D47424
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
e887179d
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add helper to manipulate scmi_msg descriptors
Refactor allocation logic for scmi_req and introduce new helpers to be able
to obtain an scmi_msg reference to a freshly allocated request.
Teste
scmi: Add helper to manipulate scmi_msg descriptors
Refactor allocation logic for scmi_req and introduce new helpers to be able
to obtain an scmi_msg reference to a freshly allocated request.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47423
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
103ea03e
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Add devicetree transport properties
SCMI transport characteristics can be optionally described in the
devicetree to override the default build-time values.
Tested on: Arm Morello Board
R
scmi: Add devicetree transport properties
SCMI transport characteristics can be optionally described in the
devicetree to override the default build-time values.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47422
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|
| #
9342829d
|
| 23-Jan-2025 |
Cristian Marussi <cristian.marussi@arm.com> |
scmi: Make transports report the effective length of the received messages
Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the messa
scmi: Make transports report the effective length of the received messages
Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the message received.
Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Pull Request: https://reviews.freebsd.org/D47420
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
show more ...
|