krb5: remove libedit from the bootstrap tools

libedit breaks the bootstrap on MacOS and Linux.

Activate libedit only for the regular build not for the bootstrap
tools

While here fix the definition

krb5: remove libedit from the bootstrap tools

libedit breaks the bootstrap on MacOS and Linux.

Activate libedit only for the regular build not for the bootstrap
tools

While here fix the definition of the dependency chain between
libkrb5ss and libedit (and libtinfow) via src.libnames.mk

Remove a local patch to find the readline compatible header and
find them via proper CFLAGS.

show more ...

packages: make UCL files required

Modify template.ucl to require that the "all" UCL file exists for every
package. This prevents packages being added accidentally, and ensures
each package has as l

packages: make UCL files required

Modify template.ucl to require that the "all" UCL file exists for every
package. This prevents packages being added accidentally, and ensures
each package has as least a perfunctory comment and description.

Add missing UCL files for all existing packages.

Modify special packages created by Makefile.inc1 to pass the appropriate
parameters to generate-ucl to find their UCL files.

Reviewed by: des, bapt
Approved by: des (mentor)
Differential Revision: https://reviews.freebsd.org/D50281

show more ...

Makefile.inc1: Always have which succeed

In bootstrap-tools we search for some tools to copy into the obj tree.
If the tool is missing in the host environment then the '[ ! -e ... ]'
check will fail

Makefile.inc1: Always have which succeed

In bootstrap-tools we search for some tools to copy into the obj tree.
If the tool is missing in the host environment then the '[ ! -e ... ]'
check will fail as which will print '<tool> not found'.

There is an issue that which will also return an error so we never get
to the check and don't print the error message. As which outputs an
invalid path on failure we can just add || true to ensure make
continues.

Reviewed by: kevans
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D51075

show more ...

Makefile.inc1: Set SOURCE_DATE_EPOCH in more pkg targets

Otherwise timestamps in the underlying tar files are not reproducible.
I believe this was a simple omission, other package targets specify th

Makefile.inc1: Set SOURCE_DATE_EPOCH in more pkg targets

Otherwise timestamps in the underlying tar files are not reproducible.
I believe this was a simple omission, other package targets specify the
timestamp this way.

Reviewed by: bapt
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D51066

show more ...

Revert "Makefile.inc1: allow real-update-packages to be called independently"

Revert b44147bb1245. It doesn't work right since it doesn't bootstrap
things quite right. It doesn't look trivial to fix

Revert "Makefile.inc1: allow real-update-packages to be called independently"

Revert b44147bb1245. It doesn't work right since it doesn't bootstrap
things quite right. It doesn't look trivial to fix, so revert until a
proper solution is done (though maybe that solution is just do `make
update-packages` and not document/support these other targets).

Suggested by: bapt, emaste
Sponsored by: Netflix

show more ...

Revert "Makefile.inc1: attempt to fix pkgbase building"

This was an attempt to fix b44147bb1245, but it's still not right. Per
conversation on irc, revert it and the other commit so we can redo them

Revert "Makefile.inc1: attempt to fix pkgbase building"

This was an attempt to fix b44147bb1245, but it's still not right. Per
conversation on irc, revert it and the other commit so we can redo them
correctly.

Suggested by: bapt, kevans

show more ...

Makefile.inc1: attempt to fix pkgbase building

After b44147bb12450bdf851a519d1cdc85402f89ed1f there is no dependence
relationshop between create-packages and real-update-packages, which
results on t

Makefile.inc1: attempt to fix pkgbase building

After b44147bb12450bdf851a519d1cdc85402f89ed1f there is no dependence
relationshop between create-packages and real-update-packages, which
results on the package building cluster in a race condition
real-update-packages tries to open a package which is being created by
the create-packages target and make the whole build fail.

Ensure create-packages and real-update-packages is sequential

show more ...

Makefile: Hook MIT KRB5 into the build

Add tests for MK_MITKRB5. If "yes" build MIT KRB5. If "no" build Heimdal.
The default is MK_MITKRB5 = no, added by "krb5: Add build plumbing".

At some point w

Makefile: Hook MIT KRB5 into the build

Add tests for MK_MITKRB5. If "yes" build MIT KRB5. If "no" build Heimdal.
The default is MK_MITKRB5 = no, added by "krb5: Add build plumbing".

At some point we will change the default to MK_MITKRB5 = yes. A ports
exp-run will need to be successfully run first.

Sponsored by: The FreeBSD Foundation
Differential revision: https://reviews.freebsd.org/D50815

show more ...

Makefile.inc1: allow real-update-packages to be called independently

To perform an incremental update of a pkgbase repo, you would
call 'make update-packages', which will stage, create, and
incremen

Makefile.inc1: allow real-update-packages to be called independently

To perform an incremental update of a pkgbase repo, you would
call 'make update-packages', which will stage, create, and
incrementally choose newer package versions to sign as part
of a pkg repo. However, this forces you to stage the kernel
and source packages along with the world packages. For a
jail-only installation of FreeBSD, these packages are generally
not required.

This patch separates the 'update-packages' target from the
'real-update-packages' target to allow choosing world, kernel,
and/or source individually at the command line like so:

Jail-only installation:
1. make -j`nproc` buildworld
2. make PKG_VERSION='15.snap<date>' \
stage-packages-world create-packages-world \
real-update-packages

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1445
Closes: https://github.com/freebsd/freebsd-src/pull/1445

show more ...

Makefile.inc1: minor style changes

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1445

Makefile.inc1: define PKG_VERSION_FROM only if $REPO/latest symlink exists

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1445

Makefile.inc1: Cleanup manpages for arches not included in MAN_ARCH

Apply the fixes to cleanup the compressed or uncompressed man pages to
arches not in MAN_ARCH as well.

Reviewed by: imp
Pull Requ

Makefile.inc1: Cleanup manpages for arches not included in MAN_ARCH

Apply the fixes to cleanup the compressed or uncompressed man pages to
arches not in MAN_ARCH as well.

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1295
Closes: https://github.com/freebsd/freebsd-src/pull/1295

show more ...

Makefile.inc1: Cleanup (un)compressed manpages

When switching between compressed and uncompressed manual pages, the
other type is left behind as divots. Compensate by removing the
now-unwanted man p

Makefile.inc1: Cleanup (un)compressed manpages

When switching between compressed and uncompressed manual pages, the
other type is left behind as divots. Compensate by removing the
now-unwanted man pages automatically.

Reviewed by: imp, jhb
Pull Request: https://github.com/freebsd/freebsd-src/pull/1295

show more ...

build: remove the last vestiges of lint support

Commit 1cbb58886a47 (shipped in 12.0.0) removed all lint infrastructure.
A bunch of NO_LINT definitions remained (perhaps as a bootstrapping
measture)

build: remove the last vestiges of lint support

Commit 1cbb58886a47 (shipped in 12.0.0) removed all lint infrastructure.
A bunch of NO_LINT definitions remained (perhaps as a bootstrapping
measture). Remove them.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D50704

show more ...

Makefile.inc1: Remove unused non-NO_ROOT support

As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute*
and package*") this packagekernel code path is never used, so remove it.

Spo

Makefile.inc1: Remove unused non-NO_ROOT support

As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute*
and package*") this packagekernel code path is never used, so remove it.

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D50361

show more ...

Makefile.inc1: Let the buildetc target run outside of etc

Commit 49bc071f4088 ("nsswitch.conf: Avoid modification after
installation") changes handling of nsswitch.conf such that we make a
copy in t

Makefile.inc1: Let the buildetc target run outside of etc

Commit 49bc071f4088 ("nsswitch.conf: Avoid modification after
installation") changes handling of nsswitch.conf such that we make a
copy in the objdir during a build. Historically, the in-tree
nsswitch.conf lived under etc.

The buildetc target and its copy set SUBDIR_OVERRIDE=etc when building
the object tree, but I think this isn't right when conf files are
scattered around the src tree. If any of them require non-trivial
processing, they'll get skipped during buildetc, and then some
build-time commands may run during installetc. In the linked PR, this
fails because the src tree is mounted read-only and no objdir was
created during buildetc.

Remove the SUBDIR_OVERRIDE for the _obj target, and build the
buildconfig target across the tree.

PR: 286072
Fixes: 49bc071f4088 ("nsswitch.conf: Avoid modification after installation")
Reviewed by: brooks, dim
Tested by: dim, Alastair Hogge <agh@riseup.net>
Differential Revision: https://reviews.freebsd.org/D49960

show more ...

Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG

When WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG are both set, the
cross-tools stage does not build a cross clang binary. This is because
the Makefil

Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG

When WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG are both set, the
cross-tools stage does not build a cross clang binary. This is because
the Makefile in usr.bin/clang checks for WITHOUT_CLANG, and skips
building the binary.

To fix this, ensure that WITH_CLANG is set for the cross-tools phase
whenever WITH_CLANG_BOOTSTRAP is set. While here, skip using the
Makefile in usr.bin/clang, and directly use the Makefile in
usr.bin/clang/clang instead.

PR: 286154
Reported by: avg
Reviewed by: avg, emaste
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D49886

show more ...

elfcopy: Restore upstream name

ELF Tool Chain's objcopy-equivalent is called elfcopy. Restore the
upstream name in our build infrastructure to make it more clear where
different binary utility comp

elfcopy: Restore upstream name

ELF Tool Chain's objcopy-equivalent is called elfcopy. Restore the
upstream name in our build infrastructure to make it more clear where
different binary utility components come from.

Reviewed by: brooks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D49784

show more ...

Makefile.inc1: Rework ELF Tool Chain bootstrapping

Remove additional conditions and bootstrap elfctl, elfdump, and elfcopy
(aka objdump) if ELFTOOLCHAIN_BOOTSTRAP is true. The first two are
bespoke

Makefile.inc1: Rework ELF Tool Chain bootstrapping

Remove additional conditions and bootstrap elfctl, elfdump, and elfcopy
(aka objdump) if ELFTOOLCHAIN_BOOTSTRAP is true. The first two are
bespoke tools that won't exist in an external GNU or LLVM binutils, and
elfcopy is also not provided by that name.

This should fix GCC CI builds, which was skipping the elfcopy build
because of the ${TARGET_ARCH} != ${MACHINE_ARCH} condition.

Reported by: olce
Reviewed by: brooks
Fixes: b885643b63e4 ("boot: Always use ELF Tool Chain elfcopy for EFI builds")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D49493

show more ...

Makefile.inc1: packageworld: remove non-NO_ROOT cases

The packageworld target requires NO_ROOT to be set (and there is a check
that this is the case). Remove the now-unused non-NO_ROOT cases.

Revi

Makefile.inc1: packageworld: remove non-NO_ROOT cases

The packageworld target requires NO_ROOT to be set (and there is a check
that this is the case). Remove the now-unused non-NO_ROOT cases.

Reviewed by: brooks, bz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D48590

show more ...

Makefile.inc1: Conditionalize some package related variables

In particular, don't invoke git to compute SOURCE_DATE_EPOCH for
unrelated targets like check-old or delete-old. If the git invocation
f

Makefile.inc1: Conditionalize some package related variables

In particular, don't invoke git to compute SOURCE_DATE_EPOCH for
unrelated targets like check-old or delete-old. If the git invocation
fails (e.g. when using a git worktree mounted over NFS) it can
generate a lot of irrelevant warning spam.

Reviewed by: emaste
Fixes: 8a3537aaf7c1 ("Makefile.inc1: Make package timestamps reproducible by default")
Differential Revision: https://reviews.freebsd.org/D49278

show more ...

Makefile.inc1: Correct comment for an .endif

Fixes: 0026fec57dfd ("Differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases.")

pkgbase: make pkg repo reproducible

Add a PKG_WORKERS_THREADS variable set to 1 by default, if as a user
you want speed again, then just override it.

Makefile.inc1: Make package timestamps reproducible by default

Set package archive timestamps based on most recent source commit
timestamp (approach suggested by bapt).

I'd like to include git meta

Makefile.inc1: Make package timestamps reproducible by default

Set package archive timestamps based on most recent source commit
timestamp (approach suggested by bapt).

I'd like to include git metadata in a file included in src tarballs, so
that the build is reproducible (including the hash shown in uname etc.)
outside of a git checkout. There are still details to be sorted out to
do that, so this is an interim step to improve reproducibility.

Reviewed by: bapt
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D49165

show more ...

sys: syscalls: add a test syscall definition file

This exercises some subset of the preprocessor that would be nice to
still support.

Pull Request: https://github.com/freebsd/freebsd-src/pull/1575