xref: /qemu/hw/core/machine-qmp-cmds.c (revision 04109957d47307cdedd19afc3687bd6307466b53)
152924deaSMarkus Armbruster /*
252924deaSMarkus Armbruster  * QMP commands related to machines and CPUs
352924deaSMarkus Armbruster  *
452924deaSMarkus Armbruster  * Copyright (C) 2014 Red Hat Inc
552924deaSMarkus Armbruster  *
652924deaSMarkus Armbruster  * This work is licensed under the terms of the GNU GPL, version 2 or later.
752924deaSMarkus Armbruster  * See the COPYING file in the top-level directory.
852924deaSMarkus Armbruster  */
952924deaSMarkus Armbruster 
1052924deaSMarkus Armbruster #include "qemu/osdep.h"
1152924deaSMarkus Armbruster #include "cpu.h"
1252924deaSMarkus Armbruster #include "hw/boards.h"
1352924deaSMarkus Armbruster #include "qapi/error.h"
1452924deaSMarkus Armbruster #include "qapi/qapi-commands-machine.h"
1552924deaSMarkus Armbruster #include "qapi/qmp/qerror.h"
16db725815SMarkus Armbruster #include "qemu/main-loop.h"
1752924deaSMarkus Armbruster #include "sysemu/hostmem.h"
1852924deaSMarkus Armbruster #include "sysemu/hw_accel.h"
1952924deaSMarkus Armbruster #include "sysemu/numa.h"
2054d31236SMarkus Armbruster #include "sysemu/runstate.h"
2152924deaSMarkus Armbruster #include "sysemu/sysemu.h"
2252924deaSMarkus Armbruster 
2352924deaSMarkus Armbruster CpuInfoList *qmp_query_cpus(Error **errp)
2452924deaSMarkus Armbruster {
2552924deaSMarkus Armbruster     MachineState *ms = MACHINE(qdev_get_machine());
2652924deaSMarkus Armbruster     MachineClass *mc = MACHINE_GET_CLASS(ms);
2752924deaSMarkus Armbruster     CpuInfoList *head = NULL, *cur_item = NULL;
2852924deaSMarkus Armbruster     CPUState *cpu;
2952924deaSMarkus Armbruster 
3052924deaSMarkus Armbruster     CPU_FOREACH(cpu) {
3152924deaSMarkus Armbruster         CpuInfoList *info;
3252924deaSMarkus Armbruster #if defined(TARGET_I386)
3352924deaSMarkus Armbruster         X86CPU *x86_cpu = X86_CPU(cpu);
3452924deaSMarkus Armbruster         CPUX86State *env = &x86_cpu->env;
3552924deaSMarkus Armbruster #elif defined(TARGET_PPC)
3652924deaSMarkus Armbruster         PowerPCCPU *ppc_cpu = POWERPC_CPU(cpu);
3752924deaSMarkus Armbruster         CPUPPCState *env = &ppc_cpu->env;
3852924deaSMarkus Armbruster #elif defined(TARGET_SPARC)
3952924deaSMarkus Armbruster         SPARCCPU *sparc_cpu = SPARC_CPU(cpu);
4052924deaSMarkus Armbruster         CPUSPARCState *env = &sparc_cpu->env;
4152924deaSMarkus Armbruster #elif defined(TARGET_RISCV)
4252924deaSMarkus Armbruster         RISCVCPU *riscv_cpu = RISCV_CPU(cpu);
4352924deaSMarkus Armbruster         CPURISCVState *env = &riscv_cpu->env;
4452924deaSMarkus Armbruster #elif defined(TARGET_MIPS)
4552924deaSMarkus Armbruster         MIPSCPU *mips_cpu = MIPS_CPU(cpu);
4652924deaSMarkus Armbruster         CPUMIPSState *env = &mips_cpu->env;
4752924deaSMarkus Armbruster #elif defined(TARGET_TRICORE)
4852924deaSMarkus Armbruster         TriCoreCPU *tricore_cpu = TRICORE_CPU(cpu);
4952924deaSMarkus Armbruster         CPUTriCoreState *env = &tricore_cpu->env;
5052924deaSMarkus Armbruster #elif defined(TARGET_S390X)
5152924deaSMarkus Armbruster         S390CPU *s390_cpu = S390_CPU(cpu);
5252924deaSMarkus Armbruster         CPUS390XState *env = &s390_cpu->env;
5352924deaSMarkus Armbruster #endif
5452924deaSMarkus Armbruster 
5552924deaSMarkus Armbruster         cpu_synchronize_state(cpu);
5652924deaSMarkus Armbruster 
5752924deaSMarkus Armbruster         info = g_malloc0(sizeof(*info));
5852924deaSMarkus Armbruster         info->value = g_malloc0(sizeof(*info->value));
5952924deaSMarkus Armbruster         info->value->CPU = cpu->cpu_index;
6052924deaSMarkus Armbruster         info->value->current = (cpu == first_cpu);
6152924deaSMarkus Armbruster         info->value->halted = cpu->halted;
6252924deaSMarkus Armbruster         info->value->qom_path = object_get_canonical_path(OBJECT(cpu));
6352924deaSMarkus Armbruster         info->value->thread_id = cpu->thread_id;
6452924deaSMarkus Armbruster #if defined(TARGET_I386)
6552924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_X86;
6652924deaSMarkus Armbruster         info->value->u.x86.pc = env->eip + env->segs[R_CS].base;
6752924deaSMarkus Armbruster #elif defined(TARGET_PPC)
6852924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_PPC;
6952924deaSMarkus Armbruster         info->value->u.ppc.nip = env->nip;
7052924deaSMarkus Armbruster #elif defined(TARGET_SPARC)
7152924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_SPARC;
7252924deaSMarkus Armbruster         info->value->u.q_sparc.pc = env->pc;
7352924deaSMarkus Armbruster         info->value->u.q_sparc.npc = env->npc;
7452924deaSMarkus Armbruster #elif defined(TARGET_MIPS)
7552924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_MIPS;
7652924deaSMarkus Armbruster         info->value->u.q_mips.PC = env->active_tc.PC;
7752924deaSMarkus Armbruster #elif defined(TARGET_TRICORE)
7852924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_TRICORE;
7952924deaSMarkus Armbruster         info->value->u.tricore.PC = env->PC;
8052924deaSMarkus Armbruster #elif defined(TARGET_S390X)
8152924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_S390;
8252924deaSMarkus Armbruster         info->value->u.s390.cpu_state = env->cpu_state;
8352924deaSMarkus Armbruster #elif defined(TARGET_RISCV)
8452924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_RISCV;
8552924deaSMarkus Armbruster         info->value->u.riscv.pc = env->pc;
8652924deaSMarkus Armbruster #else
8752924deaSMarkus Armbruster         info->value->arch = CPU_INFO_ARCH_OTHER;
8852924deaSMarkus Armbruster #endif
8952924deaSMarkus Armbruster         info->value->has_props = !!mc->cpu_index_to_instance_props;
9052924deaSMarkus Armbruster         if (info->value->has_props) {
9152924deaSMarkus Armbruster             CpuInstanceProperties *props;
9252924deaSMarkus Armbruster             props = g_malloc0(sizeof(*props));
9352924deaSMarkus Armbruster             *props = mc->cpu_index_to_instance_props(ms, cpu->cpu_index);
9452924deaSMarkus Armbruster             info->value->props = props;
9552924deaSMarkus Armbruster         }
9652924deaSMarkus Armbruster 
9752924deaSMarkus Armbruster         /* XXX: waiting for the qapi to support GSList */
9852924deaSMarkus Armbruster         if (!cur_item) {
9952924deaSMarkus Armbruster             head = cur_item = info;
10052924deaSMarkus Armbruster         } else {
10152924deaSMarkus Armbruster             cur_item->next = info;
10252924deaSMarkus Armbruster             cur_item = info;
10352924deaSMarkus Armbruster         }
10452924deaSMarkus Armbruster     }
10552924deaSMarkus Armbruster 
10652924deaSMarkus Armbruster     return head;
10752924deaSMarkus Armbruster }
10852924deaSMarkus Armbruster 
10952924deaSMarkus Armbruster static CpuInfoArch sysemu_target_to_cpuinfo_arch(SysEmuTarget target)
11052924deaSMarkus Armbruster {
11152924deaSMarkus Armbruster     /*
11252924deaSMarkus Armbruster      * The @SysEmuTarget -> @CpuInfoArch mapping below is based on the
11352924deaSMarkus Armbruster      * TARGET_ARCH -> TARGET_BASE_ARCH mapping in the "configure" script.
11452924deaSMarkus Armbruster      */
11552924deaSMarkus Armbruster     switch (target) {
11652924deaSMarkus Armbruster     case SYS_EMU_TARGET_I386:
11752924deaSMarkus Armbruster     case SYS_EMU_TARGET_X86_64:
11852924deaSMarkus Armbruster         return CPU_INFO_ARCH_X86;
11952924deaSMarkus Armbruster 
12052924deaSMarkus Armbruster     case SYS_EMU_TARGET_PPC:
12152924deaSMarkus Armbruster     case SYS_EMU_TARGET_PPC64:
12252924deaSMarkus Armbruster         return CPU_INFO_ARCH_PPC;
12352924deaSMarkus Armbruster 
12452924deaSMarkus Armbruster     case SYS_EMU_TARGET_SPARC:
12552924deaSMarkus Armbruster     case SYS_EMU_TARGET_SPARC64:
12652924deaSMarkus Armbruster         return CPU_INFO_ARCH_SPARC;
12752924deaSMarkus Armbruster 
12852924deaSMarkus Armbruster     case SYS_EMU_TARGET_MIPS:
12952924deaSMarkus Armbruster     case SYS_EMU_TARGET_MIPSEL:
13052924deaSMarkus Armbruster     case SYS_EMU_TARGET_MIPS64:
13152924deaSMarkus Armbruster     case SYS_EMU_TARGET_MIPS64EL:
13252924deaSMarkus Armbruster         return CPU_INFO_ARCH_MIPS;
13352924deaSMarkus Armbruster 
13452924deaSMarkus Armbruster     case SYS_EMU_TARGET_TRICORE:
13552924deaSMarkus Armbruster         return CPU_INFO_ARCH_TRICORE;
13652924deaSMarkus Armbruster 
13752924deaSMarkus Armbruster     case SYS_EMU_TARGET_S390X:
13852924deaSMarkus Armbruster         return CPU_INFO_ARCH_S390;
13952924deaSMarkus Armbruster 
14052924deaSMarkus Armbruster     case SYS_EMU_TARGET_RISCV32:
14152924deaSMarkus Armbruster     case SYS_EMU_TARGET_RISCV64:
14252924deaSMarkus Armbruster         return CPU_INFO_ARCH_RISCV;
14352924deaSMarkus Armbruster 
14452924deaSMarkus Armbruster     default:
14552924deaSMarkus Armbruster         return CPU_INFO_ARCH_OTHER;
14652924deaSMarkus Armbruster     }
14752924deaSMarkus Armbruster }
14852924deaSMarkus Armbruster 
14952924deaSMarkus Armbruster static void cpustate_to_cpuinfo_s390(CpuInfoS390 *info, const CPUState *cpu)
15052924deaSMarkus Armbruster {
15152924deaSMarkus Armbruster #ifdef TARGET_S390X
15252924deaSMarkus Armbruster     S390CPU *s390_cpu = S390_CPU(cpu);
15352924deaSMarkus Armbruster     CPUS390XState *env = &s390_cpu->env;
15452924deaSMarkus Armbruster 
15552924deaSMarkus Armbruster     info->cpu_state = env->cpu_state;
15652924deaSMarkus Armbruster #else
15752924deaSMarkus Armbruster     abort();
15852924deaSMarkus Armbruster #endif
15952924deaSMarkus Armbruster }
16052924deaSMarkus Armbruster 
16152924deaSMarkus Armbruster /*
16252924deaSMarkus Armbruster  * fast means: we NEVER interrupt vCPU threads to retrieve
16352924deaSMarkus Armbruster  * information from KVM.
16452924deaSMarkus Armbruster  */
16552924deaSMarkus Armbruster CpuInfoFastList *qmp_query_cpus_fast(Error **errp)
16652924deaSMarkus Armbruster {
16752924deaSMarkus Armbruster     MachineState *ms = MACHINE(qdev_get_machine());
16852924deaSMarkus Armbruster     MachineClass *mc = MACHINE_GET_CLASS(ms);
16952924deaSMarkus Armbruster     CpuInfoFastList *head = NULL, *cur_item = NULL;
17052924deaSMarkus Armbruster     SysEmuTarget target = qapi_enum_parse(&SysEmuTarget_lookup, TARGET_NAME,
17152924deaSMarkus Armbruster                                           -1, &error_abort);
17252924deaSMarkus Armbruster     CPUState *cpu;
17352924deaSMarkus Armbruster 
17452924deaSMarkus Armbruster     CPU_FOREACH(cpu) {
17552924deaSMarkus Armbruster         CpuInfoFastList *info = g_malloc0(sizeof(*info));
17652924deaSMarkus Armbruster         info->value = g_malloc0(sizeof(*info->value));
17752924deaSMarkus Armbruster 
17852924deaSMarkus Armbruster         info->value->cpu_index = cpu->cpu_index;
17952924deaSMarkus Armbruster         info->value->qom_path = object_get_canonical_path(OBJECT(cpu));
18052924deaSMarkus Armbruster         info->value->thread_id = cpu->thread_id;
18152924deaSMarkus Armbruster 
18252924deaSMarkus Armbruster         info->value->has_props = !!mc->cpu_index_to_instance_props;
18352924deaSMarkus Armbruster         if (info->value->has_props) {
18452924deaSMarkus Armbruster             CpuInstanceProperties *props;
18552924deaSMarkus Armbruster             props = g_malloc0(sizeof(*props));
18652924deaSMarkus Armbruster             *props = mc->cpu_index_to_instance_props(ms, cpu->cpu_index);
18752924deaSMarkus Armbruster             info->value->props = props;
18852924deaSMarkus Armbruster         }
18952924deaSMarkus Armbruster 
19052924deaSMarkus Armbruster         info->value->arch = sysemu_target_to_cpuinfo_arch(target);
19152924deaSMarkus Armbruster         info->value->target = target;
19252924deaSMarkus Armbruster         if (target == SYS_EMU_TARGET_S390X) {
19352924deaSMarkus Armbruster             cpustate_to_cpuinfo_s390(&info->value->u.s390x, cpu);
19452924deaSMarkus Armbruster         }
19552924deaSMarkus Armbruster 
19652924deaSMarkus Armbruster         if (!cur_item) {
19752924deaSMarkus Armbruster             head = cur_item = info;
19852924deaSMarkus Armbruster         } else {
19952924deaSMarkus Armbruster             cur_item->next = info;
20052924deaSMarkus Armbruster             cur_item = info;
20152924deaSMarkus Armbruster         }
20252924deaSMarkus Armbruster     }
20352924deaSMarkus Armbruster 
20452924deaSMarkus Armbruster     return head;
20552924deaSMarkus Armbruster }
20652924deaSMarkus Armbruster 
20752924deaSMarkus Armbruster MachineInfoList *qmp_query_machines(Error **errp)
20852924deaSMarkus Armbruster {
20952924deaSMarkus Armbruster     GSList *el, *machines = object_class_get_list(TYPE_MACHINE, false);
21052924deaSMarkus Armbruster     MachineInfoList *mach_list = NULL;
21152924deaSMarkus Armbruster 
21252924deaSMarkus Armbruster     for (el = machines; el; el = el->next) {
21352924deaSMarkus Armbruster         MachineClass *mc = el->data;
21452924deaSMarkus Armbruster         MachineInfoList *entry;
21552924deaSMarkus Armbruster         MachineInfo *info;
21652924deaSMarkus Armbruster 
21752924deaSMarkus Armbruster         info = g_malloc0(sizeof(*info));
21852924deaSMarkus Armbruster         if (mc->is_default) {
21952924deaSMarkus Armbruster             info->has_is_default = true;
22052924deaSMarkus Armbruster             info->is_default = true;
22152924deaSMarkus Armbruster         }
22252924deaSMarkus Armbruster 
22352924deaSMarkus Armbruster         if (mc->alias) {
22452924deaSMarkus Armbruster             info->has_alias = true;
22552924deaSMarkus Armbruster             info->alias = g_strdup(mc->alias);
22652924deaSMarkus Armbruster         }
22752924deaSMarkus Armbruster 
22852924deaSMarkus Armbruster         info->name = g_strdup(mc->name);
22952924deaSMarkus Armbruster         info->cpu_max = !mc->max_cpus ? 1 : mc->max_cpus;
23052924deaSMarkus Armbruster         info->hotpluggable_cpus = mc->has_hotpluggable_cpus;
231cd5ff833SIgor Mammedov         info->numa_mem_supported = mc->numa_mem_supported;
23279974027SEduardo Habkost         info->deprecated = !!mc->deprecation_reason;
233*04109957SDaniel P. Berrangé         if (mc->default_cpu_type) {
234*04109957SDaniel P. Berrangé             info->default_cpu_type = g_strdup(mc->default_cpu_type);
235*04109957SDaniel P. Berrangé             info->has_default_cpu_type = true;
236*04109957SDaniel P. Berrangé         }
23752924deaSMarkus Armbruster 
23852924deaSMarkus Armbruster         entry = g_malloc0(sizeof(*entry));
23952924deaSMarkus Armbruster         entry->value = info;
24052924deaSMarkus Armbruster         entry->next = mach_list;
24152924deaSMarkus Armbruster         mach_list = entry;
24252924deaSMarkus Armbruster     }
24352924deaSMarkus Armbruster 
24452924deaSMarkus Armbruster     g_slist_free(machines);
24552924deaSMarkus Armbruster     return mach_list;
24652924deaSMarkus Armbruster }
24752924deaSMarkus Armbruster 
24852924deaSMarkus Armbruster CurrentMachineParams *qmp_query_current_machine(Error **errp)
24952924deaSMarkus Armbruster {
25052924deaSMarkus Armbruster     CurrentMachineParams *params = g_malloc0(sizeof(*params));
25152924deaSMarkus Armbruster     params->wakeup_suspend_support = qemu_wakeup_suspend_enabled();
25252924deaSMarkus Armbruster 
25352924deaSMarkus Armbruster     return params;
25452924deaSMarkus Armbruster }
25552924deaSMarkus Armbruster 
256ffaee83bSMarkus Armbruster TargetInfo *qmp_query_target(Error **errp)
257ffaee83bSMarkus Armbruster {
258ffaee83bSMarkus Armbruster     TargetInfo *info = g_malloc0(sizeof(*info));
259ffaee83bSMarkus Armbruster 
260ffaee83bSMarkus Armbruster     info->arch = qapi_enum_parse(&SysEmuTarget_lookup, TARGET_NAME, -1,
261ffaee83bSMarkus Armbruster                                  &error_abort);
262ffaee83bSMarkus Armbruster 
263ffaee83bSMarkus Armbruster     return info;
264ffaee83bSMarkus Armbruster }
265ffaee83bSMarkus Armbruster 
26652924deaSMarkus Armbruster HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp)
26752924deaSMarkus Armbruster {
26852924deaSMarkus Armbruster     MachineState *ms = MACHINE(qdev_get_machine());
26952924deaSMarkus Armbruster     MachineClass *mc = MACHINE_GET_CLASS(ms);
27052924deaSMarkus Armbruster 
27152924deaSMarkus Armbruster     if (!mc->has_hotpluggable_cpus) {
27252924deaSMarkus Armbruster         error_setg(errp, QERR_FEATURE_DISABLED, "query-hotpluggable-cpus");
27352924deaSMarkus Armbruster         return NULL;
27452924deaSMarkus Armbruster     }
27552924deaSMarkus Armbruster 
27652924deaSMarkus Armbruster     return machine_query_hotpluggable_cpus(ms);
27752924deaSMarkus Armbruster }
27852924deaSMarkus Armbruster 
27952924deaSMarkus Armbruster void qmp_cpu_add(int64_t id, Error **errp)
28052924deaSMarkus Armbruster {
28152924deaSMarkus Armbruster     MachineClass *mc;
28252924deaSMarkus Armbruster 
28352924deaSMarkus Armbruster     mc = MACHINE_GET_CLASS(current_machine);
28452924deaSMarkus Armbruster     if (mc->hot_add_cpu) {
285a0628599SLike Xu         mc->hot_add_cpu(current_machine, id, errp);
28652924deaSMarkus Armbruster     } else {
28752924deaSMarkus Armbruster         error_setg(errp, "Not supported");
28852924deaSMarkus Armbruster     }
28952924deaSMarkus Armbruster }
29052924deaSMarkus Armbruster 
29152924deaSMarkus Armbruster void qmp_set_numa_node(NumaOptions *cmd, Error **errp)
29252924deaSMarkus Armbruster {
29352924deaSMarkus Armbruster     if (!runstate_check(RUN_STATE_PRECONFIG)) {
29452924deaSMarkus Armbruster         error_setg(errp, "The command is permitted only in '%s' state",
29552924deaSMarkus Armbruster                    RunState_str(RUN_STATE_PRECONFIG));
29652924deaSMarkus Armbruster          return;
29752924deaSMarkus Armbruster     }
29852924deaSMarkus Armbruster 
29952924deaSMarkus Armbruster     set_numa_options(MACHINE(qdev_get_machine()), cmd, errp);
30052924deaSMarkus Armbruster }
30152924deaSMarkus Armbruster 
30252924deaSMarkus Armbruster static int query_memdev(Object *obj, void *opaque)
30352924deaSMarkus Armbruster {
30452924deaSMarkus Armbruster     MemdevList **list = opaque;
30552924deaSMarkus Armbruster     MemdevList *m = NULL;
30652924deaSMarkus Armbruster 
30752924deaSMarkus Armbruster     if (object_dynamic_cast(obj, TYPE_MEMORY_BACKEND)) {
30852924deaSMarkus Armbruster         m = g_malloc0(sizeof(*m));
30952924deaSMarkus Armbruster 
31052924deaSMarkus Armbruster         m->value = g_malloc0(sizeof(*m->value));
31152924deaSMarkus Armbruster 
31252924deaSMarkus Armbruster         m->value->id = object_get_canonical_path_component(obj);
31352924deaSMarkus Armbruster         m->value->has_id = !!m->value->id;
31452924deaSMarkus Armbruster 
31552924deaSMarkus Armbruster         m->value->size = object_property_get_uint(obj, "size",
31652924deaSMarkus Armbruster                                                   &error_abort);
31752924deaSMarkus Armbruster         m->value->merge = object_property_get_bool(obj, "merge",
31852924deaSMarkus Armbruster                                                    &error_abort);
31952924deaSMarkus Armbruster         m->value->dump = object_property_get_bool(obj, "dump",
32052924deaSMarkus Armbruster                                                   &error_abort);
32152924deaSMarkus Armbruster         m->value->prealloc = object_property_get_bool(obj,
32252924deaSMarkus Armbruster                                                       "prealloc",
32352924deaSMarkus Armbruster                                                       &error_abort);
32452924deaSMarkus Armbruster         m->value->policy = object_property_get_enum(obj,
32552924deaSMarkus Armbruster                                                     "policy",
32652924deaSMarkus Armbruster                                                     "HostMemPolicy",
32752924deaSMarkus Armbruster                                                     &error_abort);
32852924deaSMarkus Armbruster         object_property_get_uint16List(obj, "host-nodes",
32952924deaSMarkus Armbruster                                        &m->value->host_nodes,
33052924deaSMarkus Armbruster                                        &error_abort);
33152924deaSMarkus Armbruster 
33252924deaSMarkus Armbruster         m->next = *list;
33352924deaSMarkus Armbruster         *list = m;
33452924deaSMarkus Armbruster     }
33552924deaSMarkus Armbruster 
33652924deaSMarkus Armbruster     return 0;
33752924deaSMarkus Armbruster }
33852924deaSMarkus Armbruster 
33952924deaSMarkus Armbruster MemdevList *qmp_query_memdev(Error **errp)
34052924deaSMarkus Armbruster {
34152924deaSMarkus Armbruster     Object *obj = object_get_objects_root();
34252924deaSMarkus Armbruster     MemdevList *list = NULL;
34352924deaSMarkus Armbruster 
34452924deaSMarkus Armbruster     object_child_foreach(obj, query_memdev, &list);
34552924deaSMarkus Armbruster     return list;
34652924deaSMarkus Armbruster }
347