xref: /qemu/block/mirror.c (revision 373df5b135b4a54e0abb394e9e703fef3ded093c)
1893f7ebaSPaolo Bonzini /*
2893f7ebaSPaolo Bonzini  * Image mirroring
3893f7ebaSPaolo Bonzini  *
4893f7ebaSPaolo Bonzini  * Copyright Red Hat, Inc. 2012
5893f7ebaSPaolo Bonzini  *
6893f7ebaSPaolo Bonzini  * Authors:
7893f7ebaSPaolo Bonzini  *  Paolo Bonzini  <pbonzini@redhat.com>
8893f7ebaSPaolo Bonzini  *
9893f7ebaSPaolo Bonzini  * This work is licensed under the terms of the GNU LGPL, version 2 or later.
10893f7ebaSPaolo Bonzini  * See the COPYING.LIB file in the top-level directory.
11893f7ebaSPaolo Bonzini  *
12893f7ebaSPaolo Bonzini  */
13893f7ebaSPaolo Bonzini 
14893f7ebaSPaolo Bonzini #include "trace.h"
15737e150eSPaolo Bonzini #include "block/blockjob.h"
16737e150eSPaolo Bonzini #include "block/block_int.h"
17893f7ebaSPaolo Bonzini #include "qemu/ratelimit.h"
18b812f671SPaolo Bonzini #include "qemu/bitmap.h"
19893f7ebaSPaolo Bonzini 
20893f7ebaSPaolo Bonzini #define SLICE_TIME    100000000ULL /* ns */
21402a4741SPaolo Bonzini #define MAX_IN_FLIGHT 16
22402a4741SPaolo Bonzini 
23402a4741SPaolo Bonzini /* The mirroring buffer is a list of granularity-sized chunks.
24402a4741SPaolo Bonzini  * Free chunks are organized in a list.
25402a4741SPaolo Bonzini  */
26402a4741SPaolo Bonzini typedef struct MirrorBuffer {
27402a4741SPaolo Bonzini     QSIMPLEQ_ENTRY(MirrorBuffer) next;
28402a4741SPaolo Bonzini } MirrorBuffer;
29893f7ebaSPaolo Bonzini 
30893f7ebaSPaolo Bonzini typedef struct MirrorBlockJob {
31893f7ebaSPaolo Bonzini     BlockJob common;
32893f7ebaSPaolo Bonzini     RateLimit limit;
33893f7ebaSPaolo Bonzini     BlockDriverState *target;
345bc361b8SFam Zheng     BlockDriverState *base;
3503544a6eSFam Zheng     bool is_none_mode;
36b952b558SPaolo Bonzini     BlockdevOnError on_source_error, on_target_error;
37d63ffd87SPaolo Bonzini     bool synced;
38d63ffd87SPaolo Bonzini     bool should_complete;
39893f7ebaSPaolo Bonzini     int64_t sector_num;
40eee13dfeSPaolo Bonzini     int64_t granularity;
41b812f671SPaolo Bonzini     size_t buf_size;
42b812f671SPaolo Bonzini     unsigned long *cow_bitmap;
43e4654d2dSFam Zheng     BdrvDirtyBitmap *dirty_bitmap;
448f0720ecSPaolo Bonzini     HBitmapIter hbi;
45893f7ebaSPaolo Bonzini     uint8_t *buf;
46402a4741SPaolo Bonzini     QSIMPLEQ_HEAD(, MirrorBuffer) buf_free;
47402a4741SPaolo Bonzini     int buf_free_count;
48bd48bde8SPaolo Bonzini 
49402a4741SPaolo Bonzini     unsigned long *in_flight_bitmap;
50bd48bde8SPaolo Bonzini     int in_flight;
51bd48bde8SPaolo Bonzini     int ret;
52893f7ebaSPaolo Bonzini } MirrorBlockJob;
53893f7ebaSPaolo Bonzini 
54bd48bde8SPaolo Bonzini typedef struct MirrorOp {
55bd48bde8SPaolo Bonzini     MirrorBlockJob *s;
56bd48bde8SPaolo Bonzini     QEMUIOVector qiov;
57bd48bde8SPaolo Bonzini     int64_t sector_num;
58bd48bde8SPaolo Bonzini     int nb_sectors;
59bd48bde8SPaolo Bonzini } MirrorOp;
60bd48bde8SPaolo Bonzini 
61b952b558SPaolo Bonzini static BlockErrorAction mirror_error_action(MirrorBlockJob *s, bool read,
62b952b558SPaolo Bonzini                                             int error)
63b952b558SPaolo Bonzini {
64b952b558SPaolo Bonzini     s->synced = false;
65b952b558SPaolo Bonzini     if (read) {
66b952b558SPaolo Bonzini         return block_job_error_action(&s->common, s->common.bs,
67b952b558SPaolo Bonzini                                       s->on_source_error, true, error);
68b952b558SPaolo Bonzini     } else {
69b952b558SPaolo Bonzini         return block_job_error_action(&s->common, s->target,
70b952b558SPaolo Bonzini                                       s->on_target_error, false, error);
71b952b558SPaolo Bonzini     }
72b952b558SPaolo Bonzini }
73b952b558SPaolo Bonzini 
74bd48bde8SPaolo Bonzini static void mirror_iteration_done(MirrorOp *op, int ret)
75bd48bde8SPaolo Bonzini {
76bd48bde8SPaolo Bonzini     MirrorBlockJob *s = op->s;
77402a4741SPaolo Bonzini     struct iovec *iov;
78bd48bde8SPaolo Bonzini     int64_t chunk_num;
79402a4741SPaolo Bonzini     int i, nb_chunks, sectors_per_chunk;
80bd48bde8SPaolo Bonzini 
81bd48bde8SPaolo Bonzini     trace_mirror_iteration_done(s, op->sector_num, op->nb_sectors, ret);
82bd48bde8SPaolo Bonzini 
83bd48bde8SPaolo Bonzini     s->in_flight--;
84402a4741SPaolo Bonzini     iov = op->qiov.iov;
85402a4741SPaolo Bonzini     for (i = 0; i < op->qiov.niov; i++) {
86402a4741SPaolo Bonzini         MirrorBuffer *buf = (MirrorBuffer *) iov[i].iov_base;
87402a4741SPaolo Bonzini         QSIMPLEQ_INSERT_TAIL(&s->buf_free, buf, next);
88402a4741SPaolo Bonzini         s->buf_free_count++;
89402a4741SPaolo Bonzini     }
90402a4741SPaolo Bonzini 
91bd48bde8SPaolo Bonzini     sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS;
92bd48bde8SPaolo Bonzini     chunk_num = op->sector_num / sectors_per_chunk;
93bd48bde8SPaolo Bonzini     nb_chunks = op->nb_sectors / sectors_per_chunk;
94402a4741SPaolo Bonzini     bitmap_clear(s->in_flight_bitmap, chunk_num, nb_chunks);
95bd48bde8SPaolo Bonzini     if (s->cow_bitmap && ret >= 0) {
96bd48bde8SPaolo Bonzini         bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);
97bd48bde8SPaolo Bonzini     }
98bd48bde8SPaolo Bonzini 
996df3bf8eSZhang Min     qemu_iovec_destroy(&op->qiov);
100bd48bde8SPaolo Bonzini     g_slice_free(MirrorOp, op);
1017b770c72SStefan Hajnoczi 
1027b770c72SStefan Hajnoczi     /* Enter coroutine when it is not sleeping.  The coroutine sleeps to
1037b770c72SStefan Hajnoczi      * rate-limit itself.  The coroutine will eventually resume since there is
1047b770c72SStefan Hajnoczi      * a sleep timeout so don't wake it early.
1057b770c72SStefan Hajnoczi      */
1067b770c72SStefan Hajnoczi     if (s->common.busy) {
107bd48bde8SPaolo Bonzini         qemu_coroutine_enter(s->common.co, NULL);
108bd48bde8SPaolo Bonzini     }
1097b770c72SStefan Hajnoczi }
110bd48bde8SPaolo Bonzini 
111bd48bde8SPaolo Bonzini static void mirror_write_complete(void *opaque, int ret)
112bd48bde8SPaolo Bonzini {
113bd48bde8SPaolo Bonzini     MirrorOp *op = opaque;
114bd48bde8SPaolo Bonzini     MirrorBlockJob *s = op->s;
115bd48bde8SPaolo Bonzini     if (ret < 0) {
116bd48bde8SPaolo Bonzini         BlockDriverState *source = s->common.bs;
117bd48bde8SPaolo Bonzini         BlockErrorAction action;
118bd48bde8SPaolo Bonzini 
119bd48bde8SPaolo Bonzini         bdrv_set_dirty(source, op->sector_num, op->nb_sectors);
120bd48bde8SPaolo Bonzini         action = mirror_error_action(s, false, -ret);
121bd48bde8SPaolo Bonzini         if (action == BDRV_ACTION_REPORT && s->ret >= 0) {
122bd48bde8SPaolo Bonzini             s->ret = ret;
123bd48bde8SPaolo Bonzini         }
124bd48bde8SPaolo Bonzini     }
125bd48bde8SPaolo Bonzini     mirror_iteration_done(op, ret);
126bd48bde8SPaolo Bonzini }
127bd48bde8SPaolo Bonzini 
128bd48bde8SPaolo Bonzini static void mirror_read_complete(void *opaque, int ret)
129bd48bde8SPaolo Bonzini {
130bd48bde8SPaolo Bonzini     MirrorOp *op = opaque;
131bd48bde8SPaolo Bonzini     MirrorBlockJob *s = op->s;
132bd48bde8SPaolo Bonzini     if (ret < 0) {
133bd48bde8SPaolo Bonzini         BlockDriverState *source = s->common.bs;
134bd48bde8SPaolo Bonzini         BlockErrorAction action;
135bd48bde8SPaolo Bonzini 
136bd48bde8SPaolo Bonzini         bdrv_set_dirty(source, op->sector_num, op->nb_sectors);
137bd48bde8SPaolo Bonzini         action = mirror_error_action(s, true, -ret);
138bd48bde8SPaolo Bonzini         if (action == BDRV_ACTION_REPORT && s->ret >= 0) {
139bd48bde8SPaolo Bonzini             s->ret = ret;
140bd48bde8SPaolo Bonzini         }
141bd48bde8SPaolo Bonzini 
142bd48bde8SPaolo Bonzini         mirror_iteration_done(op, ret);
143bd48bde8SPaolo Bonzini         return;
144bd48bde8SPaolo Bonzini     }
145bd48bde8SPaolo Bonzini     bdrv_aio_writev(s->target, op->sector_num, &op->qiov, op->nb_sectors,
146bd48bde8SPaolo Bonzini                     mirror_write_complete, op);
147bd48bde8SPaolo Bonzini }
148bd48bde8SPaolo Bonzini 
149cc8c9d6cSPaolo Bonzini static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
150893f7ebaSPaolo Bonzini {
151893f7ebaSPaolo Bonzini     BlockDriverState *source = s->common.bs;
152402a4741SPaolo Bonzini     int nb_sectors, sectors_per_chunk, nb_chunks;
153884fea4eSPaolo Bonzini     int64_t end, sector_num, next_chunk, next_sector, hbitmap_next_sector;
154cc8c9d6cSPaolo Bonzini     uint64_t delay_ns;
155bd48bde8SPaolo Bonzini     MirrorOp *op;
156893f7ebaSPaolo Bonzini 
1578f0720ecSPaolo Bonzini     s->sector_num = hbitmap_iter_next(&s->hbi);
1588f0720ecSPaolo Bonzini     if (s->sector_num < 0) {
159e4654d2dSFam Zheng         bdrv_dirty_iter_init(source, s->dirty_bitmap, &s->hbi);
1608f0720ecSPaolo Bonzini         s->sector_num = hbitmap_iter_next(&s->hbi);
161e4654d2dSFam Zheng         trace_mirror_restart_iter(s,
162e4654d2dSFam Zheng                                   bdrv_get_dirty_count(source, s->dirty_bitmap));
1638f0720ecSPaolo Bonzini         assert(s->sector_num >= 0);
1648f0720ecSPaolo Bonzini     }
1658f0720ecSPaolo Bonzini 
166402a4741SPaolo Bonzini     hbitmap_next_sector = s->sector_num;
167b812f671SPaolo Bonzini     sector_num = s->sector_num;
168884fea4eSPaolo Bonzini     sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS;
169884fea4eSPaolo Bonzini     end = s->common.len >> BDRV_SECTOR_BITS;
170402a4741SPaolo Bonzini 
171884fea4eSPaolo Bonzini     /* Extend the QEMUIOVector to include all adjacent blocks that will
172884fea4eSPaolo Bonzini      * be copied in this operation.
173884fea4eSPaolo Bonzini      *
174884fea4eSPaolo Bonzini      * We have to do this if we have no backing file yet in the destination,
175884fea4eSPaolo Bonzini      * and the cluster size is very large.  Then we need to do COW ourselves.
176884fea4eSPaolo Bonzini      * The first time a cluster is copied, copy it entirely.  Note that,
177884fea4eSPaolo Bonzini      * because both the granularity and the cluster size are powers of two,
178884fea4eSPaolo Bonzini      * the number of sectors to copy cannot exceed one cluster.
179884fea4eSPaolo Bonzini      *
180884fea4eSPaolo Bonzini      * We also want to extend the QEMUIOVector to include more adjacent
181884fea4eSPaolo Bonzini      * dirty blocks if possible, to limit the number of I/O operations and
182884fea4eSPaolo Bonzini      * run efficiently even with a small granularity.
183402a4741SPaolo Bonzini      */
184884fea4eSPaolo Bonzini     nb_chunks = 0;
185884fea4eSPaolo Bonzini     nb_sectors = 0;
186884fea4eSPaolo Bonzini     next_sector = sector_num;
187884fea4eSPaolo Bonzini     next_chunk = sector_num / sectors_per_chunk;
188402a4741SPaolo Bonzini 
189402a4741SPaolo Bonzini     /* Wait for I/O to this cluster (from a previous iteration) to be done.  */
190884fea4eSPaolo Bonzini     while (test_bit(next_chunk, s->in_flight_bitmap)) {
191402a4741SPaolo Bonzini         trace_mirror_yield_in_flight(s, sector_num, s->in_flight);
192402a4741SPaolo Bonzini         qemu_coroutine_yield();
193b812f671SPaolo Bonzini     }
194b812f671SPaolo Bonzini 
195884fea4eSPaolo Bonzini     do {
196884fea4eSPaolo Bonzini         int added_sectors, added_chunks;
197884fea4eSPaolo Bonzini 
198e4654d2dSFam Zheng         if (!bdrv_get_dirty(source, s->dirty_bitmap, next_sector) ||
199884fea4eSPaolo Bonzini             test_bit(next_chunk, s->in_flight_bitmap)) {
200884fea4eSPaolo Bonzini             assert(nb_sectors > 0);
201884fea4eSPaolo Bonzini             break;
202884fea4eSPaolo Bonzini         }
203884fea4eSPaolo Bonzini 
204884fea4eSPaolo Bonzini         added_sectors = sectors_per_chunk;
205884fea4eSPaolo Bonzini         if (s->cow_bitmap && !test_bit(next_chunk, s->cow_bitmap)) {
206884fea4eSPaolo Bonzini             bdrv_round_to_clusters(s->target,
207884fea4eSPaolo Bonzini                                    next_sector, added_sectors,
208884fea4eSPaolo Bonzini                                    &next_sector, &added_sectors);
209884fea4eSPaolo Bonzini 
210884fea4eSPaolo Bonzini             /* On the first iteration, the rounding may make us copy
211884fea4eSPaolo Bonzini              * sectors before the first dirty one.
212884fea4eSPaolo Bonzini              */
213884fea4eSPaolo Bonzini             if (next_sector < sector_num) {
214884fea4eSPaolo Bonzini                 assert(nb_sectors == 0);
215884fea4eSPaolo Bonzini                 sector_num = next_sector;
216884fea4eSPaolo Bonzini                 next_chunk = next_sector / sectors_per_chunk;
217884fea4eSPaolo Bonzini             }
218884fea4eSPaolo Bonzini         }
219884fea4eSPaolo Bonzini 
220884fea4eSPaolo Bonzini         added_sectors = MIN(added_sectors, end - (sector_num + nb_sectors));
221884fea4eSPaolo Bonzini         added_chunks = (added_sectors + sectors_per_chunk - 1) / sectors_per_chunk;
222884fea4eSPaolo Bonzini 
223884fea4eSPaolo Bonzini         /* When doing COW, it may happen that there is not enough space for
224884fea4eSPaolo Bonzini          * a full cluster.  Wait if that is the case.
225884fea4eSPaolo Bonzini          */
226884fea4eSPaolo Bonzini         while (nb_chunks == 0 && s->buf_free_count < added_chunks) {
227402a4741SPaolo Bonzini             trace_mirror_yield_buf_busy(s, nb_chunks, s->in_flight);
228402a4741SPaolo Bonzini             qemu_coroutine_yield();
229402a4741SPaolo Bonzini         }
230884fea4eSPaolo Bonzini         if (s->buf_free_count < nb_chunks + added_chunks) {
231884fea4eSPaolo Bonzini             trace_mirror_break_buf_busy(s, nb_chunks, s->in_flight);
232884fea4eSPaolo Bonzini             break;
233884fea4eSPaolo Bonzini         }
234402a4741SPaolo Bonzini 
235402a4741SPaolo Bonzini         /* We have enough free space to copy these sectors.  */
236884fea4eSPaolo Bonzini         bitmap_set(s->in_flight_bitmap, next_chunk, added_chunks);
237884fea4eSPaolo Bonzini 
238884fea4eSPaolo Bonzini         nb_sectors += added_sectors;
239884fea4eSPaolo Bonzini         nb_chunks += added_chunks;
240884fea4eSPaolo Bonzini         next_sector += added_sectors;
241884fea4eSPaolo Bonzini         next_chunk += added_chunks;
242cc8c9d6cSPaolo Bonzini         if (!s->synced && s->common.speed) {
243cc8c9d6cSPaolo Bonzini             delay_ns = ratelimit_calculate_delay(&s->limit, added_sectors);
244cc8c9d6cSPaolo Bonzini         } else {
245cc8c9d6cSPaolo Bonzini             delay_ns = 0;
246cc8c9d6cSPaolo Bonzini         }
247cc8c9d6cSPaolo Bonzini     } while (delay_ns == 0 && next_sector < end);
248bd48bde8SPaolo Bonzini 
249bd48bde8SPaolo Bonzini     /* Allocate a MirrorOp that is used as an AIO callback.  */
250bd48bde8SPaolo Bonzini     op = g_slice_new(MirrorOp);
251bd48bde8SPaolo Bonzini     op->s = s;
252bd48bde8SPaolo Bonzini     op->sector_num = sector_num;
253bd48bde8SPaolo Bonzini     op->nb_sectors = nb_sectors;
254402a4741SPaolo Bonzini 
255402a4741SPaolo Bonzini     /* Now make a QEMUIOVector taking enough granularity-sized chunks
256402a4741SPaolo Bonzini      * from s->buf_free.
257402a4741SPaolo Bonzini      */
258402a4741SPaolo Bonzini     qemu_iovec_init(&op->qiov, nb_chunks);
259402a4741SPaolo Bonzini     next_sector = sector_num;
260402a4741SPaolo Bonzini     while (nb_chunks-- > 0) {
261402a4741SPaolo Bonzini         MirrorBuffer *buf = QSIMPLEQ_FIRST(&s->buf_free);
262402a4741SPaolo Bonzini         QSIMPLEQ_REMOVE_HEAD(&s->buf_free, next);
263402a4741SPaolo Bonzini         s->buf_free_count--;
264402a4741SPaolo Bonzini         qemu_iovec_add(&op->qiov, buf, s->granularity);
265402a4741SPaolo Bonzini 
266402a4741SPaolo Bonzini         /* Advance the HBitmapIter in parallel, so that we do not examine
267402a4741SPaolo Bonzini          * the same sector twice.
268402a4741SPaolo Bonzini          */
269e4654d2dSFam Zheng         if (next_sector > hbitmap_next_sector
270e4654d2dSFam Zheng             && bdrv_get_dirty(source, s->dirty_bitmap, next_sector)) {
271402a4741SPaolo Bonzini             hbitmap_next_sector = hbitmap_iter_next(&s->hbi);
272402a4741SPaolo Bonzini         }
273402a4741SPaolo Bonzini 
274402a4741SPaolo Bonzini         next_sector += sectors_per_chunk;
275402a4741SPaolo Bonzini     }
276bd48bde8SPaolo Bonzini 
277b812f671SPaolo Bonzini     bdrv_reset_dirty(source, sector_num, nb_sectors);
278893f7ebaSPaolo Bonzini 
279893f7ebaSPaolo Bonzini     /* Copy the dirty cluster.  */
280bd48bde8SPaolo Bonzini     s->in_flight++;
281b812f671SPaolo Bonzini     trace_mirror_one_iteration(s, sector_num, nb_sectors);
282bd48bde8SPaolo Bonzini     bdrv_aio_readv(source, sector_num, &op->qiov, nb_sectors,
283bd48bde8SPaolo Bonzini                    mirror_read_complete, op);
284cc8c9d6cSPaolo Bonzini     return delay_ns;
285893f7ebaSPaolo Bonzini }
286b952b558SPaolo Bonzini 
287402a4741SPaolo Bonzini static void mirror_free_init(MirrorBlockJob *s)
288402a4741SPaolo Bonzini {
289402a4741SPaolo Bonzini     int granularity = s->granularity;
290402a4741SPaolo Bonzini     size_t buf_size = s->buf_size;
291402a4741SPaolo Bonzini     uint8_t *buf = s->buf;
292402a4741SPaolo Bonzini 
293402a4741SPaolo Bonzini     assert(s->buf_free_count == 0);
294402a4741SPaolo Bonzini     QSIMPLEQ_INIT(&s->buf_free);
295402a4741SPaolo Bonzini     while (buf_size != 0) {
296402a4741SPaolo Bonzini         MirrorBuffer *cur = (MirrorBuffer *)buf;
297402a4741SPaolo Bonzini         QSIMPLEQ_INSERT_TAIL(&s->buf_free, cur, next);
298402a4741SPaolo Bonzini         s->buf_free_count++;
299402a4741SPaolo Bonzini         buf_size -= granularity;
300402a4741SPaolo Bonzini         buf += granularity;
301402a4741SPaolo Bonzini     }
302402a4741SPaolo Bonzini }
303402a4741SPaolo Bonzini 
304bd48bde8SPaolo Bonzini static void mirror_drain(MirrorBlockJob *s)
305bd48bde8SPaolo Bonzini {
306bd48bde8SPaolo Bonzini     while (s->in_flight > 0) {
307bd48bde8SPaolo Bonzini         qemu_coroutine_yield();
308bd48bde8SPaolo Bonzini     }
309893f7ebaSPaolo Bonzini }
310893f7ebaSPaolo Bonzini 
311893f7ebaSPaolo Bonzini static void coroutine_fn mirror_run(void *opaque)
312893f7ebaSPaolo Bonzini {
313893f7ebaSPaolo Bonzini     MirrorBlockJob *s = opaque;
314893f7ebaSPaolo Bonzini     BlockDriverState *bs = s->common.bs;
315eee13dfeSPaolo Bonzini     int64_t sector_num, end, sectors_per_chunk, length;
316bd48bde8SPaolo Bonzini     uint64_t last_pause_ns;
317b812f671SPaolo Bonzini     BlockDriverInfo bdi;
318b812f671SPaolo Bonzini     char backing_filename[1024];
319893f7ebaSPaolo Bonzini     int ret = 0;
320893f7ebaSPaolo Bonzini     int n;
321893f7ebaSPaolo Bonzini 
322893f7ebaSPaolo Bonzini     if (block_job_is_cancelled(&s->common)) {
323893f7ebaSPaolo Bonzini         goto immediate_exit;
324893f7ebaSPaolo Bonzini     }
325893f7ebaSPaolo Bonzini 
326893f7ebaSPaolo Bonzini     s->common.len = bdrv_getlength(bs);
32788ff0e48SPaolo Bonzini     if (s->common.len <= 0) {
328*373df5b1SFam Zheng         ret = s->common.len;
329*373df5b1SFam Zheng         goto immediate_exit;
330893f7ebaSPaolo Bonzini     }
331893f7ebaSPaolo Bonzini 
332f0e97360SFam Zheng     length = DIV_ROUND_UP(s->common.len, s->granularity);
333402a4741SPaolo Bonzini     s->in_flight_bitmap = bitmap_new(length);
334402a4741SPaolo Bonzini 
335b812f671SPaolo Bonzini     /* If we have no backing file yet in the destination, we cannot let
336b812f671SPaolo Bonzini      * the destination do COW.  Instead, we copy sectors around the
337b812f671SPaolo Bonzini      * dirty data if needed.  We need a bitmap to do that.
338b812f671SPaolo Bonzini      */
339b812f671SPaolo Bonzini     bdrv_get_backing_filename(s->target, backing_filename,
340b812f671SPaolo Bonzini                               sizeof(backing_filename));
341b812f671SPaolo Bonzini     if (backing_filename[0] && !s->target->backing_hd) {
342b812f671SPaolo Bonzini         bdrv_get_info(s->target, &bdi);
343eee13dfeSPaolo Bonzini         if (s->granularity < bdi.cluster_size) {
34408e4ed6cSPaolo Bonzini             s->buf_size = MAX(s->buf_size, bdi.cluster_size);
345b812f671SPaolo Bonzini             s->cow_bitmap = bitmap_new(length);
346b812f671SPaolo Bonzini         }
347b812f671SPaolo Bonzini     }
348b812f671SPaolo Bonzini 
349893f7ebaSPaolo Bonzini     end = s->common.len >> BDRV_SECTOR_BITS;
350b812f671SPaolo Bonzini     s->buf = qemu_blockalign(bs, s->buf_size);
351eee13dfeSPaolo Bonzini     sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS;
352402a4741SPaolo Bonzini     mirror_free_init(s);
353893f7ebaSPaolo Bonzini 
35403544a6eSFam Zheng     if (!s->is_none_mode) {
355893f7ebaSPaolo Bonzini         /* First part, loop on the sectors and initialize the dirty bitmap.  */
3565bc361b8SFam Zheng         BlockDriverState *base = s->base;
357893f7ebaSPaolo Bonzini         for (sector_num = 0; sector_num < end; ) {
358eee13dfeSPaolo Bonzini             int64_t next = (sector_num | (sectors_per_chunk - 1)) + 1;
3594f578637SPaolo Bonzini             ret = bdrv_is_allocated_above(bs, base,
360893f7ebaSPaolo Bonzini                                           sector_num, next - sector_num, &n);
361893f7ebaSPaolo Bonzini 
362893f7ebaSPaolo Bonzini             if (ret < 0) {
363893f7ebaSPaolo Bonzini                 goto immediate_exit;
364893f7ebaSPaolo Bonzini             }
365893f7ebaSPaolo Bonzini 
366893f7ebaSPaolo Bonzini             assert(n > 0);
367893f7ebaSPaolo Bonzini             if (ret == 1) {
368893f7ebaSPaolo Bonzini                 bdrv_set_dirty(bs, sector_num, n);
369893f7ebaSPaolo Bonzini                 sector_num = next;
370893f7ebaSPaolo Bonzini             } else {
371893f7ebaSPaolo Bonzini                 sector_num += n;
372893f7ebaSPaolo Bonzini             }
373893f7ebaSPaolo Bonzini         }
374893f7ebaSPaolo Bonzini     }
375893f7ebaSPaolo Bonzini 
376e4654d2dSFam Zheng     bdrv_dirty_iter_init(bs, s->dirty_bitmap, &s->hbi);
377bc72ad67SAlex Bligh     last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
378893f7ebaSPaolo Bonzini     for (;;) {
379cc8c9d6cSPaolo Bonzini         uint64_t delay_ns = 0;
380893f7ebaSPaolo Bonzini         int64_t cnt;
381893f7ebaSPaolo Bonzini         bool should_complete;
382893f7ebaSPaolo Bonzini 
383bd48bde8SPaolo Bonzini         if (s->ret < 0) {
384bd48bde8SPaolo Bonzini             ret = s->ret;
385893f7ebaSPaolo Bonzini             goto immediate_exit;
386893f7ebaSPaolo Bonzini         }
387bd48bde8SPaolo Bonzini 
388e4654d2dSFam Zheng         cnt = bdrv_get_dirty_count(bs, s->dirty_bitmap);
389bd48bde8SPaolo Bonzini 
390bd48bde8SPaolo Bonzini         /* Note that even when no rate limit is applied we need to yield
391bd48bde8SPaolo Bonzini          * periodically with no pending I/O so that qemu_aio_flush() returns.
392bd48bde8SPaolo Bonzini          * We do so every SLICE_TIME nanoseconds, or when there is an error,
393bd48bde8SPaolo Bonzini          * or when the source is clean, whichever comes first.
394bd48bde8SPaolo Bonzini          */
395bc72ad67SAlex Bligh         if (qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - last_pause_ns < SLICE_TIME &&
396bd48bde8SPaolo Bonzini             s->common.iostatus == BLOCK_DEVICE_IO_STATUS_OK) {
397402a4741SPaolo Bonzini             if (s->in_flight == MAX_IN_FLIGHT || s->buf_free_count == 0 ||
398402a4741SPaolo Bonzini                 (cnt == 0 && s->in_flight > 0)) {
399402a4741SPaolo Bonzini                 trace_mirror_yield(s, s->in_flight, s->buf_free_count, cnt);
400bd48bde8SPaolo Bonzini                 qemu_coroutine_yield();
401bd48bde8SPaolo Bonzini                 continue;
402bd48bde8SPaolo Bonzini             } else if (cnt != 0) {
403cc8c9d6cSPaolo Bonzini                 delay_ns = mirror_iteration(s);
404cc8c9d6cSPaolo Bonzini                 if (delay_ns == 0) {
405bd48bde8SPaolo Bonzini                     continue;
406bd48bde8SPaolo Bonzini                 }
407893f7ebaSPaolo Bonzini             }
408cc8c9d6cSPaolo Bonzini         }
409893f7ebaSPaolo Bonzini 
410893f7ebaSPaolo Bonzini         should_complete = false;
411bd48bde8SPaolo Bonzini         if (s->in_flight == 0 && cnt == 0) {
412893f7ebaSPaolo Bonzini             trace_mirror_before_flush(s);
413893f7ebaSPaolo Bonzini             ret = bdrv_flush(s->target);
414893f7ebaSPaolo Bonzini             if (ret < 0) {
415b952b558SPaolo Bonzini                 if (mirror_error_action(s, false, -ret) == BDRV_ACTION_REPORT) {
416893f7ebaSPaolo Bonzini                     goto immediate_exit;
417893f7ebaSPaolo Bonzini                 }
418b952b558SPaolo Bonzini             } else {
419893f7ebaSPaolo Bonzini                 /* We're out of the streaming phase.  From now on, if the job
420893f7ebaSPaolo Bonzini                  * is cancelled we will actually complete all pending I/O and
421893f7ebaSPaolo Bonzini                  * report completion.  This way, block-job-cancel will leave
422893f7ebaSPaolo Bonzini                  * the target in a consistent state.
423893f7ebaSPaolo Bonzini                  */
424893f7ebaSPaolo Bonzini                 s->common.offset = end * BDRV_SECTOR_SIZE;
425d63ffd87SPaolo Bonzini                 if (!s->synced) {
426d63ffd87SPaolo Bonzini                     block_job_ready(&s->common);
427d63ffd87SPaolo Bonzini                     s->synced = true;
428d63ffd87SPaolo Bonzini                 }
429d63ffd87SPaolo Bonzini 
430d63ffd87SPaolo Bonzini                 should_complete = s->should_complete ||
431d63ffd87SPaolo Bonzini                     block_job_is_cancelled(&s->common);
432e4654d2dSFam Zheng                 cnt = bdrv_get_dirty_count(bs, s->dirty_bitmap);
433893f7ebaSPaolo Bonzini             }
434b952b558SPaolo Bonzini         }
435893f7ebaSPaolo Bonzini 
436893f7ebaSPaolo Bonzini         if (cnt == 0 && should_complete) {
437893f7ebaSPaolo Bonzini             /* The dirty bitmap is not updated while operations are pending.
438893f7ebaSPaolo Bonzini              * If we're about to exit, wait for pending operations before
439893f7ebaSPaolo Bonzini              * calling bdrv_get_dirty_count(bs), or we may exit while the
440893f7ebaSPaolo Bonzini              * source has dirty data to copy!
441893f7ebaSPaolo Bonzini              *
442893f7ebaSPaolo Bonzini              * Note that I/O can be submitted by the guest while
443893f7ebaSPaolo Bonzini              * mirror_populate runs.
444893f7ebaSPaolo Bonzini              */
445893f7ebaSPaolo Bonzini             trace_mirror_before_drain(s, cnt);
446893f7ebaSPaolo Bonzini             bdrv_drain_all();
447e4654d2dSFam Zheng             cnt = bdrv_get_dirty_count(bs, s->dirty_bitmap);
448893f7ebaSPaolo Bonzini         }
449893f7ebaSPaolo Bonzini 
450893f7ebaSPaolo Bonzini         ret = 0;
451cc8c9d6cSPaolo Bonzini         trace_mirror_before_sleep(s, cnt, s->synced, delay_ns);
452d63ffd87SPaolo Bonzini         if (!s->synced) {
453893f7ebaSPaolo Bonzini             /* Publish progress */
454acc906c6SPaolo Bonzini             s->common.offset = (end - cnt) * BDRV_SECTOR_SIZE;
4557483d1e5SAlex Bligh             block_job_sleep_ns(&s->common, QEMU_CLOCK_REALTIME, delay_ns);
456893f7ebaSPaolo Bonzini             if (block_job_is_cancelled(&s->common)) {
457893f7ebaSPaolo Bonzini                 break;
458893f7ebaSPaolo Bonzini             }
459893f7ebaSPaolo Bonzini         } else if (!should_complete) {
460bd48bde8SPaolo Bonzini             delay_ns = (s->in_flight == 0 && cnt == 0 ? SLICE_TIME : 0);
4617483d1e5SAlex Bligh             block_job_sleep_ns(&s->common, QEMU_CLOCK_REALTIME, delay_ns);
462893f7ebaSPaolo Bonzini         } else if (cnt == 0) {
463893f7ebaSPaolo Bonzini             /* The two disks are in sync.  Exit and report successful
464893f7ebaSPaolo Bonzini              * completion.
465893f7ebaSPaolo Bonzini              */
466893f7ebaSPaolo Bonzini             assert(QLIST_EMPTY(&bs->tracked_requests));
467893f7ebaSPaolo Bonzini             s->common.cancelled = false;
468893f7ebaSPaolo Bonzini             break;
469893f7ebaSPaolo Bonzini         }
470bc72ad67SAlex Bligh         last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
471893f7ebaSPaolo Bonzini     }
472893f7ebaSPaolo Bonzini 
473893f7ebaSPaolo Bonzini immediate_exit:
474bd48bde8SPaolo Bonzini     if (s->in_flight > 0) {
475bd48bde8SPaolo Bonzini         /* We get here only if something went wrong.  Either the job failed,
476bd48bde8SPaolo Bonzini          * or it was cancelled prematurely so that we do not guarantee that
477bd48bde8SPaolo Bonzini          * the target is a copy of the source.
478bd48bde8SPaolo Bonzini          */
479bd48bde8SPaolo Bonzini         assert(ret < 0 || (!s->synced && block_job_is_cancelled(&s->common)));
480bd48bde8SPaolo Bonzini         mirror_drain(s);
481bd48bde8SPaolo Bonzini     }
482bd48bde8SPaolo Bonzini 
483bd48bde8SPaolo Bonzini     assert(s->in_flight == 0);
4847191bf31SMarkus Armbruster     qemu_vfree(s->buf);
485b812f671SPaolo Bonzini     g_free(s->cow_bitmap);
486402a4741SPaolo Bonzini     g_free(s->in_flight_bitmap);
487e4654d2dSFam Zheng     bdrv_release_dirty_bitmap(bs, s->dirty_bitmap);
488b952b558SPaolo Bonzini     bdrv_iostatus_disable(s->target);
489d63ffd87SPaolo Bonzini     if (s->should_complete && ret == 0) {
490d63ffd87SPaolo Bonzini         if (bdrv_get_flags(s->target) != bdrv_get_flags(s->common.bs)) {
491d63ffd87SPaolo Bonzini             bdrv_reopen(s->target, bdrv_get_flags(s->common.bs), NULL);
492d63ffd87SPaolo Bonzini         }
493d63ffd87SPaolo Bonzini         bdrv_swap(s->target, s->common.bs);
49420a63d2cSFam Zheng         if (s->common.driver->job_type == BLOCK_JOB_TYPE_COMMIT) {
49520a63d2cSFam Zheng             /* drop the bs loop chain formed by the swap: break the loop then
49620a63d2cSFam Zheng              * trigger the unref from the top one */
49720a63d2cSFam Zheng             BlockDriverState *p = s->base->backing_hd;
49820a63d2cSFam Zheng             s->base->backing_hd = NULL;
49920a63d2cSFam Zheng             bdrv_unref(p);
50020a63d2cSFam Zheng         }
501d63ffd87SPaolo Bonzini     }
5024f6fd349SFam Zheng     bdrv_unref(s->target);
503893f7ebaSPaolo Bonzini     block_job_completed(&s->common, ret);
504893f7ebaSPaolo Bonzini }
505893f7ebaSPaolo Bonzini 
506893f7ebaSPaolo Bonzini static void mirror_set_speed(BlockJob *job, int64_t speed, Error **errp)
507893f7ebaSPaolo Bonzini {
508893f7ebaSPaolo Bonzini     MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
509893f7ebaSPaolo Bonzini 
510893f7ebaSPaolo Bonzini     if (speed < 0) {
511893f7ebaSPaolo Bonzini         error_set(errp, QERR_INVALID_PARAMETER, "speed");
512893f7ebaSPaolo Bonzini         return;
513893f7ebaSPaolo Bonzini     }
514893f7ebaSPaolo Bonzini     ratelimit_set_speed(&s->limit, speed / BDRV_SECTOR_SIZE, SLICE_TIME);
515893f7ebaSPaolo Bonzini }
516893f7ebaSPaolo Bonzini 
517b952b558SPaolo Bonzini static void mirror_iostatus_reset(BlockJob *job)
518b952b558SPaolo Bonzini {
519b952b558SPaolo Bonzini     MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
520b952b558SPaolo Bonzini 
521b952b558SPaolo Bonzini     bdrv_iostatus_reset(s->target);
522b952b558SPaolo Bonzini }
523b952b558SPaolo Bonzini 
524d63ffd87SPaolo Bonzini static void mirror_complete(BlockJob *job, Error **errp)
525d63ffd87SPaolo Bonzini {
526d63ffd87SPaolo Bonzini     MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
52734b5d2c6SMax Reitz     Error *local_err = NULL;
528d63ffd87SPaolo Bonzini     int ret;
529d63ffd87SPaolo Bonzini 
53034b5d2c6SMax Reitz     ret = bdrv_open_backing_file(s->target, NULL, &local_err);
531d63ffd87SPaolo Bonzini     if (ret < 0) {
53234b5d2c6SMax Reitz         error_propagate(errp, local_err);
533d63ffd87SPaolo Bonzini         return;
534d63ffd87SPaolo Bonzini     }
535d63ffd87SPaolo Bonzini     if (!s->synced) {
536d63ffd87SPaolo Bonzini         error_set(errp, QERR_BLOCK_JOB_NOT_READY, job->bs->device_name);
537d63ffd87SPaolo Bonzini         return;
538d63ffd87SPaolo Bonzini     }
539d63ffd87SPaolo Bonzini 
540d63ffd87SPaolo Bonzini     s->should_complete = true;
541d63ffd87SPaolo Bonzini     block_job_resume(job);
542d63ffd87SPaolo Bonzini }
543d63ffd87SPaolo Bonzini 
5443fc4b10aSFam Zheng static const BlockJobDriver mirror_job_driver = {
545893f7ebaSPaolo Bonzini     .instance_size = sizeof(MirrorBlockJob),
54679e14bf7SFam Zheng     .job_type      = BLOCK_JOB_TYPE_MIRROR,
547893f7ebaSPaolo Bonzini     .set_speed     = mirror_set_speed,
548b952b558SPaolo Bonzini     .iostatus_reset= mirror_iostatus_reset,
549d63ffd87SPaolo Bonzini     .complete      = mirror_complete,
550893f7ebaSPaolo Bonzini };
551893f7ebaSPaolo Bonzini 
55203544a6eSFam Zheng static const BlockJobDriver commit_active_job_driver = {
55303544a6eSFam Zheng     .instance_size = sizeof(MirrorBlockJob),
55403544a6eSFam Zheng     .job_type      = BLOCK_JOB_TYPE_COMMIT,
55503544a6eSFam Zheng     .set_speed     = mirror_set_speed,
55603544a6eSFam Zheng     .iostatus_reset
55703544a6eSFam Zheng                    = mirror_iostatus_reset,
55803544a6eSFam Zheng     .complete      = mirror_complete,
55903544a6eSFam Zheng };
56003544a6eSFam Zheng 
56103544a6eSFam Zheng static void mirror_start_job(BlockDriverState *bs, BlockDriverState *target,
56203544a6eSFam Zheng                             int64_t speed, int64_t granularity,
56303544a6eSFam Zheng                             int64_t buf_size,
56403544a6eSFam Zheng                             BlockdevOnError on_source_error,
565b952b558SPaolo Bonzini                             BlockdevOnError on_target_error,
566893f7ebaSPaolo Bonzini                             BlockDriverCompletionFunc *cb,
56703544a6eSFam Zheng                             void *opaque, Error **errp,
56803544a6eSFam Zheng                             const BlockJobDriver *driver,
56903544a6eSFam Zheng                             bool is_none_mode, BlockDriverState *base)
570893f7ebaSPaolo Bonzini {
571893f7ebaSPaolo Bonzini     MirrorBlockJob *s;
572893f7ebaSPaolo Bonzini 
573eee13dfeSPaolo Bonzini     if (granularity == 0) {
574eee13dfeSPaolo Bonzini         /* Choose the default granularity based on the target file's cluster
575eee13dfeSPaolo Bonzini          * size, clamped between 4k and 64k.  */
576eee13dfeSPaolo Bonzini         BlockDriverInfo bdi;
577eee13dfeSPaolo Bonzini         if (bdrv_get_info(target, &bdi) >= 0 && bdi.cluster_size != 0) {
578eee13dfeSPaolo Bonzini             granularity = MAX(4096, bdi.cluster_size);
579eee13dfeSPaolo Bonzini             granularity = MIN(65536, granularity);
580eee13dfeSPaolo Bonzini         } else {
581eee13dfeSPaolo Bonzini             granularity = 65536;
582eee13dfeSPaolo Bonzini         }
583eee13dfeSPaolo Bonzini     }
584eee13dfeSPaolo Bonzini 
585eee13dfeSPaolo Bonzini     assert ((granularity & (granularity - 1)) == 0);
586eee13dfeSPaolo Bonzini 
587b952b558SPaolo Bonzini     if ((on_source_error == BLOCKDEV_ON_ERROR_STOP ||
588b952b558SPaolo Bonzini          on_source_error == BLOCKDEV_ON_ERROR_ENOSPC) &&
589b952b558SPaolo Bonzini         !bdrv_iostatus_is_enabled(bs)) {
590b952b558SPaolo Bonzini         error_set(errp, QERR_INVALID_PARAMETER, "on-source-error");
591b952b558SPaolo Bonzini         return;
592b952b558SPaolo Bonzini     }
593b952b558SPaolo Bonzini 
5945bc361b8SFam Zheng 
59503544a6eSFam Zheng     s = block_job_create(driver, bs, speed, cb, opaque, errp);
596893f7ebaSPaolo Bonzini     if (!s) {
597893f7ebaSPaolo Bonzini         return;
598893f7ebaSPaolo Bonzini     }
599893f7ebaSPaolo Bonzini 
600b952b558SPaolo Bonzini     s->on_source_error = on_source_error;
601b952b558SPaolo Bonzini     s->on_target_error = on_target_error;
602893f7ebaSPaolo Bonzini     s->target = target;
60303544a6eSFam Zheng     s->is_none_mode = is_none_mode;
6045bc361b8SFam Zheng     s->base = base;
605eee13dfeSPaolo Bonzini     s->granularity = granularity;
60608e4ed6cSPaolo Bonzini     s->buf_size = MAX(buf_size, granularity);
607b812f671SPaolo Bonzini 
608b8afb520SFam Zheng     s->dirty_bitmap = bdrv_create_dirty_bitmap(bs, granularity, errp);
609b8afb520SFam Zheng     if (!s->dirty_bitmap) {
610b8afb520SFam Zheng         return;
611b8afb520SFam Zheng     }
612893f7ebaSPaolo Bonzini     bdrv_set_enable_write_cache(s->target, true);
613b952b558SPaolo Bonzini     bdrv_set_on_error(s->target, on_target_error, on_target_error);
614b952b558SPaolo Bonzini     bdrv_iostatus_enable(s->target);
615893f7ebaSPaolo Bonzini     s->common.co = qemu_coroutine_create(mirror_run);
616893f7ebaSPaolo Bonzini     trace_mirror_start(bs, s, s->common.co, opaque);
617893f7ebaSPaolo Bonzini     qemu_coroutine_enter(s->common.co, s);
618893f7ebaSPaolo Bonzini }
61903544a6eSFam Zheng 
62003544a6eSFam Zheng void mirror_start(BlockDriverState *bs, BlockDriverState *target,
62103544a6eSFam Zheng                   int64_t speed, int64_t granularity, int64_t buf_size,
62203544a6eSFam Zheng                   MirrorSyncMode mode, BlockdevOnError on_source_error,
62303544a6eSFam Zheng                   BlockdevOnError on_target_error,
62403544a6eSFam Zheng                   BlockDriverCompletionFunc *cb,
62503544a6eSFam Zheng                   void *opaque, Error **errp)
62603544a6eSFam Zheng {
62703544a6eSFam Zheng     bool is_none_mode;
62803544a6eSFam Zheng     BlockDriverState *base;
62903544a6eSFam Zheng 
63003544a6eSFam Zheng     is_none_mode = mode == MIRROR_SYNC_MODE_NONE;
63103544a6eSFam Zheng     base = mode == MIRROR_SYNC_MODE_TOP ? bs->backing_hd : NULL;
63203544a6eSFam Zheng     mirror_start_job(bs, target, speed, granularity, buf_size,
63303544a6eSFam Zheng                      on_source_error, on_target_error, cb, opaque, errp,
63403544a6eSFam Zheng                      &mirror_job_driver, is_none_mode, base);
63503544a6eSFam Zheng }
63603544a6eSFam Zheng 
63703544a6eSFam Zheng void commit_active_start(BlockDriverState *bs, BlockDriverState *base,
63803544a6eSFam Zheng                          int64_t speed,
63903544a6eSFam Zheng                          BlockdevOnError on_error,
64003544a6eSFam Zheng                          BlockDriverCompletionFunc *cb,
64103544a6eSFam Zheng                          void *opaque, Error **errp)
64203544a6eSFam Zheng {
6434da83585SJeff Cody     int64_t length, base_length;
6444da83585SJeff Cody     int orig_base_flags;
64539a611a3SJeff Cody     int ret;
646cc67f4d1SJeff Cody     Error *local_err = NULL;
6474da83585SJeff Cody 
6484da83585SJeff Cody     orig_base_flags = bdrv_get_flags(base);
6494da83585SJeff Cody 
65020a63d2cSFam Zheng     if (bdrv_reopen(base, bs->open_flags, errp)) {
65120a63d2cSFam Zheng         return;
65220a63d2cSFam Zheng     }
6534da83585SJeff Cody 
6544da83585SJeff Cody     length = bdrv_getlength(bs);
6554da83585SJeff Cody     if (length < 0) {
65639a611a3SJeff Cody         error_setg_errno(errp, -length,
65739a611a3SJeff Cody                          "Unable to determine length of %s", bs->filename);
6584da83585SJeff Cody         goto error_restore_flags;
6594da83585SJeff Cody     }
6604da83585SJeff Cody 
6614da83585SJeff Cody     base_length = bdrv_getlength(base);
6624da83585SJeff Cody     if (base_length < 0) {
66339a611a3SJeff Cody         error_setg_errno(errp, -base_length,
66439a611a3SJeff Cody                          "Unable to determine length of %s", base->filename);
6654da83585SJeff Cody         goto error_restore_flags;
6664da83585SJeff Cody     }
6674da83585SJeff Cody 
6684da83585SJeff Cody     if (length > base_length) {
66939a611a3SJeff Cody         ret = bdrv_truncate(base, length);
67039a611a3SJeff Cody         if (ret < 0) {
67139a611a3SJeff Cody             error_setg_errno(errp, -ret,
67239a611a3SJeff Cody                             "Top image %s is larger than base image %s, and "
6734da83585SJeff Cody                              "resize of base image failed",
6744da83585SJeff Cody                              bs->filename, base->filename);
6754da83585SJeff Cody             goto error_restore_flags;
6764da83585SJeff Cody         }
6774da83585SJeff Cody     }
6784da83585SJeff Cody 
67920a63d2cSFam Zheng     bdrv_ref(base);
68003544a6eSFam Zheng     mirror_start_job(bs, base, speed, 0, 0,
681cc67f4d1SJeff Cody                      on_error, on_error, cb, opaque, &local_err,
68203544a6eSFam Zheng                      &commit_active_job_driver, false, base);
6830fb6395cSMarkus Armbruster     if (local_err) {
684cc67f4d1SJeff Cody         error_propagate(errp, local_err);
6854da83585SJeff Cody         goto error_restore_flags;
6864da83585SJeff Cody     }
6874da83585SJeff Cody 
6884da83585SJeff Cody     return;
6894da83585SJeff Cody 
6904da83585SJeff Cody error_restore_flags:
6914da83585SJeff Cody     /* ignore error and errp for bdrv_reopen, because we want to propagate
6924da83585SJeff Cody      * the original error */
6934da83585SJeff Cody     bdrv_reopen(base, orig_base_flags, NULL);
6944da83585SJeff Cody     return;
69503544a6eSFam Zheng }
696