Searched hist:e31e3694afef58ba191cbcc6875ec243e5971268 (Results 1 – 2 of 2) sorted by relevance
| /qemu/ui/ |
| H A D | vnc-palette.c | d6e58090fed20e30e6966007bc4df0c04324d9e7 Fri Mar 25 08:45:54 UTC 2011 Ulrich Obergfell <uobergfe@redhat.com> severe memory leak caused by broken palette_destroy() function
The following commit breaks the code of the function palette_destroy().
http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268
The broken code causes a severe memory leak of 'VncPalette' structures
because it never frees anything:
70 void palette_destroy(VncPalette *palette)
71 {
72 if (palette == NULL) {
73 qemu_free(palette);
74 }
75 }
Version 2 of the patch calls qemu_free() unconditionally.
Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
e31e3694afef58ba191cbcc6875ec243e5971268 Fri Feb 04 08:05:58 UTC 2011 Corentin Chary <corentincj@iksaif.net> vnc: palette: use a pool to reduce memory allocations
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
|
| H A D | vnc-palette.h | e31e3694afef58ba191cbcc6875ec243e5971268 Fri Feb 04 08:05:58 UTC 2011 Corentin Chary <corentincj@iksaif.net> vnc: palette: use a pool to reduce memory allocations
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
|