Home
last modified time | relevance | path

Searched hist:c87826a878be05208c3906eb9d5e1f37cff5e98e (Results 1 – 1 of 1) sorted by relevance

/qemu/net/
H A Dtap.cc87826a878be05208c3906eb9d5e1f37cff5e98e Tue Jun 04 05:18:17 UTC 2013 Jason Wang <jasowang@redhat.com> tap: fix NULL dereference when passing invalid parameters to tap

This patch forbid the following invalid parameters to tap:

1) fd and vhostfds were specified but vhostfd were not specified
2) vhostfds were specified but fds were not specified
3) fds and vhostfd were specified

For 1 and 2, net_init_tap_one() will still pass NULL as vhostfdname to
monitor_handle_fd_param(), which may crash the qemu.

Also remove the unnecessary has_fd check.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <shajnocz@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>