Searched hist:b8c3511d086c65fa4bc2ca7a128bb3a56ac95306 (Results 1 – 1 of 1) sorted by relevance
| /qemu/ |
| H A D | qemu-bridge-helper.c | b8c3511d086c65fa4bc2ca7a128bb3a56ac95306 Tue May 14 18:03:06 UTC 2019 Markus Armbruster <armbru@redhat.com> qemu-bridge-helper: Fix misuse of isspace()
parse_acl_file() passes char values to isspace(). Undefined behavior
when the value is negative. Not a security issue, because the
characters come from trusted $prefix/etc/qemu/bridge.conf and the
files it includes.
Furthermore, isspace()'s locale-dependence means qemu-bridge-helper
uses the user's locale for parsing $prefix/etc/bridge.conf. Feels
wrong.
Use g_ascii_isspace() instead. This fixes the undefined behavior, and
makes parsing of $prefix/etc/bridge.conf locale-independent.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190514180311.16028-2-armbru@redhat.com>
|