Searched hist:"92 b19880f7f9cf7f4a9e00dc3258b8d3aa363e9d" (Results 1 – 1 of 1) sorted by relevance
/qemu/hw/sparc64/ |
H A D | sun4u.c | 92b19880f7f9cf7f4a9e00dc3258b8d3aa363e9d Thu Apr 05 09:32:30 UTC 2018 Thomas Huth <thuth@redhat.com> hw/sparc64/sun4u: Fix introspection by converting prom instance_init to realize
The instance_init function of devices should always succeed to be able to introspect the device. However, the instance_init function of the "openprom" device can currently fail, for example like this:
$ echo "{'execute':'qmp_capabilities'}"\ "{'execute':'device-list-properties',"\ " 'arguments':{'typename':'openprom'}}" \ | sparc64-softmmu/qemu-system-sparc64 -M sun4v,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 91, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}} {"return": {}} RAMBlock "sun4u.prom" already registered, abort! Aborted (core dumped)
This should not happen. Fix this problem by moving the affected code from instance_init into a realize function instead.
Signed-off-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
|