Home
last modified time | relevance | path

Searched hist:"8 f1bdb0ea136c38cf963f5fafff103e1b6fb488d" (Results 1 – 1 of 1) sorted by relevance

/qemu/system/
H A Dphysmem.c8f1bdb0ea136c38cf963f5fafff103e1b6fb488d Thu Aug 12 15:06:24 UTC 2021 Peter Maydell <peter.maydell@linaro.org> softmmu/physmem.c: Remove unneeded NULL check in qemu_ram_alloc_from_fd()

In the alignment check added to qemu_ram_alloc_from_fd() in commit
ce317be98db0dfdfa, the condition includes a check that 'mr' is not
NULL. This check is unnecessary because we can assume that the
caller always passes us a valid MemoryRegion, and indeed later in the
function we assume mr is not NULL when we pass it to file_ram_alloc()
as new_block->mr. Remove it.

Fixes: Coverity 1459867
Fixes: ce317be98d ("exec: fetch the alignment of Linux devdax pmem character device nodes")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Jingqi Liu <jingqi.liu@intel.com>
Message-id: 20210812150624.29139-1-peter.maydell@linaro.org