Searched hist:"525650 cd71104c046e4260b5acaeb275f520d5c0" (Results 1 – 1 of 1) sorted by relevance
| /qemu/target/sh4/ |
| H A D | helper.c | 525650cd71104c046e4260b5acaeb275f520d5c0 Tue Jul 23 17:24:31 UTC 2024 Peter Maydell <peter.maydell@linaro.org> target/sh4: Avoid shift into sign bit in update_itlb_use()
In update_itlb_use() the variables or_mask and and_mask are uint8_t,
which means that in expressions like "and_mask << 24" the usual C
arithmetic conversions will result in the shift being done as a
signed int type, and so we will shift into the sign bit. For QEMU
this isn't undefined behaviour because we use -fwrapv; but we can
avoid it anyway by using uint32_t types for or_mask and and_mask.
Resolves: Coverity CID 1547628
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-id: 20240723172431.1757296-1-peter.maydell@linaro.org
|