Home
last modified time | relevance | path

Searched hist:"06 b919e3fedf4798a1f0f60e0b67caa192f724a7" (Results 1 – 1 of 1) sorted by relevance

/linux/drivers/gpu/drm/
H A Ddrm_panic_qr.rs06b919e3fedf4798a1f0f60e0b67caa192f724a7 Sat Oct 19 08:22:52 UTC 2024 Thomas Böhler <witcher@wiredspace.de> drm/panic: allow verbose version check

Clippy warns about a reimplementation of `RangeInclusive::contains`:

error: manual `!RangeInclusive::contains` implementation
--> drivers/gpu/drm/drm_panic_qr.rs:986:8
|
986 | if version < 1 || version > 40 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=40).contains(&version)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
= note: `-D clippy::manual-range-contains` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]`

Ignore this and keep the current implementation as that makes it easier
to read.

Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
Reported-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1123
Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://lore.kernel.org/r/20241019084048.22336-8-witcher@wiredspace.de
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>