4ee348e27143b857445fd261cbe6695d6d57c836 - bsdinstall: Fix typos

Fri, 17 Oct 2025 15:16:32 +0000

bsdinstall: Fix typosReviewed by: emasteMFC after: 2 daysDifferential Revision: https://reviews.freebsd.org/D53170 List of files: /src/usr.sbin/bsdinstall/scripts/script

731704f5ea2f6f9d7e3c4b5ed2ad1a3cba703f42 - bsdinstall: Fix installation script splitting

Sat, 06 Jan 2024 16:55:31 +0000

bsdinstall: Fix installation script splittingThis allows writing setup scripts that contain lines starting with"#!", e.g., a shebang when creating a shell script using cat: #!/bin/sh echo "Populate rc.local" cat >/etc/rc.local<

c0e249d32c780ee8240fe8b3b8144078a8eec41f - bsdinstall: avoid conflicts with fd 3

Tue, 15 Aug 2023 15:44:02 +0000

bsdinstall: avoid conflicts with fd 3Throughout the bsdinstall script fd 3 is used by f_dprintf (set through$TERMINAL_STDOUT_PASSTHRU). In several places in the bsdinstalls scripts,we use fd 3 to juggle stdout when calling out to other tools, which cancause the installer to fail with a "Bad file descriptor" error whenf_dprintf attempts to use it.This commit replaces all constructs like this: exec 3>&1 SOME_VARIABLE=$(some command 2>&1 1>&3) exec 3>&-With: exec 5>&1 SOME_VARIABLE=$(some command 2>&1 1>&5) exec 5>&-PR: 273148Reviewed by: corvinkFixes: 1f7746d81f53447ac15cc99395bb714d4dd0a4da ("bsdinstall: stop messing with file descriptors")MFC after: 1 week List of files: /src/usr.sbin/bsdinstall/scripts/script

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 17:55:03 +0000

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /src/usr.sbin/bsdinstall/scripts/script

450b4ac23c75e2dde996c96049c0887864e22d09 - bsdinstall/script: umount before zpool export

Tue, 03 May 2022 14:01:22 +0000

bsdinstall/script: umount before zpool exportWhen running zpool export first, boot/efi and dev is still mounted sozpool export fails. By running bsdinstall umount first the pool can becleanly exported.Reviewed by: emasteDifferential Revision: https://reviews.freebsd.org/D35114Sponsored by: Beckhoff Automation GmbH & Co. KGMFC After: 3 days List of files: /src/usr.sbin/bsdinstall/scripts/script

1f7746d81f53447ac15cc99395bb714d4dd0a4da - bsdinstall: stop messing with file descriptors

Tue, 03 May 2022 14:00:09 +0000

bsdinstall: stop messing with file descriptorsThroughout the bsdinstall script fd 3 is used by f_dprintf (set through$TERMINAL_STDOUT_PASSTHRU). By closing file descriptor 3 here, thefinal f_dprintf "Installation Completed ... does not work anymore.By putting the code into a subshell, file descriptors can be editedwithout interference with the calling script.Reviewed by: emasteDifferential Revision: https://reviews.freebsd.org/D35113Sponsored by: Beckhoff Automation GmbH & Co. KGMFC after: 3 days List of files: /src/usr.sbin/bsdinstall/scripts/script

b50db44f021c12283a2e140063a6b6fcc30295e5 - bsdinstall: Avoid double-mounting /dev

Wed, 23 Jun 2021 13:42:43 +0000

bsdinstall: Avoid double-mounting /devAfter 34766aa8cb514472c571f8b0e90e833833acef51 we are mounting andunmounting devfs elsewhere already.Reviewed by: nwhitehornMFC after: 1 weekSponsored by: iXsystems, Inc.Differential Revision: https://reviews.freebsd.org/D30877 List of files: /src/usr.sbin/bsdinstall/scripts/script

5104dfbeff3e1489f1caee482c7ad1ff9be8e61d - bsdinstall: Fix typo (Instalation -> Installation).

Thu, 03 Jun 2021 04:43:14 +0000

bsdinstall: Fix typo (Instalation -> Installation). List of files: /src/usr.sbin/bsdinstall/scripts/script

40923b0c81cc2c151388ec5ead59f4bed89ac432 - Fix scripted installation from media without local distfiles.

Fri, 28 May 2021 13:53:42 +0000

Fix scripted installation from media without local distfiles.The bsdinstall script target did not have the infrastructure to fetchdistfiles from a remote server the way the interactive installer doeson e.g. bootonly media. Solve this by factoring out the parts of theinstaller that deal with fetching missing distributions into a newinstall stage called 'fetchmissingdists', which is called by both theinteractive and scripted installer frontends.In the course of these changes, cleaned up a few other issues withthe fetching of missing distribution files and added a warning iffetching the MANIFEST file, which is used to verify the integrity ofthe distribution files. We should at some point add cryptographicsignatures to MANIFEST so that it can be fetched safely if not presenton the install media (which it is for bootonly media).Initial patch by: Vinícius ZavamPR: 255659, 250928Reviewed by: dteskeMFC after: 4 weeksDifferential Revision: https://reviews.freebsd.org/D27121 List of files: /src/usr.sbin/bsdinstall/scripts/script

34766aa8cb514472c571f8b0e90e833833acef51 - Fix scripted installs on EFI systems using ZFS root with zfsboot.

Fri, 14 May 2021 12:30:41 +0000

Fix scripted installs on EFI systems using ZFS root with zfsboot.Unlike attended installations, scripted installs did not mount non-ZFSpartitions when ZFS root (via zfsboot) was selected. Since this includedthe ESP, the EFI loader was not installed. Copy logic from theattended-install path to make this work.PR: 255824, 255081MFC after: 1 weekObtained from: Mark Huizer List of files: /src/usr.sbin/bsdinstall/scripts/script

c2f16c595eb51c6e0cb6ece3f6f078d738019059 - Fix scripted installs on EFI systems after default mounting of the ESP.

Tue, 23 Mar 2021 13:19:42 +0000

Fix scripted installs on EFI systems after default mounting of the ESP.Because the ESP mount point (/boot/efi) is in mtree, tar will attempt toextract a directory at that point post-mount when the system is installed.Normally, this is fine, since tar can happily set whatever properties itwants. For FAT32 file systems, however, like the ESP, tar will attempt toset mtime on the root directory, which FAT does not support, and tar willinterpret this as a fatal error, breaking the install (seehttps://github.com/libarchive/libarchive/issues/1516). This issue wouldalso break scripted installs on bare-metal POWER8, POWER9, and PS3systems, as well as some ARM systems.This patch solves the problem in two ways:- If stdout is a TTY, use the distextract stage instead of tar, as in interactive installs. distextract solves this problem internally and provides a nicer UI to boot, but requires a TTY.- If stdout is not a TTY, use tar but, as a stopgap for 13.0, exclude boot/efi from tarball extraction and then add it by hand. This is a hack, and better solutions (as in the libarchive ticket above) will obsolete it, but it solves the most common case, leaving only unattended TTY-less installs on a few tier-2 platforms broken.In addition, fix a bug with fstab generation uncovered once the tar issueis fixed that umount(8) can depend on the ordering of lines in fstab in away that mount(8) does not. The partition editor now writes out fstab inmount order, making sure umount (run at the end of scripted, but notinteractive, installs) succeeds.PR: 254395Reviewed by: gjb, impMFC after: 3 daysDifferential Revision: https://reviews.freebsd.org/D29380 List of files: /src/usr.sbin/bsdinstall/scripts/script

a107ddbb83a7a93d3c4e40f5355e158d6976bf90 - bsdinstall: Use TMPDIR if set

Wed, 15 Jan 2020 00:45:05 +0000

bsdinstall: Use TMPDIR if setSubmitted by: Ryan Moeller Reviewed by: bcran, Nick Wolff Differential Revision: https://reviews.freebsd.org/D22979/ List of files: /src/usr.sbin/bsdinstall/scripts/script

4ee348e27143b857445fd261cbe6695d6d57c836 - bsdinstall: Fix typos

Fri, 17 Oct 2025 15:16:32 +0000

bsdinstall: Fix typosReviewed by: emasteMFC after: 2 daysDifferential Revision: https://reviews.freebsd.org/D53170 List of files: /src/usr.sbin/bsdinstall/scripts/script

731704f5ea2f6f9d7e3c4b5ed2ad1a3cba703f42 - bsdinstall: Fix installation script splitting

Sat, 06 Jan 2024 16:55:31 +0000

c0e249d32c780ee8240fe8b3b8144078a8eec41f - bsdinstall: avoid conflicts with fd 3

Tue, 15 Aug 2023 15:44:02 +0000

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 17:55:03 +0000

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /src/usr.sbin/bsdinstall/scripts/script

450b4ac23c75e2dde996c96049c0887864e22d09 - bsdinstall/script: umount before zpool export

Tue, 03 May 2022 14:01:22 +0000

1f7746d81f53447ac15cc99395bb714d4dd0a4da - bsdinstall: stop messing with file descriptors

Tue, 03 May 2022 14:00:09 +0000

b50db44f021c12283a2e140063a6b6fcc30295e5 - bsdinstall: Avoid double-mounting /dev

Wed, 23 Jun 2021 13:42:43 +0000

5104dfbeff3e1489f1caee482c7ad1ff9be8e61d - bsdinstall: Fix typo (Instalation -> Installation).

Thu, 03 Jun 2021 04:43:14 +0000

bsdinstall: Fix typo (Instalation -> Installation). List of files: /src/usr.sbin/bsdinstall/scripts/script

Changes in script

4ee348e27143b857445fd261cbe6695d6d57c836 - bsdinstall: Fix typos

731704f5ea2f6f9d7e3c4b5ed2ad1a3cba703f42 - bsdinstall: Fix installation script splitting

c0e249d32c780ee8240fe8b3b8144078a8eec41f - bsdinstall: avoid conflicts with fd 3

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

450b4ac23c75e2dde996c96049c0887864e22d09 - bsdinstall/script: umount before zpool export

1f7746d81f53447ac15cc99395bb714d4dd0a4da - bsdinstall: stop messing with file descriptors

b50db44f021c12283a2e140063a6b6fcc30295e5 - bsdinstall: Avoid double-mounting /dev

5104dfbeff3e1489f1caee482c7ad1ff9be8e61d - bsdinstall: Fix typo (Instalation -> Installation).

40923b0c81cc2c151388ec5ead59f4bed89ac432 - Fix scripted installation from media without local distfiles.

34766aa8cb514472c571f8b0e90e833833acef51 - Fix scripted installs on EFI systems using ZFS root with zfsboot.

c2f16c595eb51c6e0cb6ece3f6f078d738019059 - Fix scripted installs on EFI systems after default mounting of the ESP.

a107ddbb83a7a93d3c4e40f5355e158d6976bf90 - bsdinstall: Use TMPDIR if set

4ee348e27143b857445fd261cbe6695d6d57c836 - bsdinstall: Fix typos

731704f5ea2f6f9d7e3c4b5ed2ad1a3cba703f42 - bsdinstall: Fix installation script splitting

c0e249d32c780ee8240fe8b3b8144078a8eec41f - bsdinstall: avoid conflicts with fd 3

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

450b4ac23c75e2dde996c96049c0887864e22d09 - bsdinstall/script: umount before zpool export

1f7746d81f53447ac15cc99395bb714d4dd0a4da - bsdinstall: stop messing with file descriptors

b50db44f021c12283a2e140063a6b6fcc30295e5 - bsdinstall: Avoid double-mounting /dev

5104dfbeff3e1489f1caee482c7ad1ff9be8e61d - bsdinstall: Fix typo (Instalation -> Installation).