Changes in Makefile

e9ac41698b2f322d55ccf9da50a3596edb2c1800 - Remove residual blank line at start of Makefile

Mon, 15 Jul 2024 04:46:32 +0000

Remove residual blank line at start of MakefileThis is a residual of the $FreeBSD$ removal.MFC After: 3 days (though I'll just run the command on the branches)Sponsored by: Netflix List of files: /src/lib/googletest/tests/gtest/Makefile

0c785f06020f3b02e34c97eb27fecd3af8eb2a7b - Fix GoogleTest 1.14.0 import

Fri, 18 Aug 2023 11:28:13 +0000

Fix GoogleTest 1.14.0 import- Prune headers and tests no longer installed after the upgrade.- Remove GoogleTest-related files when MK_GOOGLETEST == no.- Disable `-Werror` with gcc to unbreak the gcc12 CI run with `lib/googletest`. Any issues found by g++ will be filed upstream and hopefully resolved in a future version.- Remove clang -Werror issues which are resolved in version 1.14.0 to avoid masking valid issues.MFC after: 1 weekMFC with: 28f6c2f292806bf31230a959bc4b19d7081669a7 List of files: /src/lib/googletest/tests/gtest/Makefile

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 17:55:03 +0000

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /src/lib/googletest/tests/gtest/Makefile

28f6c2f292806bf31230a959bc4b19d7081669a7 - Import GoogleTest 1.14.0

Tue, 08 Aug 2023 06:17:32 +0000

Import GoogleTest 1.14.0GoogleTest 1.14.0 now requires C++14 to build. Change`googletest.test.inc.mk` to reflect this requirement.Adjust the build integration logic to handle the new version ofGoogleTest (add/remove headers/sources as needed).Tighten down warnings via `CXXFLAGS.clang` instead of ignoring allwarnings. Some new warnings snuck in after I did my last round of fixsubmissions upstream.Also address some overlinking added in the previous version import byremoving superfluous libraries.===============================Expect WhenDynamicCastToTest.AmbiguousCast to failThis change reapplies the expected failure from 1.10.0.Ref: https://github.com/google/googletest/issues/2172MFC after: 2 weeksReviewed by: asomers, emasteDifferential Revision: https://reviews.freebsd.org/D41399Merge commit '8ef491440fcaec96f899d73e08873426c78583a4' into googletest-v1.14.0-import List of files: /src/lib/googletest/tests/gtest/Makefile

7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f - Rename NO_WERROR -> MK_WERROR=no

Wed, 06 Jan 2021 17:55:06 +0000

Rename NO_WERROR -> MK_WERROR=noAs suggested in D27598. This also supports MK_WERROR.clang=no andMK_WERROR.gcc=no to support the existing NO_WERROR. uses.Reviewed By: brooksDifferential Revision: https://reviews.freebsd.org/D27601 List of files: /src/lib/googletest/tests/gtest/Makefile

2ed3236082a4473c1da8f72c1ebc071a7b54321f - Major improvement to build parallelism for googletest internal tests

Mon, 19 Oct 2020 19:50:57 +0000

Major improvement to build parallelism for googletest internal testsCurrently the googletest internal tests build after the matching library.However, each of these is serialized at the top level makefile.Additionally some of the tests (e.g. the gmock-matches-test) take up to90 seconds to build with clang -O2. Having to wait for this test tocomplete before continuing to the next directory seriously slows down theparllelism of a -j32 build.Before this change running `make -C lib/googletest -j32 -s` in buildenvtook 202 seconds, now it's 153 due to improved parallelism.Reviewed By: emaste (no objection)Differential Revision: https://reviews.freebsd.org/D26748 List of files: /src/lib/googletest/tests/gtest/Makefile

7b42ad1434a8edfb2d5cbf706047725b16894b4b - Reword the comment above NO_WERROR

Thu, 21 Feb 2019 06:51:35 +0000

Reword the comment above NO_WERROR List of files: /src/lib/googletest/tests/gtest/Makefile

7481b4234ca26a7d81d6f610648dbf4ec0e44ca2 - Build death tests programmatically

Thu, 21 Feb 2019 03:37:31 +0000

Build death tests programmaticallyThe previous code hardcoded the death test build definitions in a duplicativemanner. The new code doesn't. List of files: /src/lib/googletest/tests/gtest/Makefile

dae8f2468df75c2d17c57bbb7253af88ab1f5d62 - Fix gtest test compilation and build more tests

Wed, 20 Feb 2019 07:29:50 +0000

Fix gtest test compilation and build more testsMy previous work to integrate these tests was incomplete/incorrect, because Imisunderstood how the cmake macros worked.This addresses items with the gtest tests, which in turn fixes test compilationand adds more tests which I had previously missed.Due to an unknown issue with gtest_stress_test, I had to add pthread to LIBADD,even though I shouldn't have added it to that (it was failing to link -lpthreadto libprivategtest.a). Add a XXX comment to note that something's awry thereand deserves additional investigation. List of files: /src/lib/googletest/tests/gtest/Makefile

988a9f7e39e1bea4eed03eb6f69df4cb0ec9289a - Use `GTESTS` instead of `PLAIN_TESTS_CXX`

Wed, 20 Feb 2019 01:11:30 +0000

Use `GTESTS` instead of `PLAIN_TESTS_CXX`The former is from googletest.test.mk, whereas the latter is from plain.test.mk.As noted in r344328, Kyua will adopt more native GoogleTest support. Thus, it'smore desirable to make the test interface more of an opaque blackbox for thetestcase implementer. List of files: /src/lib/googletest/tests/gtest/Makefile

fd89d5ad055b2af62e681065cddaca5f8c51fcda - Compile the tests without -Werror for now

Wed, 13 Feb 2019 05:41:04 +0000

Compile the tests without -Werror for nowI'm working on resolving the issue upstream on github List of files: /src/lib/googletest/tests/gtest/Makefile

f3c5273d315a64826d2149ac453ff8c4583ddbe8 - Merge build glue for libraries and tests done on github

Wed, 13 Feb 2019 04:58:15 +0000

Merge build glue for libraries and tests done on githubI need to doublecheck my work vs the port, but I believe that this covers theinitial integration of all upstream tests.Ref: https://github.com/ngie-eign/freebsd/tree/googletest-integration List of files: /src/lib/googletest/tests/gtest/Makefile