en Copyright 2025 Java http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#f44ac8cc9c10d7305223a10b8dbd8e234388cc73 sh: Fix job pointer invalidation with trapsasyncCalling dotrap() can do almost anything, including reallocating thejobtab array. Convert the job pointer to an index before callingdotrap() and then restore a proper job pointer afterwards.PR: 290330Reported by: bdreweryReviewed by: bdreweryDifferential Revision: https://reviews.freebsd.org/D53793 List of files: /src/bin/sh/tests/execution/Makefile Mon, 17 Nov 2025 17:42:01 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#e9ac41698b2f322d55ccf9da50a3596edb2c1800 Remove residual blank line at start of MakefileThis is a residual of the $FreeBSD$ removal.MFC After: 3 days (though I'll just run the command on the branches)Sponsored by: Netflix List of files: /src/bin/sh/tests/execution/Makefile Mon, 15 Jul 2024 04:46:32 +0000 Warner Losh <imp@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /src/bin/sh/tests/execution/Makefile Wed, 16 Aug 2023 17:55:03 +0000 Warner Losh <imp@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#52981a1694be7a70013e5149c020706c9b6411f9 sh/tests: Add a second kind of binary scripts without #!One of the reasons for git commite0f5c1387df23c8c4811f5b24a7ef6ecac51a71a was to make "actually portableexecutables" work. Add a test that is more like those.MFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Sun, 03 Jan 2021 20:27:50 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#1cffe8b812e5efda80d7c68dab86d2e1906ef088 sh: Keep ignored SIGINT/SIGQUIT after set in a background jobIf job control is not enabled, a background job (... &) ignores SIGINT andSIGQUIT, but this can be reverted using the trap builtin in the same shellenvironment.Using the set builtin to change options would also revert SIGINT and SIGQUITto their previous dispositions.This broke due to r317298. Calling setsignal() reverts the effect ofignoresig().Reported by: bdreweryMFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Fri, 28 Aug 2020 15:35:45 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#7312c97fa4611ccecff9122d6e4e8681b0539679 sh/tests: Add tests for SIGINT in non-jobc background commandsIf job control is not enabled, background commands shall ignore SIGINT andSIGQUIT, and it shall be possible to override that ignore in the same shell.MFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Sun, 14 Jun 2020 19:41:24 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#e0f5c1387df23c8c4811f5b24a7ef6ecac51a71a sh: Allow more scripts without #!Austin Group bugs #1226 and #1250 changed the requirements for shell scriptswithout #! (POSIX does not specify #!; this is about the shell executionwhen execve(2) returns an [ENOEXEC] error).POSIX says we shall allow execution if the initial part intended to beparsed by the shell consists of characters and does not contain the NULcharacter. This allows concatenating a shell script (ending with exec orexit) and a binary payload.In order to reject common binary files such as PNG images, check that thereis a lowercase letter or expansion before the last newline before the NULcharacter, in addition to the check for the newline character suggested byPOSIX. List of files: /src/bin/sh/tests/execution/Makefile Sat, 30 May 2020 16:00:49 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#6bc7175f315bd4e2c334d60ee3364cbff63574f1 sh: Fix double INTON with vforkThe shell maintains a count of the number of times SIGINT processing hasbeen disabled via INTOFF, so SIGINT processing resumes when all disableshave enabled again (INTON).If an error occurs in a vfork() child, the processing of the error enablesSIGINT processing again, and the INTON in vforkexecshell() causes the countto become negative.As a result, a later INTOFF may not actually disable SIGINT processing. Thismight cause memory corruption if a SIGINT arrives at an inopportune time. Asof r360452, it causes the shell to abort when it would unsafely allocate orfree memory in certain ways.Note that various places such as errors in non-special builtinsunconditionally reset the count to 0, so the problem might still not alwaysbe visible.PR: 246497Reported by: jbeichMFC after: 2 weeks List of files: /src/bin/sh/tests/execution/Makefile Sat, 16 May 2020 16:29:23 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#2a55bade0ed3e08a8c4f922df0ecf67d1ee32f53 sh: Test that executing various binary files is rejectedIf executing a file fails with an [ENOEXEC] error, the shell executes thefile as a shell script, except that this execution may instead result in anerror message if the file is binary.Per a recent Austin Group interpretation, we will need to change this toallow a concatenation of a shell script and a binary payload. SeeAustin Group bugs #1226 and #1250.MFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Mon, 30 Dec 2019 21:32:55 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#18b18078f267ba10cf14348bc333f2f81818f472 MFhead@r344527 List of files: /src/bin/sh/tests/execution/Makefile Mon, 25 Feb 2019 18:00:14 +0000 Enji Cooper <ngie@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#a8fe8db49af4c10e35349ffff217caf3c3df7f72 Merge ^/head r344178 through r344512. List of files: /src/bin/sh/tests/execution/Makefile Mon, 25 Feb 2019 11:59:29 +0000 Dimitry Andric <dim@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#484160a9cf236a5892c1ab8344de287d7a1472c1 sh: Add set -o pipefailThe pipefail option allows checking the exit status of all commands in apipeline more easily, at a limited cost of complexity in sh itself. It workssimilarly to the option in bash, ksh93 and mksh.Like ksh93 and unlike bash and mksh, the state of the option is saved when apipeline is started. Therefore, even in the case of commands like A | B &a later change of the option does not change the exit status, the same way (A | B) &works.Since SIGPIPE is not handled specially, more work in the script is requiredfor a proper exit status for pipelines containing commands such as head thatmay terminate successfully without reading all input. This can be somethinglike( cmd1 r=$? if [ "$r" -gt 128 ] && [ "$(kill -l "$r")" = PIPE ]; then exit 0 else exit "$r" fi) | headPR: 224270Relnotes: yes List of files: /src/bin/sh/tests/execution/Makefile Sun, 24 Feb 2019 21:05:13 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#993b1e419cf5127136f1a1316a8ebf9699fc3784 sh: Add test for exported but unset variablesPR: 233545 List of files: /src/bin/sh/tests/execution/Makefile Thu, 03 Jan 2019 20:23:12 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#f44ac8cc9c10d7305223a10b8dbd8e234388cc73 sh: Fix job pointer invalidation with trapsasyncCalling dotrap() can do almost anything, including reallocating thejobtab array. Convert the job pointer to an index before callingdotrap() and then restore a proper job pointer afterwards.PR: 290330Reported by: bdreweryReviewed by: bdreweryDifferential Revision: https://reviews.freebsd.org/D53793 List of files: /src/bin/sh/tests/execution/Makefile Mon, 17 Nov 2025 17:42:01 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#e9ac41698b2f322d55ccf9da50a3596edb2c1800 Remove residual blank line at start of MakefileThis is a residual of the $FreeBSD$ removal.MFC After: 3 days (though I'll just run the command on the branches)Sponsored by: Netflix List of files: /src/bin/sh/tests/execution/Makefile Mon, 15 Jul 2024 04:46:32 +0000 Warner Losh <imp@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /src/bin/sh/tests/execution/Makefile Wed, 16 Aug 2023 17:55:03 +0000 Warner Losh <imp@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#52981a1694be7a70013e5149c020706c9b6411f9 sh/tests: Add a second kind of binary scripts without #!One of the reasons for git commite0f5c1387df23c8c4811f5b24a7ef6ecac51a71a was to make "actually portableexecutables" work. Add a test that is more like those.MFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Sun, 03 Jan 2021 20:27:50 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#1cffe8b812e5efda80d7c68dab86d2e1906ef088 sh: Keep ignored SIGINT/SIGQUIT after set in a background jobIf job control is not enabled, a background job (... &) ignores SIGINT andSIGQUIT, but this can be reverted using the trap builtin in the same shellenvironment.Using the set builtin to change options would also revert SIGINT and SIGQUITto their previous dispositions.This broke due to r317298. Calling setsignal() reverts the effect ofignoresig().Reported by: bdreweryMFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Fri, 28 Aug 2020 15:35:45 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#7312c97fa4611ccecff9122d6e4e8681b0539679 sh/tests: Add tests for SIGINT in non-jobc background commandsIf job control is not enabled, background commands shall ignore SIGINT andSIGQUIT, and it shall be possible to override that ignore in the same shell.MFC after: 1 week List of files: /src/bin/sh/tests/execution/Makefile Sun, 14 Jun 2020 19:41:24 +0000 Jilles Tjoelker <jilles@FreeBSD.org> http://opengrok.net:8080/history/src/bin/sh/tests/execution/Makefile#e0f5c1387df23c8c4811f5b24a7ef6ecac51a71a sh: Allow more scripts without #!Austin Group bugs #1226 and #1250 changed the requirements for shell scriptswithout #! (POSIX does not specify #!; this is about the shell executionwhen execve(2) returns an [ENOEXEC] error).POSIX says we shall allow execution if the initial part intended to beparsed by the shell consists of characters and does not contain the NULcharacter. This allows concatenating a shell script (ending with exec orexit) and a binary payload.In order to reject common binary files such as PNG images, check that thereis a lowercase letter or expansion before the last newline before the NULcharacter, in addition to the check for the newline character suggested byPOSIX. List of files: /src/bin/sh/tests/execution/Makefile Sat, 30 May 2020 16:00:49 +0000 Jilles Tjoelker <jilles@FreeBSD.org>