qemu/scripts/checkpatch.pl

1332 sub ERROR {  subroutine
1396 	ERROR("Saw unacceptable licenses '" . join(',', @unknown) .
1450 		ERROR("Do not add expected files together with tests, " .
1489 			ERROR("do not set execute permissions for source " .
1504 			ERROR("New file '" . $fileinfo->{filenew} .
1514 		ERROR("New file '" . $fileinfo->{filenew} . "' must " .
1787 			ERROR("please use python3 interpreter\n" . $herecurr);
1796 		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
1806 				ERROR("The correct form is \"Signed-off-by\"\n" .
1810 				ERROR("space required after Signed-off-by:\n" .
1832 			    ERROR("Tag $tag not permitted in QEMU code, " .
1840 			ERROR("patch seems to be corrupt (line wrapped?)\n" .
1853 			ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1857 			ERROR("Doubly-encoded UTF-8\n" . $herecurr);
1914 			ERROR("headers imported from Linux should be self-" .
1926 			ERROR("DOS line endings\n" . $herevet);
1934 			ERROR("code blocks in documentation should have " .
1940 			ERROR("trailing whitespace\n" . $herevet);
1947 				ERROR("Don't use '#' flag of printf format ('%#') in " .
1958 					ERROR("Hex numbers must be prefixed with '0x'\n" .
1974 				ERROR("line over 90 characters\n" . $herecurr);
1982 			ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr);
1987 			ERROR("adding a line without newline at end of file\n" . $herecurr);
1992 			ERROR("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
2003 			ERROR("code indent should never use tabs\n" . $herevet);
2146 				ERROR("switch and case should be at the same indent\n$hereline$err");
2180 				ERROR("that open brace { should be on the previous line\n" .
2189 					ERROR("trailing semicolon indicates no statements, indent implies otherwise\n" .
2197 			ERROR("suspicious ; after while (0)\n" . $herecurr);
2202 			ERROR("superfluous trailing semicolon\n" . $herecurr);
2287 …ERROR("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_…
2310 				ERROR("TEST: is type\n" . $herecurr);
2312 				ERROR("TEST: is not type ($1 is)\n". $herecurr);
2319 				ERROR("TEST: is attr\n" . $herecurr);
2321 				ERROR("TEST: is not attr ($1 is)\n". $herecurr);
2329 			ERROR("that open brace { should be on the previous line\n" . $hereprev);
2340 				ERROR("malformed #include filename\n" .
2348 			ERROR("do not use C99 // comments\n" . $herecurr);
2356 			ERROR("do not initialise globals to 0 or NULL\n" .
2361 			ERROR("do not initialise statics to 0 or NULL\n" .
2380 				ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr);
2397 				ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr);
2405 			ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
2411 			ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
2416 			ERROR("missing space after $1 definition\n" . $herecurr);
2431 				ERROR("space prohibited before open square bracket '['\n" . $herecurr);
2465 				ERROR("space prohibited between function name and open parenthesis '('\n" . $herecurr);
2539 						ERROR("space required after that '$op' $at\n" . $hereptr);
2554 						ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
2562 						ERROR("space required after that '$op' $at\n" . $hereptr);
2579 						ERROR("space required before that '$op' $at\n" . $hereptr);
2585 						ERROR("space prohibited after that '$op' $at\n" . $hereptr);
2591 						ERROR("space required one side of that '$op' $at\n" . $hereptr);
2595 						ERROR("space prohibited before that '$op' $at\n" . $hereptr);
2598 						ERROR("space prohibited after that '$op' $at\n" . $hereptr);
2605 						ERROR("space prohibited before that '$op' $at\n" . $hereptr);
2640 						ERROR("spaces required around that '$op' $at\n" . $hereptr);
2650 			ERROR("space required before the open brace '{'\n" . $herecurr);
2656 			ERROR("space required after that close brace '}'\n" . $herecurr);
2661 			ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
2664 			ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
2670 			ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
2675 			ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
2695 				ERROR("return is not a function, parentheses are not required\n" . $herecurr);
2698 				ERROR("space required before the open parenthesis '('\n" . $herecurr);
2705 				ERROR("return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2711 			ERROR("named $1 should be typedefed separately\n" . $herecurr);
2716 			ERROR("space required before the open parenthesis '('\n" . $herecurr);
2744 				ERROR("do not use assignment in if condition\n" . $herecurr);
2766 				ERROR("trailing statements should be on next line\n" . $herecurr . $stat_real);
2782 			ERROR("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2790 				ERROR("trailing statements should be on next line\n" . $herecurr);
2795 			ERROR("trailing statements should be on next line\n" .
2805 			ERROR("trailing statements should be on next line\n" . $herecurr);
2812 			ERROR("else should follow close brace '}'\n" . $hereprev);
2825 				ERROR("while should follow close brace '}'\n" . $hereprev);
2838 			ERROR("Whitespace after \\ makes next lines useless\n" . $herecurr);
2920 …ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n…
2930 					ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
3002 					ERROR("braces {} are necessary for all arms of this statement\n" . $herectx);
3070 				ERROR("braces {} are necessary even for single statement blocks\n" . $herectx);
3080                         ERROR($msg);
3085 			ERROR("if this code is redundant consider removing it\n" .
3093 				ERROR("g_free(NULL) is safe this check is probably not required\n" . $hereprev);
3106 			ERROR("exactly one space required after that #$1\n" . $herecurr);
3111 				ERROR("memory barrier without comment\n" . $herecurr);
3123 			ERROR("storage class should be at the beginning of the declaration\n" . $herecurr)
3130 			ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
3135 			ERROR("sizeof(& should be avoided\n" . $herecurr);
3152 				ERROR("externs should be avoided in .c files\n" .  $herecurr);
3156 				ERROR("arguments for function declarations should follow identifier\n" . $herecurr);
3162 			ERROR("externs should be avoided in .c files\n" .  $herecurr);
3168 				ERROR("unnecessary cast may hide bugs, use g_$1new$3 instead\n" . $herecurr);
3170 				ERROR("unnecessary cast may hide bugs, use g_$1renew$3 instead\n" . $herecurr);
3176 			ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
3186 			ERROR("use g_memdup2() instead of unsafe g_memdup()\n" . $herecurr);
3191 			ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr);
3195 			ERROR("use sigaction to establish signal handlers; signal is not portable\n" . $herecurr);
3199 …ERROR("use qemu_bh_new_guarded() instead of qemu_bh_new() to avoid reentrancy problems\n" . $herec…
3203 …ERROR("use aio_bh_new_guarded() instead of aio_bh_new() to avoid reentrancy problems\n" . $herecur…
3207 			ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr);
3232 			ERROR("initializer for struct $1 should normally be const\n" .
3243 				ERROR("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
3247 				ERROR("Don't use '#' flag of printf format " .
3255 			ERROR("use QEMU instead of Qemu or QEmu\n" . $herecurr);
3278 			ERROR("Error messages should not contain newlines\n" . $herecurr);
3301 				ERROR("Error messages should not contain newlines\n" . $herecurr);
3307 			ERROR("use ctz32() instead of ffs()\n" . $herecurr);
3310 			ERROR("use ctz32() or ctz64() instead of ffsl()\n" . $herecurr);
3313 			ERROR("use ctz64() instead of ffsll()\n" . $herecurr);
3316 			ERROR("use memset() instead of bzero()\n" . $herecurr);
3319 			ERROR("use qemu_real_host_page_size() instead of getpagesize()\n" . $herecurr);
3322 			ERROR("use qemu_real_host_page_size() instead of sysconf(_SC_PAGESIZE)\n" . $herecurr);
3325 			ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr);
3328 			ERROR("use g_assert_not_reached() instead of assert(false)\n" .
3332 			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
3353 			ERROR("Use g_assert or g_assert_not_reached\n". $herecurr);
3363 		ERROR("Missing Signed-off-by: line(s)\n");
3385 		ERROR("Does not appear to be a unified-diff format patch\n");