29 typedef void (*check_fn)(struct check *c, struct dt_info *dti, struct node *node);
61 static inline void  PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,  in check_msg()  argument
83 	} else if (streq(dti->outname, "-")) {  in check_msg()
86 		xasprintf(&str, "%s", dti->outname);  in check_msg()
120 #define FAIL(c, dti, node, ...)						\  argument
124 		check_msg((c), dti, node, NULL, __VA_ARGS__);		\
127 #define FAIL_PROP(c, dti, node, prop, ...)				\  argument
131 		check_msg((c), dti, node, prop, __VA_ARGS__);		\
135 static void check_nodes_props(struct check *c, struct dt_info *dti, struct node *node)  in check_nodes_props()  argument
141 		c->fn(c, dti, node);  in check_nodes_props()
144 		check_nodes_props(c, dti, child);  in check_nodes_props()
155 static bool run_check(struct check *c, struct dt_info *dti)  in run_check()  argument
157 	struct node *dt = dti->dt;  in run_check()
170 		error = error || run_check(prq, dti);  in run_check()
173 			check_msg(c, dti, NULL, NULL, "Failed prerequisite '%s'",  in run_check()
181 	check_nodes_props(c, dti, dt);  in run_check()
200 static inline void check_always_fail(struct check *c, struct dt_info *dti,  in check_always_fail()  argument
203 	FAIL(c, dti, node, "always_fail check");  in check_always_fail()
207 static void check_is_string(struct check *c, struct dt_info *dti,  in check_is_string()  argument
218 		FAIL_PROP(c, dti, node, prop, "property is not a string");  in check_is_string()
225 static void check_is_string_list(struct check *c, struct dt_info *dti,  in check_is_string_list()  argument
242 			FAIL_PROP(c, dti, node, prop, "property is not a string list");  in check_is_string_list()
254 static void check_is_cell(struct check *c, struct dt_info *dti,  in check_is_cell()  argument
265 		FAIL_PROP(c, dti, node, prop, "property is not a single cell");  in check_is_cell()
276 static void check_duplicate_node_names(struct check *c, struct dt_info *dti,  in check_duplicate_node_names()  argument
286 				FAIL(c, dti, child2, "Duplicate node name");  in check_duplicate_node_names()
290 static void check_duplicate_property_names(struct check *c, struct dt_info *dti,  in check_duplicate_property_names()  argument
300 				FAIL_PROP(c, dti, node, prop, "Duplicate property name");  in check_duplicate_property_names()
313 static void check_node_name_chars(struct check *c, struct dt_info *dti,  in check_node_name_chars()  argument
319 		FAIL(c, dti, node, "Bad character '%c' in node name",  in check_node_name_chars()
324 static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,  in check_node_name_chars_strict()  argument
330 		FAIL(c, dti, node, "Character '%c' not recommended in node name",  in check_node_name_chars_strict()
335 static void check_node_name_format(struct check *c, struct dt_info *dti,  in check_node_name_format()  argument
339 		FAIL(c, dti, node, "multiple '@' characters in node name");  in check_node_name_format()
343 static void check_node_name_not_empty(struct check *c, struct dt_info *dti,  in check_node_name_not_empty()  argument
347 		FAIL(c, dti, node, "Empty node name");  in check_node_name_not_empty()
352 					     struct dt_info *dti,  in check_node_name_vs_property_name()  argument
359 		FAIL(c, dti, node, "node name and property name conflict");  in check_node_name_vs_property_name()
365 static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti,  in check_unit_address_vs_reg()  argument
384 			FAIL(c, dti, node, "node has a reg or ranges property, but no unit name");  in check_unit_address_vs_reg()
387 			FAIL(c, dti, node, "node has a unit name, but no reg or ranges property");  in check_unit_address_vs_reg()
392 static void check_property_name_chars(struct check *c, struct dt_info *dti,  in check_property_name_chars()  argument
401 			FAIL_PROP(c, dti, node, prop, "Bad character '%c' in property name",  in check_property_name_chars()
408 					     struct dt_info *dti,  in check_property_name_chars_strict()  argument
433 			FAIL_PROP(c, dti, node, prop, "Character '%c' not recommended in property name",  in check_property_name_chars_strict()
446 static void check_duplicate_label(struct check *c, struct dt_info *dti,  in check_duplicate_label()  argument
450 	struct node *dt = dti->dt;  in check_duplicate_label()
467 		FAIL(c, dti, node, "Duplicate label '%s' on " DESCLABEL_FMT  in check_duplicate_label()
473 static void check_duplicate_label_node(struct check *c, struct dt_info *dti,  in check_duplicate_label_node()  argument
480 		check_duplicate_label(c, dti, l->label, node, NULL, NULL);  in check_duplicate_label_node()
486 			check_duplicate_label(c, dti, l->label, node, prop, NULL);  in check_duplicate_label_node()
489 			check_duplicate_label(c, dti, m->ref, node, prop, m);  in check_duplicate_label_node()
494 static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,  in check_phandle_prop()  argument
497 	struct node *root = dti->dt;  in check_phandle_prop()
507 		FAIL_PROP(c, dti, node, prop, "bad length (%d) %s property",  in check_phandle_prop()
519 			FAIL(c, dti, node, "%s is a reference to another node",  in check_phandle_prop()
533 		FAIL_PROP(c, dti, node, prop, "bad value (0x%x) in %s property",  in check_phandle_prop()
541 static void check_explicit_phandles(struct check *c, struct dt_info *dti,  in check_explicit_phandles()  argument
544 	struct node *root = dti->dt;  in check_explicit_phandles()
551 	phandle = check_phandle_prop(c, dti, node, "phandle");  in check_explicit_phandles()
553 	linux_phandle = check_phandle_prop(c, dti, node, "linux,phandle");  in check_explicit_phandles()
560 		FAIL(c, dti, node, "mismatching 'phandle' and 'linux,phandle'"  in check_explicit_phandles()
568 		FAIL(c, dti, node, "duplicated phandle 0x%x (seen before at %s)",  in check_explicit_phandles()
577 static void check_name_properties(struct check *c, struct dt_info *dti,  in check_name_properties()  argument
593 		FAIL(c, dti, node, "\"name\" property is incorrect (\"%s\" instead"  in check_name_properties()
611 static void fixup_phandle_references(struct check *c, struct dt_info *dti,  in fixup_phandle_references()  argument
614 	struct node *dt = dti->dt;  in fixup_phandle_references()
627 				if (!(dti->dtsflags & DTSF_PLUGIN))  in fixup_phandle_references()
628 					FAIL(c, dti, node, "Reference to non-existent node or "  in fixup_phandle_references()
646 static void fixup_path_references(struct check *c, struct dt_info *dti,  in fixup_path_references()  argument
649 	struct node *dt = dti->dt;  in fixup_path_references()
662 				FAIL(c, dti, node, "Reference to non-existent node or label \"%s\"\n",  in fixup_path_references()
677 static void fixup_omit_unused_nodes(struct check *c, struct dt_info *dti,  in fixup_omit_unused_nodes()  argument
700 static void check_names_is_string_list(struct check *c, struct dt_info *dti,  in check_names_is_string_list()  argument
710 		check_is_string_list(c, dti, node);  in check_names_is_string_list()
715 static void check_alias_paths(struct check *c, struct dt_info *dti,  in check_alias_paths()  argument
730 		if (!(dti->dtsflags & DTSF_PLUGIN) &&  in check_alias_paths()
731 		    (!prop->val.val || !get_node_by_path(dti->dt, prop->val.val))) {  in check_alias_paths()
732 			FAIL_PROP(c, dti, node, prop, "aliases property is not a valid node (%s)",  in check_alias_paths()
738 			FAIL(c, dti, node, "aliases property name must include only lowercase and '-'");  in check_alias_paths()
743 static void fixup_addr_size_cells(struct check *c, struct dt_info *dti,  in fixup_addr_size_cells()  argument
767 static void check_reg_format(struct check *c, struct dt_info *dti,  in check_reg_format()  argument
778 		FAIL(c, dti, node, "Root node has a \"reg\" property");  in check_reg_format()
783 		FAIL_PROP(c, dti, node, prop, "property is empty");  in check_reg_format()
790 		FAIL_PROP(c, dti, node, prop, "property has invalid length (%d bytes) "  in check_reg_format()
796 static void check_ranges_format(struct check *c, struct dt_info *dti,  in check_ranges_format()  argument
808 		FAIL_PROP(c, dti, node, prop, "Root node has a \"%s\" property",  in check_ranges_format()
821 			FAIL_PROP(c, dti, node, prop, "empty \"%s\" property but its "  in check_ranges_format()
826 			FAIL_PROP(c, dti, node, prop, "empty \"%s\" property but its "  in check_ranges_format()
831 		FAIL_PROP(c, dti, node, prop, "\"%s\" property has invalid length (%d bytes) "  in check_ranges_format()
844 static void check_pci_bridge(struct check *c, struct dt_info *dti, struct node *node)  in check_pci_bridge()  argument
857 		FAIL(c, dti, node, "node name is not \"pci\" or \"pcie\"");  in check_pci_bridge()
861 		FAIL(c, dti, node, "missing ranges for PCI bridge (or not a bridge)");  in check_pci_bridge()
864 		FAIL(c, dti, node, "incorrect #address-cells for PCI bridge");  in check_pci_bridge()
866 		FAIL(c, dti, node, "incorrect #size-cells for PCI bridge");  in check_pci_bridge()
873 		FAIL_PROP(c, dti, node, prop, "value must be 2 cells");  in check_pci_bridge()
878 		FAIL_PROP(c, dti, node, prop, "1st cell must be less than or equal to 2nd cell");  in check_pci_bridge()
880 		FAIL_PROP(c, dti, node, prop, "maximum bus number must be less than 256");  in check_pci_bridge()
885 static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struct node *node)  in check_pci_device_bus_num()  argument
910 		FAIL_PROP(c, dti, node, prop, "PCI bus number %d out of range, expected (%d - %d)",  in check_pci_device_bus_num()
915 static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct node *node)  in check_pci_device_reg()  argument
932 		FAIL_PROP(c, dti, node, prop, "PCI reg config space address cells 2 and 3 must be 0");  in check_pci_device_reg()
939 		FAIL_PROP(c, dti, node, prop, "PCI reg address is not configuration space");  in check_pci_device_reg()
941 		FAIL_PROP(c, dti, node, prop, "PCI reg config space address register number must be 0");  in check_pci_device_reg()
953 	FAIL(c, dti, node, "PCI unit address format error, expected \"%s\"",  in check_pci_device_reg()
979 static void check_simple_bus_bridge(struct check *c, struct dt_info *dti, struct node *node)  in check_simple_bus_bridge()  argument
987 static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct node *node)  in check_simple_bus_reg()  argument
1011 			FAIL(c, dti, node, "missing or empty reg/ranges property");  in check_simple_bus_reg()
1021 		FAIL(c, dti, node, "simple-bus unit address format error, expected \"%s\"",  in check_simple_bus_reg()
1030 static void check_i2c_bus_bridge(struct check *c, struct dt_info *dti, struct node *node)  in check_i2c_bus_bridge()  argument
1049 		FAIL(c, dti, node, "incorrect #address-cells for I2C bus");  in check_i2c_bus_bridge()
1051 		FAIL(c, dti, node, "incorrect #size-cells for I2C bus");  in check_i2c_bus_bridge()
1059 static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node *node)  in check_i2c_bus_reg()  argument
1076 		FAIL(c, dti, node, "missing or empty reg property");  in check_i2c_bus_reg()
1085 		FAIL(c, dti, node, "I2C bus unit address format error, expected \"%s\"",  in check_i2c_bus_reg()
1095 				FAIL_PROP(c, dti, node, prop, "I2C address must be less than 10-bits, got \"0x%x\"",  in check_i2c_bus_reg()
1098 …FAIL_PROP(c, dti, node, prop, "I2C address must be less than 7-bits, got \"0x%x\". Set I2C_TEN_BIT…  in check_i2c_bus_reg()
1108 static void check_spi_bus_bridge(struct check *c, struct dt_info *dti, struct node *node)  in check_spi_bus_bridge()  argument
1134 			FAIL(c, dti, node, "node name for SPI buses should be 'spi'");  in check_spi_bus_bridge()
1142 		FAIL(c, dti, node, "incorrect #address-cells for SPI bus");  in check_spi_bus_bridge()
1144 		FAIL(c, dti, node, "incorrect #size-cells for SPI bus");  in check_spi_bus_bridge()
1149 static void check_spi_bus_reg(struct check *c, struct dt_info *dti, struct node *node)  in check_spi_bus_reg()  argument
1168 		FAIL(c, dti, node, "missing or empty reg property");  in check_spi_bus_reg()
1175 		FAIL(c, dti, node, "SPI bus unit address format error, expected \"%s\"",  in check_spi_bus_reg()
1180 static void check_unit_address_format(struct check *c, struct dt_info *dti,  in check_unit_address_format()  argument
1192 		FAIL(c, dti, node, "unit name should not have leading \"0x\"");  in check_unit_address_format()
1197 		FAIL(c, dti, node, "unit name should not have leading 0s");  in check_unit_address_format()
1205 static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti,  in check_avoid_default_addr_size()  argument
1220 		FAIL(c, dti, node, "Relying on default #address-cells value");  in check_avoid_default_addr_size()
1223 		FAIL(c, dti, node, "Relying on default #size-cells value");  in check_avoid_default_addr_size()
1228 static void check_avoid_unnecessary_addr_size(struct check *c, struct dt_info *dti,  in check_avoid_unnecessary_addr_size()  argument
1251 …FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\", \"dma-ranges\" or c…  in check_avoid_unnecessary_addr_size()
1270 						struct dt_info *dti,  in check_unique_unit_address_common()  argument
1301 				FAIL(c, dti, childb, "duplicate unit-address (also used in node %s)", childa->fullpath);  in check_unique_unit_address_common()
1306 static void check_unique_unit_address(struct check *c, struct dt_info *dti,  in check_unique_unit_address()  argument
1309 	check_unique_unit_address_common(c, dti, node, false);  in check_unique_unit_address()
1313 static void check_unique_unit_address_if_enabled(struct check *c, struct dt_info *dti,  in check_unique_unit_address_if_enabled()  argument
1316 	check_unique_unit_address_common(c, dti, node, true);  in check_unique_unit_address_if_enabled()
1322 						       struct dt_info *dti,  in check_obsolete_chosen_interrupt_controller()  argument
1325 	struct node *dt = dti->dt;  in check_obsolete_chosen_interrupt_controller()
1339 		FAIL_PROP(c, dti, node, prop,  in check_obsolete_chosen_interrupt_controller()
1345 static void check_chosen_node_is_root(struct check *c, struct dt_info *dti,  in check_chosen_node_is_root()  argument
1351 	if (node->parent != dti->dt)  in check_chosen_node_is_root()
1352 		FAIL(c, dti, node, "chosen node must be at root node");  in check_chosen_node_is_root()
1356 static void check_chosen_node_bootargs(struct check *c, struct dt_info *dti,  in check_chosen_node_bootargs()  argument
1369 	check_is_string(c, dti, node);  in check_chosen_node_bootargs()
1373 static void check_chosen_node_stdout_path(struct check *c, struct dt_info *dti,  in check_chosen_node_stdout_path()  argument
1386 		FAIL_PROP(c, dti, node, prop, "Use 'stdout-path' instead");  in check_chosen_node_stdout_path()
1390 	check_is_string(c, dti, node);  in check_chosen_node_stdout_path()
1401 					struct dt_info *dti,  in check_property_phandle_args()  argument
1406 	struct node *root = dti->dt;  in check_property_phandle_args()
1410 		FAIL_PROP(c, dti, node, prop,  in check_property_phandle_args()
1429 			if (dti->dtsflags & DTSF_PLUGIN)  in check_property_phandle_args()
1444 				FAIL_PROP(c, dti, node, prop,  in check_property_phandle_args()
1451 			FAIL_PROP(c, dti, node, prop,  in check_property_phandle_args()
1463 			FAIL(c, dti, node, "Missing property '%s' in node %s or bad phandle (referred from %s[%d])",  in check_property_phandle_args()
1472 			FAIL_PROP(c, dti, node, prop,  in check_property_phandle_args()
1481 					  struct dt_info *dti,  in check_provider_cells_property()  argument
1491 	check_property_phandle_args(c, dti, node, prop, provider);  in check_provider_cells_property()
1531 					  struct dt_info *dti,  in check_gpios_property()  argument
1549 		check_property_phandle_args(c, dti, node, prop, &provider);  in check_gpios_property()
1556 					   struct dt_info *dti,  in check_deprecated_gpio_property()  argument
1568 		FAIL_PROP(c, dti, node, prop,  in check_deprecated_gpio_property()
1591 				     struct dt_info *dti,  in check_interrupt_provider()  argument
1599 		FAIL(c, dti, node,  in check_interrupt_provider()
1605 		FAIL(c, dti, node,  in check_interrupt_provider()
1613 				struct dt_info *dti,  in check_interrupt_map()  argument
1616 	struct node *root = dti->dt;  in check_interrupt_map()
1625 		FAIL(c, dti, node,  in check_interrupt_map()
1634 		FAIL_PROP(c, dti, node, prop,  in check_interrupt_map()
1639 		FAIL_PROP(c, dti, node, irq_map_prop,  in check_interrupt_map()
1653 			FAIL_PROP(c, dti, node, irq_map_prop,  in check_interrupt_map()
1663 			if (!(dti->dtsflags & DTSF_PLUGIN))  in check_interrupt_map()
1664 				FAIL_PROP(c, dti, node, irq_map_prop,  in check_interrupt_map()
1672 			FAIL_PROP(c, dti, node, irq_map_prop,  in check_interrupt_map()
1682 …FAIL(c, dti, node, "Missing property '#interrupt-cells' in node %s or bad phandle (referred from i…  in check_interrupt_map()
1691 			FAIL_PROP(c, dti, node, irq_map_prop,  in check_interrupt_map()
1697 			FAIL_PROP(c, dti, node, irq_map_prop,  in check_interrupt_map()
1705 				      struct dt_info *dti,  in check_interrupts_property()  argument
1708 	struct node *root = dti->dt;  in check_interrupts_property()
1718 		FAIL_PROP(c, dti, node, irq_prop, "size (%d) is invalid, expected multiple of %zu",  in check_interrupts_property()
1733 				if (dti->dtsflags & DTSF_PLUGIN)  in check_interrupts_property()
1735 				FAIL_PROP(c, dti, parent, prop, "Invalid phandle");  in check_interrupts_property()
1741 				FAIL_PROP(c, dti, parent, prop, "Bad phandle");  in check_interrupts_property()
1745 				FAIL(c, dti, irq_node,  in check_interrupts_property()
1755 		FAIL(c, dti, node, "Missing interrupt-parent");  in check_interrupts_property()
1767 		FAIL_PROP(c, dti, node, prop,  in check_interrupts_property()
1782 static void check_graph_nodes(struct check *c, struct dt_info *dti,  in check_graph_nodes()  argument
1794 …FAIL(c, dti, node, "root node contains endpoint node '%s', potentially misplaced remote-endpoint p…  in check_graph_nodes()
1810 static void check_graph_reg(struct check *c, struct dt_info *dti,  in check_graph_reg()  argument
1822 		FAIL(c, dti, node, "graph node malformed 'reg' property");  in check_graph_reg()
1828 		FAIL(c, dti, node, "graph node unit address error, expected \"%s\"",  in check_graph_reg()
1832 		FAIL_PROP(c, dti, node, get_property(node, "#address-cells"),  in check_graph_reg()
1836 		FAIL_PROP(c, dti, node, get_property(node, "#size-cells"),  in check_graph_reg()
1841 static void check_graph_port(struct check *c, struct dt_info *dti,  in check_graph_port()  argument
1847 	check_graph_reg(c, dti, node);  in check_graph_port()
1850 	if (dti->dtsflags & DTSF_PLUGIN)  in check_graph_port()
1854 		FAIL(c, dti, node, "graph port node name should be 'port'");  in check_graph_port()
1858 static struct node *get_remote_endpoint(struct check *c, struct dt_info *dti,  in get_remote_endpoint()  argument
1874 	node = get_node_by_phandle(dti->dt, phandle);  in get_remote_endpoint()
1876 		FAIL_PROP(c, dti, endpoint, prop, "graph phandle is not valid");  in get_remote_endpoint()
1881 static void check_graph_endpoint(struct check *c, struct dt_info *dti,  in check_graph_endpoint()  argument
1889 	check_graph_reg(c, dti, node);  in check_graph_endpoint()
1892 	if (dti->dtsflags & DTSF_PLUGIN)  in check_graph_endpoint()
1896 		FAIL(c, dti, node, "graph endpoint node name should be 'endpoint'");  in check_graph_endpoint()
1898 	remote_node = get_remote_endpoint(c, dti, node);  in check_graph_endpoint()
1902 	if (get_remote_endpoint(c, dti, remote_node) != node)  in check_graph_endpoint()
1903 		FAIL(c, dti, node, "graph connection to node '%s' is not bidirectional",  in check_graph_endpoint()
2060 void process_checks(bool force, struct dt_info *dti)  in process_checks()  argument
2069 			error = error || run_check(c, dti);  in process_checks()