22    	Fixed the typo in sis630_access (Thanks to Mark M. Hoffman)
28 	used Host Master Clock 56KHz (default 14KHz).For now we save old Host
29 	Master Clock and after transaction completed restore (otherwise
32 	Fixed typo in sis630_access
33 	Fixed logical error by restoring of Host Master Clock
99 MODULE_PARM_DESC(high_clock, "Set Host Master Clock to 56KHz (default 14KHz).");
129 		dev_dbg(&adap->dev, "SMBus busy (%02x).Resetting...\n",temp);  in sis630_transaction_start()
134 			dev_dbg(&adap->dev, "Failed! (%02x)\n", temp);  in sis630_transaction_start()
135 			return -EBUSY;  in sis630_transaction_start()
137 			dev_dbg(&adap->dev, "Successful!\n");  in sis630_transaction_start()
141 	/* save old clock, so we can prevent machine for hung */  in sis630_transaction_start()
144 	dev_dbg(&adap->dev, "saved clock 0x%02x\n", *oldclock);  in sis630_transaction_start()
146 	/* disable timeout interrupt , set Host Master Clock to 56KHz if requested */  in sis630_transaction_start()
177 		dev_dbg(&adap->dev, "SMBus Timeout!\n");  in sis630_transaction_wait()
178 		result = -ETIMEDOUT;  in sis630_transaction_wait()
182 		dev_dbg(&adap->dev, "Error: Failed bus transaction\n");  in sis630_transaction_wait()
183 		result = -ENXIO;  in sis630_transaction_wait()
187 		dev_err(&adap->dev, "Bus collision!\n");  in sis630_transaction_wait()
188 		result = -EIO;  in sis630_transaction_wait()
206 	dev_dbg(&adap->dev, "SMB_CNT before clock restore 0x%02x\n", sis630_read(SMB_CNT));  in sis630_transaction_end()
209 	 * restore old Host Master Clock if high_clock is set  in sis630_transaction_end()
215 	dev_dbg(&adap->dev, "SMB_CNT after clock restore 0x%02x\n", sis630_read(SMB_CNT));  in sis630_transaction_end()
238 		len = data->block[0];  in sis630_block_data()
245 			dev_dbg(&adap->dev, "set data 0x%02x\n", data->block[i]);  in sis630_block_data()
247 			sis630_write(SMB_BYTE+(i-1)%8, data->block[i]);  in sis630_block_data()
249 				dev_dbg(&adap->dev, "start trans len=%d i=%d\n",len ,i);  in sis630_block_data()
256 			else if ((i-1)%8 == 7 || i==len) {  in sis630_block_data()
257 				dev_dbg(&adap->dev, "trans_wait len=%d i=%d\n",len,i);  in sis630_block_data()
259 					dev_dbg(&adap->dev, "clear smbary_sts len=%d i=%d\n",len,i);  in sis630_block_data()
270 					dev_dbg(&adap->dev, "trans_wait failed\n");  in sis630_block_data()
278 		data->block[0] = len = 0;  in sis630_block_data()
286 				dev_dbg(&adap->dev, "trans_wait failed\n");  in sis630_block_data()
291 				data->block[0] = sis630_read(SMB_COUNT);  in sis630_block_data()
294 			if (data->block[0] > 32)  in sis630_block_data()
295 				data->block[0] = 32;  in sis630_block_data()
297 			dev_dbg(&adap->dev, "block data read len=0x%x\n", data->block[0]);  in sis630_block_data()
299 			for (i=0; i < 8 && len < data->block[0]; i++,len++) {  in sis630_block_data()
300 				dev_dbg(&adap->dev, "read i=%d len=%d\n", i, len);  in sis630_block_data()
301 				data->block[len+1] = sis630_read(SMB_BYTE+i);  in sis630_block_data()
304 			dev_dbg(&adap->dev, "clear smbary_sts len=%d i=%d\n",len,i);  in sis630_block_data()
308 		} while(len < data->block[0]);  in sis630_block_data()
338 				sis630_write(SMB_BYTE, data->byte);  in sis630_access()
346 				sis630_write(SMB_BYTE, data->word & 0xff);  in sis630_access()
347 				sis630_write(SMB_BYTE + 1,(data->word & 0xff00) >> 8);  in sis630_access()
357 			dev_warn(&adap->dev, "Unsupported transaction %d\n",  in sis630_access()
359 			return -EOPNOTSUPP;  in sis630_access()
374 			data->byte = sis630_read(SMB_BYTE);  in sis630_access()
378 			data->word = sis630_read(SMB_BYTE) + (sis630_read(SMB_BYTE + 1) << 8);  in sis630_access()
408 		dev_err(&sis630_dev->dev, "WARNING: Can't detect SIS630 compatible device, but "  in sis630_setup()
412 		return -ENODEV;  in sis630_setup()
416 	   Enable ACPI first , so we can accsess reg 74-75  in sis630_setup()
420 		dev_err(&sis630_dev->dev, "Error: Can't read bios ctl reg\n");  in sis630_setup()
421 		retval = -ENODEV;  in sis630_setup()
427 		dev_err(&sis630_dev->dev, "Error: Can't enable ACPI\n");  in sis630_setup()
428 		retval = -ENODEV;  in sis630_setup()
434 		dev_err(&sis630_dev->dev, "Error: Can't determine ACPI base address\n");  in sis630_setup()
435 		retval = -ENODEV;  in sis630_setup()
439 	dev_dbg(&sis630_dev->dev, "ACPI base at 0x%04x\n", acpi_base);  in sis630_setup()
449 		dev_err(&sis630_dev->dev, "SMBus registers 0x%04x-0x%04x already "  in sis630_setup()
451 		retval = -EBUSY;  in sis630_setup()
486 		dev_err(&dev->dev, "SIS630 comp. bus not detected, module not inserted.\n");  in sis630_probe()
487 		return -ENODEV;  in sis630_probe()
491 	sis630_adapter.dev.parent = &dev->dev;  in sis630_probe()