kvm-unit-tests/scripts/checkpatch.pl

1017 	    or warn "No structs that should be const will be found - file '$conststructsfile': $!\n";
2918 …"DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/s…
3101 						 "address part of email should not have comments: '$email_address'\n" . $herecurr) &&
3107 				# Only one name comment should be allowed
3116 				# have an email name. In addition comments should strictly
3155 						 "Unexpected content after email: '$email', should be: '$new_email'\n" . $herecurr) &&
3177 …  "Co-developed-by: should not be used to attribute nominal patch author '$author'\n" . $herecurr);
3195 …"Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . …
3198 …"Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . …
3263 			     "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
3313 				     "Patch version information should be after the --- line\n" . $herecurr);
3327 				     "'$tag' should be followed by a public http(s) link\n" . $herecurr);
3439 …"DT bindings should be in DT schema format. See: Documentation/devicetree/bindings/writing-schema.…
3459 			    "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
3796 								  "DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)\n" . $herecurr) &&
3804 						     "DT binding headers should be licensed (GPL-2.0-only OR .*)\n" . $herecurr);
3917 				  "code indent should use tabs where possible\n" . $herevet) &&
3940 				"Assignment operator '$1' should be on the previous line\n" . $hereprev) &&
3952 				"Logical continuations should be on the previous line\n" . $hereprev) &&
3968 					 "Statements should start on a tabstop\n" . $herecurr) &&
3996 						"Alignment should match open parenthesis\n" . $hereprev) &&
4071 				     "Block comments should align the * on each line\n" . $hereprev);
4174 			    "Lines should not end with a '$1'\n" . $herecurr);
4309 # statements should be at the same indent.
4327 				      "switch and case should be at the same indent\n$hereline$err");
4362 				      "that open brace { should be on the previous line\n" .
4439 				#  1) blank lines, they should be at 0,
4569 				  "that open brace { should be on the previous line\n" . $hereprev) &&
4595 				      "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr);
4615 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
4656 			     "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
4682 … "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
4708 			     "static const char * array should probably be static const char * const\n" .
4712 # check for initialized const char arrays that should be static const
4715 				 "const array should probably be static const\n" . $herecurr) &&
4724 			     "static char array declaration should probably be static const char\n" .
4733 				     "'const $found const *' should probably be 'const $found * const'\n" . $herecurr);
4736 				     "'const $found const' should probably be 'const $found'\n" . $herecurr);
4775 				  "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) &&
4798 			# Should start with a space.
4800 			# Should not end with a space.
4802 			# '*'s should not have spaces between.
4809 					  "\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr) &&
4823 			# Should start with a space.
4825 			# Should not end with a space.
4827 			# '*'s should not have spaces between.
4830 			# Modifiers should have spaces.
4836 					  "\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr) &&
4859 …"LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $…
4868 # printk should use KERN_* levels
4871 			     "printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
4900 # trace_printk should not be used in production code.
4914 # ENOTSUPP is not a standard error code and should be avoided in new patches.
5188 				# ; should have either the end of line or a space or \ after it
5254 				# unary operators should have a space before and
5422 			    "multiple assignments should be avoided\n" . $herecurr);
5437 ##				     "declaring multiple variables together should be avoided\n" . $herecurr);
5459 # closing brace should have a space following it when it has anything
5510 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
5522 # ie: (foo->bar)(); should be foo->bar();
5569 				 "labels should not be indented\n" . $herecurr) &&
5576 # check if a statement with a comma should be two statements like:
5577 #	foo = bar(),	/* comma should be semicolon */
5624 				$msg = " - maybe == should be = ?" if ($comp eq "==");
5644 				 "Comparisons should place the constant on the right side of the test\n" . $herecurr) &&
5659 # Return of what appears to be an errno should normally be negative
5664 				     "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
5755 					  "trailing statements should be on next line\n" . $herecurr . $stat_real) &&
5787 # if and else should not have general statements after it
5793 				      "trailing statements should be on next line\n" . $herecurr);
5796 # if should not continue a brace
5799 			      "trailing statements should be on next line (or did you mean 'else if'?)\n" .
5802 # case and default should not have general statements after them
5810 			      "trailing statements should be on next line\n" . $herecurr);
5818 				  "else should follow close brace '}'\n" . $hereprev) &&
5844 					  "while should follow close brace '}'\n" . $hereprev) &&
5926 # multi-statement macros should be enclosed in a do while loop, grab the
6017 …"Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic d…
6020 …			      "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
6023 					      "Macros with complex values should be enclosed in parentheses\n" . "$herectx");
6080 				     "Macros with flow control statements should be avoided\n" . "$herectx");
6100 # macro should not end with a semicolon
6126 					     "Single statement macros should not use a do {} while (0) loop\n" . "$herectx");
6130 					     "do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
6138 				     "macros should not use a trailing semicolon\n" . "$herectx");
6200 						    "braces {} should be used on all arms of this statement\n" . $herectx);
6361 				"Concatenated strings should use spaces between elements\n" . $herecurr) &&
6546 					    "$attr should be placed after $var\n" . $herecurr)) ||
6549 					   "$attr should be placed after $var\n" . $herecurr))) &&
6585 # check for __read_mostly with const non-pointer (should just be const)
6602 				 "$constant_func should be $func\n" . $herecurr) &&
6644 #			print "#ifdef in C files should be avoided\n";
6726 			    "architecture specific defines should be avoided\n" .  $herecurr);
6732 			     "storage class '$2' should be located before type '$1'\n" . $herecurr);
6740 			     "storage class should be at the beginning of the declaration\n" . $herecurr);
6748 			      "inline keyword should sit between storage class and type\n" . $herecurr);
6878 			     "sizeof(& should be avoided\n" . $herecurr);
6884 				 "sizeof $1 should be sizeof($1)\n" . $herecurr) &&
6893 			     "struct spinlock should be spinlock_t\n" . $herecurr);
7025 # strcpy uses that should likely be strscpy
7031 # strlcpy uses that should likely be strscpy
7037 # strncpy uses that should likely be strscpy or strscpy_pad
7043 # ethtool_sprintf uses that should likely be ethtool_puts
7082 				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
7094 …"usleep_range should not use min == max args; see Documentation/timers/timers-howto.rst\n" . "$her…
7116 # check for simple sscanf that should be kstrto<foo>
7138 				"extern prototypes should be avoided in .h files\n" . $herecurr) &&
7158 				     "externs should be avoided in .c files\n" .  $herecurr);
7163 				     "arguments for function declarations should follow identifier\n" . $herecurr);
7185 			     "externs should be avoided in .c files\n" .  $herecurr);
7197 					     "function definition argument '$arg' should also have an identifier name\n" . $herecurr);
7242 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
7361 			     "switch default: should use break\n" . $herectx);
7367 				 "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr) &&
7450 			     "struct $1 should normally be const\n" . $herecurr);
7478 			     "Using $1 should generally have parentheses around the comparison\n" . $herecurr);
7486 				 "return sysfs_emit(...) formats should include a terminating newline\n" . $herecurr) &&
7492 # check for array definition/declarations that should use flexible arrays instead
7617 # Mode permission misuses where it seems decimal should be octal